[GitHub] jmeter issue #233: Bug 60274

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/233
  
It appears similar feature is now available a 3rd party plugin :

* https://jmeter-plugins.org/?search=Weighted

So I propose to close this one.


---

[GitHub] jmeter issue #233: Bug 60274

[blindio]

Github user blindio commented on the issue:

https://github.com/apache/jmeter/pull/233
  
Agreed, I need to find some time to consider this issue.  I may be that the
variable resolution is not feasible without major changes.

Again, thank you,

Thorson

On Nov 13, 2016 1:18 AM, "Vladimir Sitnikov" 
wrote:

> I will test and consider a solution
>
> The question is if that is feasible at all to support run-time variable
> changes and keep the performance sane
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #233: Bug 60274

[vlsi]

Github user vlsi commented on the issue:

https://github.com/apache/jmeter/pull/233
  
> I will test and consider a solution

The question is if that is feasible at all to support run-time variable 
changes and keep the performance sane


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #233: Bug 60274

[blindio]

Github user blindio commented on the issue:

https://github.com/apache/jmeter/pull/233
  
Regarding the run time variable changes, that is a really good point.  I
will test and consider a solution.

Thank you,

Thorson

On Nov 12, 2016 11:39 PM, "Vladimir Sitnikov" 
wrote:

> *@vlsi* commented on this pull request.
> --
>
> In src/components/org/apache/jmeter/control/WeightedDistributionController
> .java
> :
>
> > + *the index of the child node
> + * @return the child test element
> + */
> +public TestElement getChildTestElement(int idx) {
> +JMeterTreeNode childNode = getChildNode(idx);
> +return childNode == null ? null : childNode.getTestElement();
> +}
> +
> +/**
> + * Gets the cumulative probability.
> + *
> + * @return the cumulative probability
> + */
> +public int getCumulativeProbability() {
> +// recalculate if reset flag is set
> +if (resetCumulativeProbability) {
>
> Can you clarify when weight is recalculated?
> The documentation suggests that weight is recalculated at run-time,
> however the flag resetCumulativeProbability is reset at design time only.
> That is it looks like weight distribution would not account for the
> variable changes in the runtime. Is that the case? Can you make
> documentation/intention more clear?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #233: Bug 60274

[vlsi]

Github user vlsi commented on the issue:

https://github.com/apache/jmeter/pull/233
  
Just in case, C and C1 has the following groovy post-processor: 
`vars.put("x", String.valueOf(1+Integer.parseInt(vars.get("x"`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #233: Bug 60274

[blindio]

Github user blindio commented on the issue:

https://github.com/apache/jmeter/pull/233
  
That is strange about the nesting not working, given that I manually tested
nesting, and it is one of the unit tests as well. I will investigate.

On Nov 13, 2016 12:08 AM, "Vladimir Sitnikov" 
wrote:

> While being able to enable-disable and rename the children from WDC UI is
> nice, I wonder how many worms are hidden in that "keep WDC and children
> tree" consistent can.
>
> Nested "Weighted Distribution Controller" elements does not seem to work.
>
> [image: 2016-11-13 11 05 00]
> 

>
> [image: 2016-11-13 11 05 04]
> 

>
> [image: 2016-11-13 11 05 09]
> 

>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #233: Bug 60274

[blindio]

Github user blindio commented on the issue:

https://github.com/apache/jmeter/pull/233
  
The reason that I do not rely on the seed is because, as I understand it,
you can count on seed to be consistent within am implementation of random,
but not across implementations.

Users of 3rd party JVMs may have consistent failures in the unit tests
because their implementation of Random provides a different distribution
than those using the Open/Oracle JVM.

Since the intention of the test is to determine if all potential random
numbers bin correctly, the systematic approach guarantees correct binning.

Furthermore, magic numbers in unit tests should be avoided if at all
possible.

-Thorson

On Nov 12, 2016 11:33 PM, "Vladimir Sitnikov" 
wrote:

> *@vlsi* commented on this pull request.
> --
>
> In src/components/org/apache/jmeter/control/WeightedDistributionController
> .java
> :
>
> > +} else if (currSubCtrl instanceof TestElement) {
> +nextSubController = (TestElement) currSubCtrl;
> +}
> +
> +if (!(nextSubController.isEnabled()) && (nextSubController 
instanceof Controller || nextSubController instanceof Sampler)) {
> +setNextSubController();
> +}
> +} else {
> +nextSubController = null;
> +}
> +}
> +}
> +
> +/**
> + * This abstraction is necessary for unit tests, in which case a 
deterministic
> + * generator replaces the random one
>
> Why can't seed be used in order to make test consistent?
> There are at least two ways:
> 1) Hard-code seed value right into the test
> 2) Use random seed, and enable configuring the seed from the command line.
> That way if a test with some specific seed value fails, we can reproduce 
it
> by supplying that particular value.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #233: Bug 60274

[vlsi]

Github user vlsi commented on the issue:

https://github.com/apache/jmeter/pull/233
  
While being able to enable-disable and rename the children from WDC UI is 
nice, I wonder how many worms are hidden in that "keep WDC and children tree" 
consistent can.


Nested "Weighted Distribution Controller" elements does not seem to work.

https://cloud.githubusercontent.com/assets/213894/20244397/18f73646-a991-11e6-81bd-945e78f0823a.png;>

https://cloud.githubusercontent.com/assets/213894/20244398/21b7d0f6-a991-11e6-81cc-9f35087a9ce9.png;>

https://cloud.githubusercontent.com/assets/213894/20244400/25cf7d60-a991-11e6-9a44-b737539af738.png;>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #233: Bug 60274

[blindio]

Github user blindio commented on the issue:

https://github.com/apache/jmeter/pull/233
  
Not yet, things got hectic for me at work, will resolve in a little while

On Nov 12, 2016 5:38 AM, "Philippe M"  wrote:

> Hi @blindio  ,
> Did you have time working on the reported issues ?
> Thanks
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #233: Bug 60274

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/233
  
Hi @blindio ,
Did you have time working on the reported issues ?
Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #233: Bug 60274

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/233
  
Hi Again,
For info, in your commit, no need to include the HTML files, only XML for 
documentation.
Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #233: Bug 60274

[blindio]

Github user blindio commented on the issue:

https://github.com/apache/jmeter/pull/233
  
Thank you Philippe, I will make these changes in the next day or so


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #233: Bug 60274

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/233
  
Hi Thorson,
Sorry for late reply, we are in the middle of 3.1 release preparation and I 
was on holiday.
Thanks again for you PR.
I started reviewing, few notes:

- WeightedDistributionController#initValueReplacer() => 
GuiPackage.getInstance() is null in Non GUI mode which is the expected mode for 
running load test. So if this is really needed (TestElement should avoid using 
GuiPackage.getInstance()) , the test should be done on nullity of 
GuiPackage.getInstance() to avoid Exception throwing and cached

- Same note for WeightedDistributionController#getNode()


RandomIntegerGenerator:

- When seed is not set, using ThreadLocalRandom.current() might be better

SubControllerIterator:

- Vector must be avoided

determineCurrentTestElement:

- Why do you test currSubController.isEnabled() ? Could you improve javadoc 
to make the algo clear for me ?

-Regarding code style, I'd prefer to have each class in its own file or 
static internal rather than having multiple classes in the same file 
(WeightedDistributionController => RandomIntegerGenerator, IntegerGenerator), 
SubControllerIterator might be better internal static ?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #233: Bug 60274

[blindio]

Github user blindio commented on the issue:

https://github.com/apache/jmeter/pull/233
  
Hi Philippe-

I have not heard anything for a while and wanted to know if you had an idea 
when someone would be able to review this.

Thanks,

Thorson


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #233: Bug 60274

[blindio]

Github user blindio commented on the issue:

https://github.com/apache/jmeter/pull/233
  
I look forward to your feedback


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #233: Bug 60274

[pmouawad]

Github user pmouawad commented on the issue:

https://github.com/apache/jmeter/pull/233
  
Thanks for this contribution !
We will review it ASAP and give you feedback.
Regards
Philippe M.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] jmeter issue #233: Bug 60274

[blindio]

Github user blindio commented on the issue:

https://github.com/apache/jmeter/pull/233
  
All build and test errors that I believe that I introduced  are resolved. 
Please tell me if this is incorrect.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---