[GitHub] jmeter pull request #429: Fix 62887. Customized SampleLabel is ignored and o...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/jmeter/pull/429


---

[GitHub] jmeter pull request #429: Fix 62887. Customized SampleLabel is ignored and o...

[artem-fedorov]

Github user artem-fedorov commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/429#discussion_r232936723
  
--- Diff: bin/testfiles/TEST_HTTP_HttpClient4.xml ---
@@ -144,7 +144,7 @@
   
   
   
-  
--- End diff --

If you expect `HR-FollowRedirect-21` here we can  fix it using this small 
hack:
```
if (redirect >= MAX_REDIRECTS) {
lastRes = errorResult(new IOException("Exceeded maximum number 
of redirects: " + MAX_REDIRECTS), new HTTPSampleResult(lastRes));
lastRes.setSampleLabel(totalRes.getSampleLabel()); // use 
parent label 
totalRes.addSubResult(lastRes);
}
```


---

[GitHub] jmeter pull request #429: Fix 62887. Customized SampleLabel is ignored and o...

[artem-fedorov]

Github user artem-fedorov commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/429#discussion_r232621358
  
--- Diff: bin/testfiles/TEST_HTTP_Java.xml ---
@@ -120,7 +120,7 @@
   
   
   
-  
--- End diff --

Same note here


---

[GitHub] jmeter pull request #429: Fix 62887. Customized SampleLabel is ignored and o...

[artem-fedorov]

Github user artem-fedorov commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/429#discussion_r232621287
  
--- Diff: bin/testfiles/TEST_HTTP_HttpClient4.xml ---
@@ -144,7 +144,7 @@
   
   
   
-  
--- End diff --

Because first 20 subSamples were added 
[here](https://github.com/apache/jmeter/blob/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java#L1593)
 and the last SampleResult was 
[generated](https://github.com/apache/jmeter/blob/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java#L983)
 from previous SubResult (that was renamed) and added 
[here](https://github.com/apache/jmeter/blob/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java#L1603).


---

[GitHub] jmeter pull request #429: Fix 62887. Customized SampleLabel is ignored and o...

[artem-fedorov]

Github user artem-fedorov commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/429#discussion_r232611414
  
--- Diff: bin/testfiles/Bug52310.xml ---
@@ -2,16 +2,16 @@
 
 
 
-  
--- End diff --

From the bug I understand, that JMeter will change subResults labels only 
if this labels are equals. 
The parent label is `HTTP-Request-HC31`, subResults labels start with 
`http://jmeter.apache.org/.` They are not equals and JMeter does not change 
them.


---

[GitHub] jmeter pull request #429: Fix 62887. Customized SampleLabel is ignored and o...

[artem-fedorov]

Github user artem-fedorov commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/429#discussion_r232611468
  
--- Diff: bin/testfiles/HTMLParserTestFile_2.xml ---
@@ -10,7 +10,7 @@
 
 file:testfiles/HTMLParserTestFile_2.html
   
-  
--- End diff --

Same note here


---

[GitHub] jmeter pull request #429: Fix 62887. Customized SampleLabel is ignored and o...

[pmouawad]

Github user pmouawad commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/429#discussion_r232387245
  
--- Diff: bin/testfiles/HTMLParserTestFile_2.xml ---
@@ -10,7 +10,7 @@
 
 file:testfiles/HTMLParserTestFile_2.html
   
-  
--- End diff --

Same note here


---

[GitHub] jmeter pull request #429: Fix 62887. Customized SampleLabel is ignored and o...

[pmouawad]

Github user pmouawad commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/429#discussion_r232387123
  
--- Diff: bin/testfiles/Bug52310.xml ---
@@ -2,16 +2,16 @@
 
 
 
-  
--- End diff --

I don't understand why this test result is modified. 
The result should be numbered sub results no ?


---

[GitHub] jmeter pull request #429: Fix 62887. Customized SampleLabel is ignored and o...

[pmouawad]

Github user pmouawad commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/429#discussion_r232387286
  
--- Diff: bin/testfiles/HTMLParserTestFile_2.xml ---
@@ -10,7 +10,7 @@
 
 file:testfiles/HTMLParserTestFile_2.html
   
-  
+  
--- End diff --

Same note here


---

[GitHub] jmeter pull request #429: Fix 62887. Customized SampleLabel is ignored and o...

[pmouawad]

Github user pmouawad commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/429#discussion_r232387592
  
--- Diff: bin/testfiles/TEST_HTTP_HttpClient4.xml ---
@@ -144,7 +144,7 @@
   
   
   
-  
--- End diff --

I don't understand this modification. Why 20 instead of 21 ?


---

[GitHub] jmeter pull request #429: Fix 62887. Customized SampleLabel is ignored and o...

[pmouawad]

Github user pmouawad commented on a diff in the pull request:

https://github.com/apache/jmeter/pull/429#discussion_r232387619
  
--- Diff: bin/testfiles/TEST_HTTP_Java.xml ---
@@ -120,7 +120,7 @@
   
   
   
-  
--- End diff --

Same note here



---

[GitHub] jmeter pull request #429: Fix 62887. Customized SampleLabel is ignored and o...

[artem-fedorov]

GitHub user artem-fedorov opened a pull request:

https://github.com/apache/jmeter/pull/429

Fix 62887.  Customized SampleLabel is ignored and overwritten by JMet…

…er 5.0



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/artem-fedorov/jmeter fix-62887

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/jmeter/pull/429.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #429


commit 561e26c1843b8dd85c77df090825c2860c1d5694
Author: Artem Fedorov 
Date:   2018-11-09T09:54:22Z

Fix 62887.  Customized SampleLabel is ignored and overwritten by JMeter 5.0




---