[GitHub] [joshua] tteofili commented on issue #88: Update path to env, remove git command

2019-06-13 Thread GitBox
tteofili commented on issue #88: Update path to env, remove git command URL: https://github.com/apache/joshua/pull/88#issuecomment-501750271 thx James for your PR, did you also try running the script with a "usual" $JOSHUA dir being a git repo?

[GitHub] [joshua] jamesewoo commented on issue #88: Update path to env, remove git command

2019-06-13 Thread GitBox
jamesewoo commented on issue #88: Update path to env, remove git command URL: https://github.com/apache/joshua/pull/88#issuecomment-501808560 Running it like that would work fine, but my use case is running inside a container where just the Joshua runtime binaries have been copied over.

[GitHub] [joshua] jamesewoo opened a new pull request #88: Update path to env, remove git command

2019-06-12 Thread GitBox
jamesewoo opened a new pull request #88: Update path to env, remove git command URL: https://github.com/apache/joshua/pull/88 Fixes for running in an Ubuntu Docker container where $JOSHUA is not a git repo This is an

[GitHub] [joshua] tteofili merged pull request #87: Using replace() instead of replaceAll() for non-regex patterns

2019-05-12 Thread GitBox
tteofili merged pull request #87: Using replace() instead of replaceAll() for non-regex patterns URL: https://github.com/apache/joshua/pull/87 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [joshua] bd2019us opened a new pull request #87: Using replace() instead of replaceAll() for non-regex patterns

2019-04-20 Thread GitBox
bd2019us opened a new pull request #87: Using replace() instead of replaceAll() for non-regex patterns URL: https://github.com/apache/joshua/pull/87 [JOSHUA-342](https://issues.apache.org/jira/browse/JOSHUA-342) Using replace() instead replaceAll() when no regex is used removes the

[GitHub] [joshua] tteofili merged pull request #89: Add OpenJDK dependency required for "jni.h"

2019-09-29 Thread GitBox
tteofili merged pull request #89: Add OpenJDK dependency required for "jni.h" URL: https://github.com/apache/joshua/pull/89 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [joshua] magali-joine opened a new pull request #89: Add OpenJDK dependency required for "jni.h"

2019-09-25 Thread GitBox
magali-joine opened a new pull request #89: Add OpenJDK dependency required for "jni.h" URL: https://github.com/apache/joshua/pull/89 Fixes docker build: Solves ``` 100%] Linking CXX executable ../tests/model_test [100%] Built target model_test

[GitHub] [joshua] tteofili merged pull request #88: Update path to env, remove git command

2019-06-14 Thread GitBox
tteofili merged pull request #88: Update path to env, remove git command URL: https://github.com/apache/joshua/pull/88 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [joshua] tteofili merged pull request #90: Remove bashism

2020-04-12 Thread GitBox
tteofili merged pull request #90: Remove bashism URL: https://github.com/apache/joshua/pull/90 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [joshua] iadbbwarln opened a new pull request #90: Remove bashism

2020-04-12 Thread GitBox
iadbbwarln opened a new pull request #90: Remove bashism URL: https://github.com/apache/joshua/pull/90 Remove bashism and requirement for system to have /bin/sh == bash. This is required to run on Debian10 amd64. This

[GitHub] [joshua] tteofili commented on pull request #91: Update Dockerfile

2020-04-25 Thread GitBox
tteofili commented on pull request #91: URL: https://github.com/apache/joshua/pull/91#issuecomment-619388075 thanks @arfunk , and +1 if you have time to write a full fledged tutorial that'd be great! This is an automated

[GitHub] [joshua] lewismc commented on pull request #91: Update Dockerfile

2020-04-24 Thread GitBox
lewismc commented on pull request #91: URL: https://github.com/apache/joshua/pull/91#issuecomment-619091267 +1 @arfunk I wonder if you could insert some content to the README to detail usage with Docker? @tteofili wdyt?

[GitHub] [joshua] arfunk commented on pull request #91: Update Dockerfile

2020-04-24 Thread GitBox
arfunk commented on pull request #91: URL: https://github.com/apache/joshua/pull/91#issuecomment-619102134 > +1 @arfunk > I wonder if you could insert some content to the README to detail usage with Docker? > @tteofili wdyt? So what kind of details? Documentation about