[jira] [Commented] (KAFKA-797) Cannot start Kafka 0.8 per Quick Start instructions

2013-03-13 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601162#comment-13601162 ] David Arthur commented on KAFKA-797: I have to run ./sbt update in order for

[jira] [Commented] (KAFKA-686) 0.8 Kafka broker should give a better error message when running against 0.7 zookeeper

2013-03-13 Thread Phil Hargett (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601188#comment-13601188 ] Phil Hargett commented on KAFKA-686: While, yes, the original issue is unaddressed,

[jira] [Commented] (KAFKA-520) ConsumerIterator implemented by KafkaStream doesn't follow Java practices

2013-03-13 Thread David Arthur (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601190#comment-13601190 ] David Arthur commented on KAFKA-520: This has bitten me as well. Under the covers

[jira] [Commented] (KAFKA-797) Cannot start Kafka 0.8 per Quick Start instructions

2013-03-13 Thread Phil Hargett (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601197#comment-13601197 ] Phil Hargett commented on KAFKA-797: Same issue here. I cloned the repo and did a

[jira] [Commented] (KAFKA-801) Fix MessagesInPerSec mbean to count uncompressed message rate

2013-03-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601252#comment-13601252 ] Neha Narkhede commented on KAFKA-801: - +1. Minor simplification - Can we do the

[jira] [Commented] (KAFKA-763) Add an option to replica from the largest offset during unclean leader election

2013-03-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601278#comment-13601278 ] Neha Narkhede commented on KAFKA-763: - Sorry for coming late to the review. Two

[jira] [Commented] (KAFKA-801) Fix MessagesInPerSec mbean to count uncompressed message rate

2013-03-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601295#comment-13601295 ] Neha Narkhede commented on KAFKA-801: - Agree, I guess we can pass on that suggestion

[jira] [Updated] (KAFKA-802) Flush message interval is based on compressed message count

2013-03-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-802: Attachment: kafka-802.patch Two changes - 1. Changed the maybeFlush() call from Log.append() to

[jira] [Updated] (KAFKA-802) Flush message interval is based on compressed message count

2013-03-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-802: Status: Patch Available (was: Open) Flush message interval is based on compressed message

[jira] [Assigned] (KAFKA-802) Flush message interval is based on compressed message count

2013-03-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede reassigned KAFKA-802: --- Assignee: Neha Narkhede Flush message interval is based on compressed message count

[jira] [Commented] (KAFKA-763) Add an option to replica from the largest offset during unclean leader election

2013-03-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601364#comment-13601364 ] Jun Rao commented on KAFKA-763: --- For 1, I think the logic in the patch is correct, but

[jira] [Commented] (KAFKA-763) Add an option to replica from the largest offset during unclean leader election

2013-03-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601372#comment-13601372 ] Neha Narkhede commented on KAFKA-763: - Yes, that method should only take replicaId.

[jira] [Closed] (KAFKA-801) Fix MessagesInPerSec mbean to count uncompressed message rate

2013-03-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-801. --- Fix MessagesInPerSec mbean to count uncompressed message rate

[jira] [Commented] (KAFKA-802) Flush message interval is based on compressed message count

2013-03-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601393#comment-13601393 ] Jun Rao commented on KAFKA-802: --- Sriram, agreed that it's better if the meaning for flush

[jira] [Comment Edited] (KAFKA-802) Flush message interval is based on compressed message count

2013-03-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601393#comment-13601393 ] Jun Rao edited comment on KAFKA-802 at 3/13/13 5:28 PM: Sriram,

[jira] [Commented] (KAFKA-802) Flush message interval is based on compressed message count

2013-03-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601421#comment-13601421 ] Jun Rao commented on KAFKA-802: --- Thanks for patch v2. We need a few tweaks. 20. The

[jira] [Updated] (KAFKA-802) Flush message interval is based on compressed message count

2013-03-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-802: Attachment: kafka-802-v3.patch Flush message interval is based on compressed message count

[jira] [Commented] (KAFKA-797) Cannot start Kafka 0.8 per Quick Start instructions

2013-03-13 Thread Dragos Manolescu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601453#comment-13601453 ] Dragos Manolescu commented on KAFKA-797: I second David's and Phil's observations,

[jira] [Commented] (KAFKA-797) Cannot start Kafka 0.8 per Quick Start instructions

2013-03-13 Thread Bob (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601458#comment-13601458 ] Bob commented on KAFKA-797: --- Phil, yep, it's the same issue. I filed a separate bug on it

[jira] [Commented] (KAFKA-802) Flush message interval is based on compressed message count

2013-03-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601475#comment-13601475 ] Jun Rao commented on KAFKA-802: --- Thanks for patch v3. +1. Flush message

[jira] [Commented] (KAFKA-763) Add an option to replica from the largest offset during unclean leader election

2013-03-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601588#comment-13601588 ] Jun Rao commented on KAFKA-763: --- Thanks for patch v3. Looks good. However, I overlooked one

[jira] [Updated] (KAFKA-791) Fix validation bugs in System Test

2013-03-13 Thread John Fung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Fung updated KAFKA-791: Attachment: kafka-791-v2.patch Fix validation bugs in System Test --

[jira] [Commented] (KAFKA-791) Fix validation bugs in System Test

2013-03-13 Thread John Fung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601600#comment-13601600 ] John Fung commented on KAFKA-791: - Attached kafka-791-v2.patch with additional changes:

[jira] [Updated] (KAFKA-791) Fix validation bugs in System Test

2013-03-13 Thread John Fung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Fung updated KAFKA-791: Attachment: (was: kafka-791-v2.patch) Fix validation bugs in System Test

[jira] [Updated] (KAFKA-791) Fix validation bugs in System Test

2013-03-13 Thread John Fung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Fung updated KAFKA-791: Attachment: kafka-791-v2.patch Fix validation bugs in System Test --

[jira] [Commented] (KAFKA-763) Add an option to replica from the largest offset during unclean leader election

2013-03-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13601729#comment-13601729 ] Jun Rao commented on KAFKA-763: --- Thanks for patch v4. Committed to 0.8. Add

[jira] [Updated] (KAFKA-804) Incorrect index in the log of a follower

2013-03-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-804: -- Status: Patch Available (was: In Progress) Attach a patch. It always uses the nextOffset before append as the

[jira] [Created] (KAFKA-806) Index may not always observe log.index.interval.bytes

2013-03-13 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-806: - Summary: Index may not always observe log.index.interval.bytes Key: KAFKA-806 URL: https://issues.apache.org/jira/browse/KAFKA-806 Project: Kafka Issue Type: Improvement

[jira] [Commented] (KAFKA-804) Incorrect index in the log of a follower

2013-03-13 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13602034#comment-13602034 ] Neha Narkhede commented on KAFKA-804: - +1 Incorrect index in the log