Build failed in Jenkins: Kafka-trunk #239

2014-08-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/239/changes Changes: [junrao] kafka-1571; MetadataTest hangs; patched by Jun Rao; reviewed by Guozhang Wang [junrao] trivial change to remove a compilation warning; patched by Jun Rao -- [...truncated 453

Re: Review Request 23895: Patch for KAFKA-1419

2014-08-05 Thread Ivan Lyutov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/ --- (Updated Aug. 5, 2014, 12:52 p.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1419) cross build for scala 2.11

2014-08-05 Thread Ivan Lyutov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Lyutov updated KAFKA-1419: --- Attachment: KAFKA-1419_2014-08-05_12:51:16.patch cross build for scala 2.11

[jira] [Commented] (KAFKA-1419) cross build for scala 2.11

2014-08-05 Thread Ivan Lyutov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086215#comment-14086215 ] Ivan Lyutov commented on KAFKA-1419: Updated reviewboard

[jira] [Commented] (KAFKA-1419) cross build for scala 2.11

2014-08-05 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086309#comment-14086309 ] Joe Stein commented on KAFKA-1419: -- [~junrao] Is 2.9.2 going to still be the version we

[jira] [Commented] (KAFKA-1070) Auto-assign node id

2014-08-05 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086320#comment-14086320 ] Sriharsha Chintalapani commented on KAFKA-1070: --- [~charmalloc] Thanks for

Re: Review Request 23895: Patch for KAFKA-1419

2014-08-05 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23895/#review49601 --- build.gradle https://reviews.apache.org/r/23895/#comment86832

Re: Review Request 23895: Patch for KAFKA-1419

2014-08-05 Thread Jun Rao
On Aug. 5, 2014, 2:24 p.m., Joe Stein wrote: gradle.properties, line 18 https://reviews.apache.org/r/23895/diff/5/?file=652031#file652031line18 I think this should be 2.9.2 but confirming with Jun that is what we are going to be recommending when 0.8.2 releases. Joe, I agree

[jira] [Commented] (KAFKA-1070) Auto-assign node id

2014-08-05 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086353#comment-14086353 ] Joe Stein commented on KAFKA-1070: -- [~harshars] I understand. What I am struggling with

[jira] [Comment Edited] (KAFKA-1070) Auto-assign node id

2014-08-05 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086353#comment-14086353 ] Joe Stein edited comment on KAFKA-1070 at 8/5/14 3:35 PM: --

[jira] [Commented] (KAFKA-1387) Kafka getting stuck creating ephemeral node it has already created when two zookeeper sessions are established in a very short period of time

2014-08-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086398#comment-14086398 ] Jun Rao commented on KAFKA-1387: Joe, The issue that you described is probably fixed in

Re: Review Request 23906: Patch for KAFKA-1527

2014-08-05 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23906/#review49374 --- core/src/main/scala/kafka/consumer/ConsumerConfig.scala

[jira] [Created] (KAFKA-1572) Add Kafka StatsD metric reporter

2014-08-05 Thread Jianwen Wang (JIRA)
Jianwen Wang created KAFKA-1572: --- Summary: Add Kafka StatsD metric reporter Key: KAFKA-1572 URL: https://issues.apache.org/jira/browse/KAFKA-1572 Project: Kafka Issue Type: New Feature

[jira] [Updated] (KAFKA-1485) Upgrade to Zookeeper 3.4.x

2014-08-05 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1485: Attachment: KAFKA-1485.patch Attaching patch. Upgrade to Zookeeper 3.4.x

[jira] [Updated] (KAFKA-1485) Upgrade to Zookeeper 3.4.x

2014-08-05 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1485: Assignee: Gwen Shapira Status: Patch Available (was: Open) Upgrade to Zookeeper 3.4.x

Re: Newer Zookeeper?

2014-08-05 Thread Gwen Shapira
Our current version, 3.3.4 is from 2011. There have been lots of improvements since. Things I'm mostly interested in: 1. Since both Hadoop distributions (CDH + HDP) ship with ZK 3.4.5 (and have been for over two years), there are huge number of installations running Kafka with 3.4.X ZK. 3.3.X

Re: Newer Zookeeper?

2014-08-05 Thread Gwen Shapira
Added a patch. On Mon, Aug 4, 2014 at 7:25 PM, Joe Stein joe.st...@stealth.ly wrote: I found an already open ticket in regards to this https://issues.apache.org/jira/browse/KAFKA-1485 It also references a conflict with storm upgrading and testing and some other conflicts too.

[jira] [Commented] (KAFKA-1485) Upgrade to Zookeeper 3.4.x

2014-08-05 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086549#comment-14086549 ] Joe Stein commented on KAFKA-1485: -- [~gwenshap] why would we go with 3.4.5 and not 3.4.6

[jira] [Updated] (KAFKA-1485) Upgrade to Zookeeper 3.4.x

2014-08-05 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1485: Attachment: KAFKA-1485.2.patch Patch with ZK 3.4.6 version Upgrade to Zookeeper 3.4.x

[jira] [Commented] (KAFKA-1572) Add Kafka StatsD metric reporter

2014-08-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086724#comment-14086724 ] Guozhang Wang commented on KAFKA-1572: -- Hi Jianwen, After Kafka 0.9 we will be

[jira] [Commented] (KAFKA-1485) Upgrade to Zookeeper 3.4.x

2014-08-05 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086720#comment-14086720 ] Gwen Shapira commented on KAFKA-1485: - 3.4.5 was a mistake - I uploaded the patch

Review Request 24340: Patch for KAFKA-1565

2014-08-05 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24340/ --- Review request for kafka. Bugs: KAFKA-1565

[jira] [Commented] (KAFKA-1565) Transaction manager failover handling

2014-08-05 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086733#comment-14086733 ] Dong Lin commented on KAFKA-1565: - Created reviewboard

[jira] [Updated] (KAFKA-1565) Transaction manager failover handling

2014-08-05 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1565: Attachment: KAFKA-1565.patch Transaction manager failover handling -

[jira] [Commented] (KAFKA-1572) Add Kafka StatsD metric reporter

2014-08-05 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086743#comment-14086743 ] Joe Stein commented on KAFKA-1572: -- [~jackiewang518] you don't need to open a ticket for

[jira] [Commented] (KAFKA-1572) Add Kafka StatsD metric reporter

2014-08-05 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086748#comment-14086748 ] Joe Stein commented on KAFKA-1572: -- [~jackiewang518] I updated the page, i actually had

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-08-05 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086750#comment-14086750 ] Gwen Shapira commented on KAFKA-1555: - Did we agree on implementing min.isr.size as

[jira] [Created] (KAFKA-1573) Transient test failures on LogTest.testCorruptLog

2014-08-05 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1573: Summary: Transient test failures on LogTest.testCorruptLog Key: KAFKA-1573 URL: https://issues.apache.org/jira/browse/KAFKA-1573 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-1573) Transient test failures on LogTest.testCorruptLog

2014-08-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1573: - Description: Here is an example of the test failure trace:

Re: Review Request 24340: Patch for KAFKA-1565

2014-08-05 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24340/ --- (Updated Aug. 5, 2014, 9:49 p.m.) Review request for kafka. Bugs: KAFKA-1565

Re: Review Request 24340: Patch for KAFKA-1565

2014-08-05 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24340/ --- (Updated Aug. 5, 2014, 9:51 p.m.) Review request for kafka. Bugs: KAFKA-1565

[jira] [Resolved] (KAFKA-1550) Patch review tool should use git format-patch to generate patch

2014-08-05 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-1550. --- Resolution: Fixed Committed to trunk. Patch review tool should use git format-patch to generate

Re: Review Request 24340: Patch for KAFKA-1565

2014-08-05 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24340/ --- (Updated Aug. 5, 2014, 9:56 p.m.) Review request for kafka. Bugs: KAFKA-1565

[jira] [Updated] (KAFKA-1430) Purgatory redesign

2014-08-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1430: - Attachment: KAFKA-1430_2014-08-05_14:54:21.patch Purgatory redesign --

[jira] [Commented] (KAFKA-1430) Purgatory redesign

2014-08-05 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086855#comment-14086855 ] Guozhang Wang commented on KAFKA-1430: -- Updated reviewboard

[jira] [Updated] (KAFKA-1485) Upgrade to Zookeeper 3.4.6

2014-08-05 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1485: - Summary: Upgrade to Zookeeper 3.4.6 (was: Upgrade to Zookeeper 3.4.x) Upgrade to Zookeeper 3.4.6

[jira] [Updated] (KAFKA-1485) Upgrade to Zookeeper 3.4.6

2014-08-05 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1485: - Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch Gwen! tests

[jira] [Commented] (KAFKA-1070) Auto-assign node id

2014-08-05 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086980#comment-14086980 ] Sriharsha Chintalapani commented on KAFKA-1070: --- [~jkreps] [~junrao]

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-08-05 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086984#comment-14086984 ] Jay Kreps commented on KAFKA-1555: -- Hey [~gwenshap], to answer your question, the

Build failed in Jenkins: Kafka-trunk #240

2014-08-05 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/240/changes Changes: [jjkoshy] KAFKA-1550; Patch review tool should use git format-patch for patch generation; reviewed by Guozhang Wang and Joel Koshy [vagrant] KAFKA-1485 Upgrade to Zookeeper 3.4.6 patch by Gwen Shapira reviewed by Joe Stein

[jira] [Comment Edited] (KAFKA-1387) Kafka getting stuck creating ephemeral node it has already created when two zookeeper sessions are established in a very short period of time

2014-08-05 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087063#comment-14087063 ] Joe Stein edited comment on KAFKA-1387 at 8/6/14 1:09 AM: --

[jira] [Commented] (KAFKA-1387) Kafka getting stuck creating ephemeral node it has already created when two zookeeper sessions are established in a very short period of time

2014-08-05 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087063#comment-14087063 ] Joe Stein commented on KAFKA-1387: -- [~junrao] I tested on trunk and it is much worse now.

[jira] [Comment Edited] (KAFKA-1387) Kafka getting stuck creating ephemeral node it has already created when two zookeeper sessions are established in a very short period of time

2014-08-05 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087063#comment-14087063 ] Joe Stein edited comment on KAFKA-1387 at 8/6/14 1:11 AM: --

[jira] [Comment Edited] (KAFKA-1387) Kafka getting stuck creating ephemeral node it has already created when two zookeeper sessions are established in a very short period of time

2014-08-05 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087063#comment-14087063 ] Joe Stein edited comment on KAFKA-1387 at 8/6/14 1:15 AM: --

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-05 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568/ --- (Updated Aug. 6, 2014, 4:25 a.m.) Review request for kafka. Bugs: KAFKA-1523

[jira] [Updated] (KAFKA-1523) Implement transaction manager module

2014-08-05 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1523: Attachment: KAFKA-1523_2014-08-05_21:25:55.patch Implement transaction manager module

[jira] [Commented] (KAFKA-1523) Implement transaction manager module

2014-08-05 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087228#comment-14087228 ] Dong Lin commented on KAFKA-1523: - Updated reviewboard

Re: Review Request 23567: Patch for KAFKA-1522

2014-08-05 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated Aug. 6, 2014, 4:28 a.m.) Review request for kafka. Bugs: KAFKA-1522

Re: Review Request 24214: Patch for KAFKA-1374

2014-08-05 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24214/#review49611 --- Thanks for the patch. Some comments below.

[jira] [Resolved] (KAFKA-1430) Purgatory redesign

2014-08-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1430. Resolution: Fixed Fix Version/s: 0.8.2 Thanks for the patch. +1 and committed to trunk. Great

[jira] [Updated] (KAFKA-1522) Transactional messaging request/response definitions

2014-08-05 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1522: Attachment: KAFKA-1522_2014-08-05_21:28:20.patch Transactional messaging request/response definitions

[jira] [Commented] (KAFKA-1522) Transactional messaging request/response definitions

2014-08-05 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087233#comment-14087233 ] Dong Lin commented on KAFKA-1522: - Updated reviewboard

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-05 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568/#review49692 --- core/src/main/scala/kafka/admin/TopicCommand.scala

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-08-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087243#comment-14087243 ] Jun Rao commented on KAFKA-1555: Since we can't always guarantee a message doesn't get

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-05 Thread Dong Lin
On Aug. 6, 2014, 4:39 a.m., Timothy Chen wrote: core/src/main/scala/kafka/server/TransactionManager.scala, line 300 https://reviews.apache.org/r/23568/diff/6/?file=653418#file653418line300 If the batch size changes to a smaller number does the tx Id range overlap then? Why? The

Re: Review Request 23568: Patch for KAFKA-1523

2014-08-05 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568/#review49696 --- core/src/main/scala/kafka/server/TransactionManager.scala

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-08-05 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087278#comment-14087278 ] Joe Stein commented on KAFKA-1555: -- So when we say property, are we saying a property in