Re: [DISCUSS] KIP-347: Enable batching in FindCoordinatorRequest

2018-08-10 Thread Yishun Guan
It would be great if I could get some feedbacks on this KIP, thanks! On Thu, Aug 9, 2018, 10:35 AM Yishun Guan wrote: > To add more context for KIP-347: https://github.com/apache/kafka/pull/5353 > > On Wed, Aug 8, 2018 at 3:55 PM Yishun Guan wrote: > >> Hi all, >> >> I would like to start a

[jira] [Resolved] (KAFKA-6966) Extend `TopologyDescription.Sink` to return `TopicNameExtractor`

2018-08-10 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-6966. Resolution: Fixed > Extend `TopologyDescription.Sink` to return `TopicNameExtractor` >

Re: [DISCUSS] KIP-342 Add Customizable SASL extensions to OAuthBearer authentication

2018-08-10 Thread Rajini Sivaram
Hi Stanislav, For the point that Ron made above for: public OAuthBearerExtensionsValidatorCallback(OAuthBearerToken token, SaslExtensions extensions) I don't think we should ever invoke extensions callback without the token. We can first validate the token and invoke extensions callback only

[jira] [Created] (KAFKA-7277) Migrate Streams API to Duration instead of longMs times

2018-08-10 Thread John Roesler (JIRA)
John Roesler created KAFKA-7277: --- Summary: Migrate Streams API to Duration instead of longMs times Key: KAFKA-7277 URL: https://issues.apache.org/jira/browse/KAFKA-7277 Project: Kafka Issue

Re: [EXTERNAL] [VOTE] KIP-310: Add a Kafka Source Connector to Kafka Connect

2018-08-10 Thread McCaig, Rhys
Thanks Stephane! If there is a desire for further discussion I am certainly open to reverting this to a discussion thread. For now I’ll keep this vote open until we get either 3 binding votes or further request for discussion from the community. Do you have any additional thoughts on the KIP

[jira] [Resolved] (KAFKA-7147) Allow kafka-reassign-partitions.sh and kafka-log-dirs.sh to take admin client property file

2018-08-10 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved KAFKA-7147. - Resolution: Fixed > Allow kafka-reassign-partitions.sh and kafka-log-dirs.sh to take admin client >

Re: [DISCUSS] KIP-347: Enable batching in FindCoordinatorRequest

2018-08-10 Thread Ted Yu
bq. this is the foundation of some later possible optimizations(enable batching in *describeConsumerGroups ...* *Can you say more why this change lays the foundation for the future optimizations ?* *You mentioned **FIND_COORDINATOR_REQUEST_V3 in the wiki but I don't see it in PR.* *I assume you

Re: [VOTE] KIP-280: Enhanced log compaction

2018-08-10 Thread Jason Gustafson
Hi Luis, It's still not very clear to me why we need the header-based strategy. Can you elaborate why having the timestamp-based approach alone is not sufficient? The use case in the motivation just describes a "most recent snapshot" use case. Thanks, Jason On Thu, Aug 9, 2018 at 4:36 AM, Luís

Re: [DISCUSS] KIP-342 Add Customizable SASL extensions to OAuthBearer authentication

2018-08-10 Thread Ron Dagostino
Hi Stanislav. Here are a few KIP comments. <

[jira] [Created] (KAFKA-7275) Prototype lock-free metrics

2018-08-10 Thread John Roesler (JIRA)
John Roesler created KAFKA-7275: --- Summary: Prototype lock-free metrics Key: KAFKA-7275 URL: https://issues.apache.org/jira/browse/KAFKA-7275 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-7276) Consider using re2j to speed up regex operations

2018-08-10 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-7276: - Summary: Consider using re2j to speed up regex operations Key: KAFKA-7276 URL: https://issues.apache.org/jira/browse/KAFKA-7276 Project: Kafka Issue Type: Task

Jenkins build is back to normal : kafka-trunk-jdk10 #393

2018-08-10 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-trunk-jdk10 #392

2018-08-10 Thread Apache Jenkins Server
See Changes: [lindong28] KAFKA-7147; ReassignPartitionsCommand should be able to connect to -- [...truncated 1.54 MB...] kafka.zk.KafkaZkClientTest >

Build failed in Jenkins: kafka-trunk-jdk8 #2884

2018-08-10 Thread Apache Jenkins Server
See Changes: [lindong28] KAFKA-7147; ReassignPartitionsCommand should be able to connect to -- [...truncated 877.49 KB...] kafka.zookeeper.ZooKeeperClientTest >

Build failed in Jenkins: kafka-trunk-jdk8 #2885

2018-08-10 Thread Apache Jenkins Server
See Changes: [mjsax] KAFKA-6966: Extend TopologyDescription to better represent Source and -- [...truncated 428.43 KB...] kafka.zookeeper.ZooKeeperClientTest >

[jira] [Resolved] (KAFKA-7140) Remove deprecated poll usages

2018-08-10 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-7140. Resolution: Fixed > Remove deprecated poll usages > - > >

Re: [DISCUSS] KIP-346 - Limit blast radius of log compaction failure

2018-08-10 Thread Stanislav Kozlovski
Hey Jason, My initial suggestion was to *track *the uncleanable disk space. I can see why marking a log directory as offline after a certain threshold of uncleanable disk space is more useful. I'm not sure if we can set that threshold to be of certain size (e.g 100GB) as log directories might

Re: [EXTERNAL] [VOTE] KIP-310: Add a Kafka Source Connector to Kafka Connect

2018-08-10 Thread Stephane Maarek
Hi Rhys, Overall I'm +1 (non binding), but you're going to need 3 binding votes for this KIP to pass. I don't feel there has been enough discussion on this from the community. Can we get some input from other people? Thanks for starting the vote nonetheless :) Stephane On 8 August 2018 at

[jira] [Resolved] (KAFKA-6701) synchronize Log modification between delete cleanup and async delete

2018-08-10 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved KAFKA-6701. - Resolution: Fixed The issue appears to have been fixed in

Re: [DISCUSS] KIP-317: Transparent Data Encryption

2018-08-10 Thread Sönke Liebau
Hi Viktor, thanks for your input! We could accommodate magic headers by removing any known fixed bytes pre-encryption, sticking them in a header field and prepending them after decryption. However, I am not sure whether this is actually necessary, as most modern (AES for sure) algorithms are

Re: [DISCUSS] KIP-342 Add Customizable SASL extensions to OAuthBearer authentication

2018-08-10 Thread Stanislav Kozlovski
Hi Rajini, Ron I've updated the KIP with the latest changes following our discussion. Please do give it a read. If you feel it is alright, I will follow up with a PR later. Best, Stanislav On Thu, Aug 9, 2018 at 10:09 AM Rajini Sivaram wrote: > Hi Ron/Stansilav, > > OK, let's just go with 2.