Re: [VOTE] KIP-519: Make SSL context/engine configuration extensible

2020-03-26 Thread Maulin Vasavada
FYI - we have updated the KIP documentation also with appropriate code samples for interfaces and few important changes. Thanks Maulin On Wed, Mar 25, 2020 at 10:21 AM Maulin Vasavada wrote: > bump > > On Wed, Mar 25, 2020 at 10:20 AM Maulin Vasavada < > maulin.vasav...@gmail.com> wrote: > >>

[jira] [Resolved] (KAFKA-9729) Shrink inWriteLock time in SimpleAuthorizer

2020-03-26 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-9729. -- Resolution: Fixed > Shrink inWriteLock time in SimpleAuthorizer >

Re: [VOTE] KIP-570: Add leader epoch in StopReplicaRequest

2020-03-26 Thread Jason Gustafson
I'm +1 for the change. I think the main advantage is that it simplifies the batching. More like the LeaderAndIsr/UpdateMetadata requests, the request grouping becomes less significant. I'm not sure how much of the benefit can be realized given the need to keep compatibility, but it still seems

[jira] [Created] (KAFKA-9769) ReplicaManager Partition.makeFollower Increases LeaderEpoch when ZooKeeper disconnect occurs

2020-03-26 Thread Andrew Choi (Jira)
Andrew Choi created KAFKA-9769: -- Summary: ReplicaManager Partition.makeFollower Increases LeaderEpoch when ZooKeeper disconnect occurs Key: KAFKA-9769 URL: https://issues.apache.org/jira/browse/KAFKA-9769

Build failed in Jenkins: kafka-2.2-jdk8 #37

2020-03-26 Thread Apache Jenkins Server
See Changes: [rajinisivaram] KAFKA-9752; New member timeout can leave group rebalance stuck (#8339) -- [...truncated 2.55 MB...] kafka.utils.CommandLineUtilsTest >

Build failed in Jenkins: kafka-trunk-jdk11 #1292

2020-03-26 Thread Apache Jenkins Server
See Changes: [github] MINOR: Don't process sasl.kerberos.principal.to.local.rules on [github] KAFKA-9760: Add KIP-447 protocol change to upgrade notes (#8350) [github] KAFKA-9688: kafka-topic.sh should show

Re: [VOTE] KIP-447: Producer scalability for exactly once semantics

2020-03-26 Thread Matthias J. Sax
One more change for KIP-447. Currently, Kafka Streams collects task-level metrics called "commit-latency-[max|avg]". However, with KIP-447 tasks don't get committed individually any longer, and thus this metrics do not make sense going forward. Therefore, we propose to remove those metrics in

Jenkins build is back to normal : kafka-trunk-jdk8 #4372

2020-03-26 Thread Apache Jenkins Server
See

[jira] [Created] (KAFKA-9770) Caching State Store does not Close Underlying State Store When Exception is Thrown During Flushing

2020-03-26 Thread Bruno Cadonna (Jira)
Bruno Cadonna created KAFKA-9770: Summary: Caching State Store does not Close Underlying State Store When Exception is Thrown During Flushing Key: KAFKA-9770 URL: https://issues.apache.org/jira/browse/KAFKA-9770

Jenkins build is back to normal : kafka-trunk-jdk11 #1293

2020-03-26 Thread Apache Jenkins Server
See

[jira] [Resolved] (KAFKA-9707) InsertField.Key transformation should apply to tombstone records

2020-03-26 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-9707. --- Resolution: Fixed This fix was merged in time so it will be available in

Jenkins build is back to normal : kafka-1.0-jdk8 #290

2020-03-26 Thread Apache Jenkins Server
See

Re: [VOTE] 2.5.0 RC2

2020-03-26 Thread Christopher Egerton
Hi all, I'd like to request that https://issues.apache.org/jira/browse/KAFKA-9771 be treated as a release blocker for 2.5. This is a regression caused by the recent bump in Jetty version that causes inter-worker communication to fail for Connect clusters that use SSL and a keystore that contains

Re: [VOTE] KIP-519: Make SSL context/engine configuration extensible

2020-03-26 Thread Rajini Sivaram
+1 (binding) Thanks for the KIP, Maulin! Regards, Rajini On Thu, Mar 26, 2020 at 4:14 PM Maulin Vasavada wrote: > FYI - we have updated the KIP documentation also with appropriate code > samples for interfaces and few important changes. > > Thanks > Maulin > > On Wed, Mar 25, 2020 at 10:21 AM

Re: [VOTE] KIP-519: Make SSL context/engine configuration extensible

2020-03-26 Thread Zhou, Thomas
+1 (non-binding) Regards, Thomas On 3/26/20, 12:36 PM, "Rajini Sivaram" wrote: +1 (binding) Thanks for the KIP, Maulin! Regards, Rajini On Thu, Mar 26, 2020 at 4:14 PM Maulin Vasavada wrote: > FYI - we have updated the KIP documentation also

[jira] [Resolved] (KAFKA-9760) Add EOS protocol changes to documentation

2020-03-26 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-9760. Fix Version/s: 2.6.0 Resolution: Fixed > Add EOS protocol changes to documentation

[jira] [Created] (KAFKA-9771) Inter-worker SSL is broken for keystores with multiple certificates

2020-03-26 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-9771: Summary: Inter-worker SSL is broken for keystores with multiple certificates Key: KAFKA-9771 URL: https://issues.apache.org/jira/browse/KAFKA-9771 Project: Kafka

Re: [DISCUSS] KIP-580: Exponential Backoff for Kafka Clients

2020-03-26 Thread Konstantine Karantasis
Thank you Sanjana. I checked the updates on the KIP and it looks good to me too now. I'll vote on the voting thread. Best, Konstantine On Wed, Mar 25, 2020 at 1:57 PM Sanjana Kaundinya wrote: > Hi Konstantine, > > Thanks for the insightful feedback. I’ll address it here as well as update >

Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients

2020-03-26 Thread Konstantine Karantasis
Thank you Sanjana! +1 (binding) from me too. Konstantine On Wed, Mar 25, 2020 at 1:57 PM Sanjana Kaundinya wrote: > Hi Konstantine, > > Thanks for the feedback, I have addressed it on the [DISCUSS] thread and > will update the KIP shortly. > > Thanks, > Sanjana > On Mar 25, 2020, 10:52 AM

Re: [VOTE] KIP-455: Create an Administrative API for Replica Reassignment

2020-03-26 Thread Colin McCabe
Good news-- we are finally getting support for this in kafka-reassign-partitions.sh in Kafka 2.6. I updated the KIP to state that the controller changes were made in 2.4 and the command line changes will appear in 2.6. Previously it just said that the KIP was implemented in 2.4. Just as a

Re: [DISCUSS] KIP-574: CLI Dynamic Configuration with file input

2020-03-26 Thread Colin McCabe
Hi Kamal, Are you suggesting that we not support STDIN here? I have mixed feelings. I think the ideal solution would be to support "-" in these tools whenever a file argument was expected. But that would be a bigger change than what we're talking about here. Maybe you are right and we

Re: [DISCUSS] KIP-574: CLI Dynamic Configuration with file input

2020-03-26 Thread Colin McCabe
I agree with this. I think we'd be better off without the --delete-config-file option. It just seems confusing. best, Colin On Wed, Mar 25, 2020, at 03:48, Rajini Sivaram wrote: > Hi Aneel, > > Thanks for the KIP. As configurations get more complex, the ability to > provide compound configs

Re: [DISCUSS] KIP-584: Versioning scheme for features

2020-03-26 Thread Colin McCabe
Thanks, Kowshik, this looks good. In the "Schema" section, do we really need both __schema_version__ and __data_version__? Can we just have a single version field here? Shouldn't the Admin(Client) function have some way to get the min and max information that we're exposing as well? I guess

Build failed in Jenkins: kafka-2.3-jdk8 #191

2020-03-26 Thread Apache Jenkins Server
See Changes: [konstantine] KAFKA-9707: Fix InsertField.Key should apply to keys of tombstone -- [...truncated 2.85 MB...] kafka.zk.KafkaZkClientTest > testClusterIdMethods

[jira] [Resolved] (KAFKA-9756) Refactor the main loop to process more than one record of one task at a time

2020-03-26 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-9756. -- Fix Version/s: 2.6.0 Resolution: Fixed > Refactor the main loop to process more than

[jira] [Created] (KAFKA-9772) Transactional offset commit fails with IllegalStateException

2020-03-26 Thread Dhruvil Shah (Jira)
Dhruvil Shah created KAFKA-9772: --- Summary: Transactional offset commit fails with IllegalStateException Key: KAFKA-9772 URL: https://issues.apache.org/jira/browse/KAFKA-9772 Project: Kafka

Build failed in Jenkins: kafka-2.5-jdk8 #79

2020-03-26 Thread Apache Jenkins Server
See Changes: [konstantine] KAFKA-9707: Fix InsertField.Key should apply to keys of tombstone -- [...truncated 2.90 MB...] org.apache.kafka.streams.test.OutputVerifierTest >

Build failed in Jenkins: kafka-2.2-jdk8 #38

2020-03-26 Thread Apache Jenkins Server
See Changes: [konstantine] KAFKA-9707: Fix InsertField.Key should apply to keys of tombstone -- [...truncated 2.55 MB...] kafka.log.LogConfigTest >

Build failed in Jenkins: kafka-2.1-jdk8 #259

2020-03-26 Thread Apache Jenkins Server
See Changes: [konstantine] KAFKA-9707: Fix InsertField.Key should apply to keys of tombstone -- [...truncated 923.69 KB...] kafka.log.BrokerCompressionTest >

Re: [DISCUSS] KIP-584: Versioning scheme for features

2020-03-26 Thread Kowshik Prakasam
Hi Colin, Thanks for the feedback! I've changed the KIP to address your suggestions. Please find below my explanation. Here is a link to KIP 584: https://cwiki.apache.org/confluence/display/KAFKA/KIP-584%3A+Versioning+scheme+for+features . 1. '__data_version__' is the version of the finalized

Build failed in Jenkins: kafka-trunk-jdk8 #4373

2020-03-26 Thread Apache Jenkins Server
See Changes: [github] KAFKA-9688: kafka-topic.sh should show KIP-455 adding and removing [manikumar] KAFKA-9729: avoid readLock in authorizer ACL lookups [github] Minor: Don't swallow errors when altering log

Build failed in Jenkins: kafka-trunk-jdk11 #1294

2020-03-26 Thread Apache Jenkins Server
See Changes: [github] KAFKA-8470: State change logs should not be in TRACE level (#8320) -- [...truncated 5.98 MB...] org.apache.kafka.streams.test.OutputVerifierTest >

[jira] [Resolved] (KAFKA-8470) State change logs should not be in TRACE level

2020-03-26 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-8470. Fix Version/s: 2.6.0 Resolution: Fixed Merged the PR to trunk.     1. Defaults state-change log

Build failed in Jenkins: kafka-trunk-jdk11 #1289

2020-03-26 Thread Apache Jenkins Server
See Changes: [github] DOCS-3625: Add section to config topic: parameters controlled by Kafka -- [...truncated 4.85 MB...] kafka.api.PlaintextAdminIntegrationTest >

Build failed in Jenkins: kafka-2.2-jdk8 #36

2020-03-26 Thread Apache Jenkins Server
See Changes: [konstantine] MINOR: Backport kafkatest per-broker overrides and extra JVM args -- [...truncated 2.68 MB...] kafka.api.AuthorizerIntegrationTest >

Build failed in Jenkins: kafka-trunk-jdk8 #4370

2020-03-26 Thread Apache Jenkins Server
See Changes: [github] MINOR: Add synchronization to the protocol name check (#8349) [github] MINOR: Improve performance of checkpointHighWatermarks, patch 1/2 --

Jenkins build is back to normal : kafka-2.1-jdk8 #258

2020-03-26 Thread Apache Jenkins Server
See

Build failed in Jenkins: kafka-trunk-jdk8 #4369

2020-03-26 Thread Apache Jenkins Server
See Changes: [github] MINOR: Allow topics with `null` leader on MockAdminClient createTopic. -- [...truncated 5.95 MB...]

Build failed in Jenkins: kafka-trunk-jdk11 #1290

2020-03-26 Thread Apache Jenkins Server
See Changes: [github] MINOR: Allow topics with `null` leader on MockAdminClient createTopic. [github] MINOR: Add synchronization to the protocol name check (#8349) [github] MINOR: Improve performance of

[jira] [Resolved] (KAFKA-9373) Improve shutdown performance via lazy accessing the offset and time indices.

2020-03-26 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-9373. Fix Version/s: 2.6.0 Resolution: Fixed > Improve shutdown performance via lazy accessing

Build failed in Jenkins: kafka-trunk-jdk8 #4371

2020-03-26 Thread Apache Jenkins Server
See Changes: [github] KAFKA-9373: Reduce shutdown time by avoiding unnecessary loading of [github] MINOR: Fix a number of warnings in mirror/mirror-client (#8074) --

Re: [DISCUSS] KIP-574: CLI Dynamic Configuration with file input

2020-03-26 Thread Kamal Chandraprakash
Hi Colin, We should not support STDIN to maintain uniformity across scripts. If the user wants to pass the arguments in command line, they can always use the existing --add-config option. On Thu, Mar 26, 2020 at 7:20 PM David Jacot wrote: > Rajini has made a good point. I don't feel strong

Re: [VOTE] KIP-570: Add leader epoch in StopReplicaRequest

2020-03-26 Thread David Jacot
I shouldn't have said "always", sorry. When a replica is deleted, either due to a topic deletion or a reassignment, the controller transitions the replica to the `OfflineReplica` state and then to the `ReplicaDeletionStarted` state. The first transition issues a StopReplicaRequest with

Re: [DISCUSS] KIP-574: CLI Dynamic Configuration with file input

2020-03-26 Thread David Jacot
Rajini has made a good point. I don't feel strong for either ways but if people are confused by this, it is probably better without it. Best, David On Thu, Mar 26, 2020 at 7:23 AM Colin McCabe wrote: > Hi Kamal, > > Are you suggesting that we not support STDIN here? I have mixed feelings. > >

Build failed in Jenkins: kafka-trunk-jdk11 #1291

2020-03-26 Thread Apache Jenkins Server
See Changes: [github] KAFKA-9373: Reduce shutdown time by avoiding unnecessary loading of [github] MINOR: Fix a number of warnings in mirror/mirror-client (#8074) --

Re: [DISCUSS] KIP-574: CLI Dynamic Configuration with file input

2020-03-26 Thread Aneel Nazareth
Hi Kamal, Thanks for taking a look at this KIP. Unfortunately the user actually can't pass the arguments on the command line using the existing --add-config option if the values are complex structures that contain commas. --add-config assumes that commas separate distinct configuration

Re: [DISCUSS] KIP-574: CLI Dynamic Configuration with file input

2020-03-26 Thread Aneel Nazareth
Hi Rajini, Thanks for taking a look at this. It seems like the consensus is to remove the --delete-config-file option, so I'll do so. On Wed, Mar 25, 2020 at 5:48 AM Rajini Sivaram wrote: > > Hi Aneel, > > Thanks for the KIP. As configurations get more complex, the ability to > provide compound