Re: [DISCUSS] KIP-406: GlobalStreamThread should honor custom reset policy

2020-10-05 Thread Sophie Blee-Goldman
It seems a little misleading, but I actually have no real qualms about transitioning to the REBALANCING state *after* RESTORING. One of the side effects of KIP-429 was that in most cases we actually don't transition to REBALANCING at all until the very end of the rebalance, so REBALANCING doesn't

[jira] [Created] (KAFKA-10575) StateRestoreListener#onRestoreEnd should always be triggered

2020-10-05 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-10575: - Summary: StateRestoreListener#onRestoreEnd should always be triggered Key: KAFKA-10575 URL: https://issues.apache.org/jira/browse/KAFKA-10575 Project: Kafka

Re: [VOTE] KIP-614: Add Prefix Scan support for State Stores

2020-10-05 Thread Sagar
Thanks Guozhang, For the PR review, the PR is already there in the KIP. I am adding it here: https://github.com/confluentinc/kafka/pull/242 It's not complete by any means but maybe one pass would be possible? Thanks! Sagar. On Mon, Oct 5, 2020 at 10:26 PM Guozhang Wang wrote: > Hey Sagar,

Build failed in Jenkins: Kafka » kafka-trunk-jdk8 #110

2020-10-05 Thread Apache Jenkins Server
See Changes: [github] KAFKA-10531: Check for negative values to Thread.sleep call (#9347) -- [...truncated 3.33 MB...]

Build failed in Jenkins: Kafka » kafka-trunk-jdk11 #112

2020-10-05 Thread Apache Jenkins Server
See Changes: [github] KAFKA-10531: Check for negative values to Thread.sleep call (#9347) -- [...truncated 3.35 MB...]

Re: [DISCUSS] KIP-598: Augment TopologyDescription with store and source / sink serde information

2020-10-05 Thread Guozhang Wang
That's a good idea, I think StoreBuilder#metricsScope() is not a very intrusive API to add. But note that the metricsScope() is not identical to KIP-591's store type enum, e.g. the former's possible values include "rocksdb-session" and "rocksdb-window". Guozhang On Mon, Oct 5, 2020 at 2:21 PM

Re: [DISCUSS] KIP-598: Augment TopologyDescription with store and source / sink serde information

2020-10-05 Thread Sophie Blee-Goldman
Agreed, I was proposing those as two possible options we can consider. If we add the store type enum first, then we could leverage that for this; if not, (which seems most likely), then we should just use the metricsScope which should be just as good (although not identical) We can always revisit

Build failed in Jenkins: Kafka » kafka-2.3-jdk8 #6

2020-10-05 Thread Apache Jenkins Server
See Changes: [John Roesler] MINOR: remove stream simple benchmark suite (#8353) -- [...truncated 1.71 MB...] kafka.zookeeper.ZooKeeperClientTest >

Jenkins build is back to normal : Kafka » kafka-2.6-jdk8 #25

2020-10-05 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-660: Pluggable ReplicaAssignor

2020-10-05 Thread Efe Gencer
Hi Mickael, Thanks for the KIP! A call to an external system, e.g. Cruise Control, in the implementation of the provided interface can indeed help with the initial assignment of partitions. I am curious why the proposed `ReplicaAssignor#assignReplicasToBrokers` receives a list of partition ids

Build failed in Jenkins: Kafka » kafka-trunk-jdk8 #113

2020-10-05 Thread Apache Jenkins Server
See Changes: [github] MINOR: Move `RaftRequestHandler` to `tools` package (#9377) [github] KAFKA-10439: Connect's Values to parse BigInteger as Decimal with zero scale. (#9320)

Re: [DISCUSS] Apache Kafka 2.7.0 release

2020-10-05 Thread Bill Bejeck
Hi John, I've updated the list of expected KIPs for 2.7.0 with KIP-478. Thanks, Bill On Mon, Oct 5, 2020 at 11:26 AM John Roesler wrote: > Hi Bill, > > Sorry about this, but I've just noticed that KIP-478 is > missing from the list. The url is: > >

Build failed in Jenkins: Kafka » kafka-2.2-jdk8 #4

2020-10-05 Thread Apache Jenkins Server
See Changes: [Konstantine Karantasis] KAFKA-10439: Connect's Values to parse BigInteger as Decimal with zero scale. (#9320) -- [...truncated 2.07 MB...]

Re: [DISCUSS] KIP-598: Augment TopologyDescription with store and source / sink serde information

2020-10-05 Thread Sophie Blee-Goldman
I suppose we could add a method to the StoreBuilder interface that calls through to the metricsScope() method of the StoreSupplier, similar to what we do for the store name. It feels a bit indirect but the metricsScope() should be an accurate description of the underlying store type. The whole

Build failed in Jenkins: Kafka » kafka-trunk-jdk11 #114

2020-10-05 Thread Apache Jenkins Server
See Changes: [github] MINOR: Update doc for raft state metrics (#9342) -- [...truncated 3.35 MB...] org.apache.kafka.streams.TopologyTestDriverTest >

Re: [VOTE] KIP-630: Kafka Raft Snapshot

2020-10-05 Thread Jun Rao
Hi, Jose, Thanks for the KIP. +1. A couple of minor comments below. 1. The new configuration names suggested by Ron sound reasonable. 2. It seems that OFFSET_OUT_OF_RANGE in the wiki needs to be changed to POSITION_OUT_OF_RANGE. Jun On Mon, Oct 5, 2020 at 9:46 AM Jason Gustafson wrote: > +1

Re: [VOTE] KIP-673: Emit JSONs with new auto-generated schema

2020-10-05 Thread Jason Gustafson
+1 Thanks for the KIP! On Fri, Oct 2, 2020 at 4:37 PM Colin McCabe wrote: > Thanks, Anastasia! This will be a lot easier to maintain. > > +1 (binding) > > best, > Colin > > On Wed, Sep 30, 2020, at 23:57, David Jacot wrote: > > Thanks for the KIP, Anastasia. > > > > +1 (non-binding) > > > > On

Build failed in Jenkins: Kafka » kafka-trunk-jdk15 #144

2020-10-05 Thread Apache Jenkins Server
See Changes: [github] KAFKA-10531: Check for negative values to Thread.sleep call (#9347) -- [...truncated 6.71 MB...]

Build failed in Jenkins: Kafka » kafka-2.5-jdk8 #13

2020-10-05 Thread Apache Jenkins Server
See Changes: [Randall Hauch] KAFKA-10531: Check for negative values to Thread.sleep call (#9347) [John Roesler] MINOR: remove stream simple benchmark suite (#8353)

Build failed in Jenkins: Kafka » kafka-2.4-jdk8 #10

2020-10-05 Thread Apache Jenkins Server
See Changes: [John Roesler] MINOR: remove stream simple benchmark suite (#8353) -- [...truncated 2.90 MB...]

[jira] [Resolved] (KAFKA-10439) Connect's Values class loses precision for integers, larger than 64 bits

2020-10-05 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-10439. Resolution: Fixed Merged and back ported to the branches listed under

Build failed in Jenkins: Kafka » kafka-trunk-jdk11 #113

2020-10-05 Thread Apache Jenkins Server
See Changes: [github] MINOR: Add proper checks to KafkaConsumer.groupMetadata (#9349) -- [...truncated 3.35 MB...]

Build failed in Jenkins: Kafka » kafka-trunk-jdk8 #111

2020-10-05 Thread Apache Jenkins Server
See Changes: [github] MINOR: Add proper checks to KafkaConsumer.groupMetadata (#9349) -- [...truncated 3.33 MB...]

Build failed in Jenkins: Kafka » kafka-trunk-jdk8 #112

2020-10-05 Thread Apache Jenkins Server
See Changes: [github] MINOR: Update doc for raft state metrics (#9342) -- [...truncated 3.33 MB...] org.apache.kafka.streams.TopologyTestDriverTest >

Build failed in Jenkins: Kafka » kafka-trunk-jdk15 #145

2020-10-05 Thread Apache Jenkins Server
See Changes: [github] MINOR: Add proper checks to KafkaConsumer.groupMetadata (#9349) [github] MINOR: Update doc for raft state metrics (#9342) --

Re: Create KIP permission

2020-10-05 Thread Jun Rao
Hi, Javier, Thanks for your interest. Just gave you the wiki permission. Jun On Sat, Oct 3, 2020 at 8:59 AM Javier Freire Riobo wrote: > Hi, > > My UID is javier.freire. I wanted to create a KIP to add to Kafka Streams > the ability to convert a changelog stream to a stream by computing the >

[jira] [Resolved] (KAFKA-9585) Flaky Test: LagFetchIntegrationTest#shouldFetchLagsDuringRebalancingWithOptimization

2020-10-05 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-9585. -- Resolution: Cannot Reproduce > Flaky Test: >

[jira] [Created] (KAFKA-10574) Infinite loop in SimpleHeaderConverter and Values classes

2020-10-05 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-10574: - Summary: Infinite loop in SimpleHeaderConverter and Values classes Key: KAFKA-10574 URL: https://issues.apache.org/jira/browse/KAFKA-10574 Project: Kafka

Re: [VOTE] KIP-614: Add Prefix Scan support for State Stores

2020-10-05 Thread Guozhang Wang
Hey Sagar, since the KIP is accepted, the next step would be to completing the PR review and finally merge it :) On Mon, Oct 5, 2020 at 9:46 AM Sagar wrote: > Hi All, > > Just wanted to know, what the next steps are wrt to the KIP? > > Thanks! > Sagar. > > > On Thu, Sep 3, 2020 at 10:17 PM

[jira] [Resolved] (KAFKA-10535) KIP-478: Implement StateStoreContext and Record

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10535. -- Resolution: Fixed > KIP-478: Implement StateStoreContext and Record >

Re: [VOTE] KIP-630: Kafka Raft Snapshot

2020-10-05 Thread Ron Dagostino
Thanks for the KIP, Jose. +1 (non-binding) from me. I do have one comment/confusion. Upon re-reading the latest version, I am confused about the name of the proposed "metadata.snapshot.min.records" config. Is this a size, or is it a count? I think it is about a size but want to be sure. I

[jira] [Resolved] (KAFKA-10530) kafka-streams-application-reset misses some internal topics

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10530. -- Resolution: Duplicate Closing now, since this seems like a duplicate report, and visual code

Re: [VOTE] KIP-614: Add Prefix Scan support for State Stores

2020-10-05 Thread Sagar
Hi All, Just wanted to know, what the next steps are wrt to the KIP? Thanks! Sagar. On Thu, Sep 3, 2020 at 10:17 PM Sagar wrote: > Hi John, > > Thank you! I have marked the KIP as Accepted :) > > Regarding the point on InMemoryKeyValueStore, in the PR I had added the > implementation for

Re: [VOTE] KIP-630: Kafka Raft Snapshot

2020-10-05 Thread Jason Gustafson
+1 Thanks for the KIP! -Jason On Mon, Oct 5, 2020 at 9:03 AM Ron Dagostino wrote: > Thanks for the KIP, Jose. +1 (non-binding) from me. > > I do have one comment/confusion. > > Upon re-reading the latest version, I am confused about the name of > the proposed "metadata.snapshot.min.records"

Build failed in Jenkins: Kafka » kafka-2.5-jdk8 #14

2020-10-05 Thread Apache Jenkins Server
See Changes: [Konstantine Karantasis] KAFKA-10439: Connect's Values to parse BigInteger as Decimal with zero scale. (#9320) -- [...truncated 3.10 MB...]

Build failed in Jenkins: Kafka » kafka-2.3-jdk8 #7

2020-10-05 Thread Apache Jenkins Server
See Changes: [Konstantine Karantasis] KAFKA-10439: Connect's Values to parse BigInteger as Decimal with zero scale. (#9320) -- [...truncated 2.57 MB...]

Build failed in Jenkins: Kafka » kafka-2.6-jdk8 #27

2020-10-05 Thread Apache Jenkins Server
See Changes: [Konstantine Karantasis] KAFKA-10439: Connect's Values to parse BigInteger as Decimal with zero scale. (#9320) -- [...truncated 3.16 MB...]

[jira] [Created] (KAFKA-10577) StreamThread should be able to process any processible tasks regardless of its state

2020-10-05 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-10577: - Summary: StreamThread should be able to process any processible tasks regardless of its state Key: KAFKA-10577 URL: https://issues.apache.org/jira/browse/KAFKA-10577

Jenkins build is back to normal : Kafka » kafka-trunk-jdk11 #115

2020-10-05 Thread Apache Jenkins Server
See

Build failed in Jenkins: Kafka » kafka-trunk-jdk15 #146

2020-10-05 Thread Apache Jenkins Server
See Changes: [github] MINOR: Move `RaftRequestHandler` to `tools` package (#9377) [github] KAFKA-10439: Connect's Values to parse BigInteger as Decimal with zero scale. (#9320)

[jira] [Created] (KAFKA-10576) Different behavior of commitSync and commitAsync

2020-10-05 Thread Yuriy Badalyantc (Jira)
Yuriy Badalyantc created KAFKA-10576: Summary: Different behavior of commitSync and commitAsync Key: KAFKA-10576 URL: https://issues.apache.org/jira/browse/KAFKA-10576 Project: Kafka

Kafka/Zookeeper

2020-10-05 Thread Scott, Thomas G
I have a quick question regarding kafka 2.4.0 and it's compatibility with Zookeeper. According to redhat, it looks like that perhaps kafka 2.4.0 requires Zookeeper 3.5.7 on RHEL 7. Could you please confirm, as it appears that according to the release notes, that Zookeeper 3.5.7 is not

Build failed in Jenkins: Kafka » kafka-2.4-jdk8 #11

2020-10-05 Thread Apache Jenkins Server
See Changes: [Konstantine Karantasis] KAFKA-10439: Connect's Values to parse BigInteger as Decimal with zero scale. (#9320) -- [...truncated 2.90 MB...]

Re: [DISCUSS] Apache Kafka 2.7.0 release

2020-10-05 Thread John Roesler
Hi Bill, Sorry about this, but I've just noticed that KIP-478 is missing from the list. The url is: https://cwiki.apache.org/confluence/display/KAFKA/KIP-478+-+Strongly+typed+Processor+API The KIP was accepted a long time ago, and the implementation has been trickling in since 2.6 branch cut.

Re: [DISCUSS] KIP-631: The Quorum-based Kafka Controller

2020-10-05 Thread Colin McCabe
On Mon, Sep 28, 2020, at 11:41, Jun Rao wrote: > Hi, Colin, > > Thanks for the reply. A few more comments below. > > 62. > 62.1 controller.listener.names: So, is this used for the controller or the > broker trying to connect to the controller? > Hi Jun, It's used by both. The broker tries to