[jira] [Closed] (KAFKA-532) Multiple controllers can co-exist during soft failures

2012-12-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao closed KAFKA-532. - Multiple controllers can co-exist during soft failures --

[jira] [Closed] (KAFKA-514) Replication with Leader Failure Test: Log segment files checksum mismatch

2012-12-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao closed KAFKA-514. - Replication with Leader Failure Test: Log segment files checksum mismatch

[jira] [Updated] (KAFKA-496) high level producer send should return a response

2012-12-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-496: -- Fix Version/s: (was: 0.8) 0.8.1 Moving this to 0.8.1. high level

[jira] [Commented] (KAFKA-608) getTopicMetadata does not respect producer config settings

2012-12-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13510663#comment-13510663 ] Jun Rao commented on KAFKA-608: --- I guess that you are talking about ClientUtils. Currently,

[jira] [Commented] (KAFKA-633) AdminTest.testShutdownBroker fails

2012-12-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13526028#comment-13526028 ] Jun Rao commented on KAFKA-633: --- Thanks for the patch. +1.

[jira] [Commented] (KAFKA-646) Provide aggregate stats at the high level Producer and ZookeeperConsumerConnector level

2012-12-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528559#comment-13528559 ] Jun Rao commented on KAFKA-646: --- Thanks for patch v4. Looks good overall. A few minor

[jira] [Commented] (KAFKA-581) provides windows batch script for starting Kafka/Zookeeper

2012-12-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528688#comment-13528688 ] Jun Rao commented on KAFKA-581: --- Thanks for the patch. Committed the stop scripts to 0.8.

[jira] [Commented] (KAFKA-374) Move to java CRC32 implementation

2012-12-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528690#comment-13528690 ] Jun Rao commented on KAFKA-374: --- Should this be a post 0.8 item? Move to

[jira] [Commented] (KAFKA-664) Kafka server threads die due to OOME during long running test

2012-12-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528707#comment-13528707 ] Jun Rao commented on KAFKA-664: --- If the problem is due to an expired request not being

[jira] [Commented] (KAFKA-664) Kafka server threads die due to OOME during long running test

2012-12-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13528723#comment-13528723 ] Jun Rao commented on KAFKA-664: --- Got it. So the issue is that for low volume topics, the

[jira] [Commented] (KAFKA-667) Rename .highwatermark file

2012-12-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529140#comment-13529140 ] Jun Rao commented on KAFKA-667: --- Thanks for the patch. +1. Rename

[jira] [Commented] (KAFKA-636) Make log segment delete asynchronous

2012-12-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529142#comment-13529142 ] Jun Rao commented on KAFKA-636: --- Thanks for the patch. +1. Just one minor comment: 1.

[jira] [Commented] (KAFKA-646) Provide aggregate stats at the high level Producer and ZookeeperConsumerConnector level

2012-12-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529639#comment-13529639 ] Jun Rao commented on KAFKA-646: --- Thanks for patch v5. A few more comments: 50. Config: 50.1

[jira] [Commented] (KAFKA-664) Kafka server threads die due to OOME during long running test

2012-12-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13530709#comment-13530709 ] Jun Rao commented on KAFKA-664: --- Thanks for patch v3. +1 from me. One minor comment: Should

[jira] [Commented] (KAFKA-598) decouple fetch size from max message size

2012-12-19 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13536339#comment-13536339 ] Jun Rao commented on KAFKA-598: --- I took a look at the patch again. Yes, you are right. Your

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2012-12-20 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537237#comment-13537237 ] Jun Rao commented on KAFKA-657: --- I was trying to apply patch v3 in trunk (on a revision

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2012-12-20 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537327#comment-13537327 ] Jun Rao commented on KAFKA-657: --- Thanks for patch v4. Some comments: 40. Could you add the

[jira] [Resolved] (KAFKA-681) Unclean shutdown testing - truncateAndStartWithNewOffset is not invoked when it is expected to

2013-01-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-681. --- Resolution: Fixed Fix Version/s: 0.8 Assignee: Jun Rao Thanks for the review. Committed to

[jira] [Closed] (KAFKA-681) Unclean shutdown testing - truncateAndStartWithNewOffset is not invoked when it is expected to

2013-01-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao closed KAFKA-681. - Unclean shutdown testing - truncateAndStartWithNewOffset is not invoked when it is expected to

[jira] [Resolved] (KAFKA-680) ApiUtils#writeShortString uses String length instead of byte length

2013-01-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-680. --- Resolution: Fixed Fix Version/s: 0.8 Thanks for the patch. +1. Committed to 0.8 and merged into trunk.

[jira] [Commented] (KAFKA-657) Add an API to commit offsets

2013-01-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544322#comment-13544322 ] Jun Rao commented on KAFKA-657: --- v8 looks good. Just some minor comments. 80.

[jira] [Commented] (KAFKA-682) java.lang.OutOfMemoryError: Java heap space

2013-01-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544333#comment-13544333 ] Jun Rao commented on KAFKA-682: --- That commit is in trunk. Could you try the current head in

[jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka

2013-01-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544506#comment-13544506 ] Jun Rao commented on KAFKA-683: --- Thanks for the patch. Some comments: 1.

[jira] [Commented] (KAFKA-684) ConsoleProducer does not have the queue-size option

2013-01-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546291#comment-13546291 ] Jun Rao commented on KAFKA-684: --- Thanks for the patch. It looks good. While you are here,

[jira] [Commented] (KAFKA-685) ConsoleOffsetChecker does not work with 0.8

2013-01-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546397#comment-13546397 ] Jun Rao commented on KAFKA-685: --- Thanks for the patch. The code looks good. Got the

[jira] [Commented] (KAFKA-133) Publish kafka jar to a public maven repository

2013-01-07 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13546624#comment-13546624 ] Jun Rao commented on KAFKA-133: --- Joe, do you plan to merge the commit to the 0.8 branch?

[jira] [Commented] (KAFKA-689) Can't append to a topic/partition that does not already exist

2013-01-09 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13548748#comment-13548748 ] Jun Rao commented on KAFKA-689: --- Currently, auto-creation is a broker-side flag. Basically,

[jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys

2013-01-09 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13549075#comment-13549075 ] Jun Rao commented on KAFKA-648: --- Thanks for patch v4. Made another pass. Should we make the

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-09 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13549373#comment-13549373 ] Jun Rao commented on KAFKA-691: --- DefaultEventHander.getPartitionListForTopic() returns

[jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka

2013-01-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13549792#comment-13549792 ] Jun Rao commented on KAFKA-683: --- Patch v2 doesn't seem to apply on 0.8. Could you rebase?

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13549842#comment-13549842 ] Jun Rao commented on KAFKA-691: --- Thanks for the patch. Overall, the patch is pretty good and

[jira] [Commented] (KAFKA-689) Can't append to a topic/partition that does not already exist

2013-01-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13549888#comment-13549888 ] Jun Rao commented on KAFKA-689: --- In KafkaConfig, we have a property auto.create.topics. We

[jira] [Resolved] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-10 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-691. --- Resolution: Fixed Fix Version/s: 0.8 Assignee: Maxime Brugidou Thanks for patch v2. Committed

[jira] [Commented] (KAFKA-648) Use uniform convention for naming properties keys

2013-01-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13551233#comment-13551233 ] Jun Rao commented on KAFKA-648: --- Thanks for patch v5. Some of the comments in those config

[jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka

2013-01-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13551550#comment-13551550 ] Jun Rao commented on KAFKA-683: --- The changes in core/src/test/resources/log4j.properties are

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552336#comment-13552336 ] Jun Rao commented on KAFKA-691: --- It would be great if you can provide a patch. 1,2,3. Yes,

[jira] [Commented] (KAFKA-693) Consumer rebalance fails if no leader available for a partition and stops all fetchers

2013-01-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552341#comment-13552341 ] Jun Rao commented on KAFKA-693: --- Ok. This is actually a real problem. During rebalance, we

[jira] [Commented] (KAFKA-695) Broker shuts down due to attempt to read a closed index file

2013-01-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552342#comment-13552342 ] Jun Rao commented on KAFKA-695: --- The weird thing is that the file actually exists on disk

[jira] [Commented] (KAFKA-698) broker may expose uncommitted data to a consumer

2013-01-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13552375#comment-13552375 ] Jun Rao commented on KAFKA-698: --- My analysis is the following. In LogSegment.read(), we have

[jira] [Created] (KAFKA-699) Disallow clients to set replicaId in FetchRequest

2013-01-13 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-699: - Summary: Disallow clients to set replicaId in FetchRequest Key: KAFKA-699 URL: https://issues.apache.org/jira/browse/KAFKA-699 Project: Kafka Issue Type: Improvement

[jira] [Updated] (KAFKA-698) broker may expose uncommitted data to a consumer

2013-01-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-698: -- Status: Patch Available (was: Open) broker may expose uncommitted data to a consumer

[jira] [Issue Comment Deleted] (KAFKA-698) broker may expose uncommitted data to a consumer

2013-01-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-698: -- Comment: was deleted (was: Attach a patch. It removes replicaId from javaapi.FetchRequest and restricts the

[jira] [Updated] (KAFKA-699) Disallow clients to set replicaId in FetchRequest

2013-01-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-699: -- Attachment: kafka-699.patch Attach a patch. It removes replicaId from javaapi.FetchRequest and restricts the

[jira] [Commented] (KAFKA-702) Deadlock between request handler/processor threads

2013-01-14 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553499#comment-13553499 ] Jun Rao commented on KAFKA-702: --- I am wondering if the following approach will break the

[jira] [Resolved] (KAFKA-704) ConsumerFetcherThread can create illegal clientId

2013-01-15 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-704. --- Resolution: Duplicate This is a duplicate of KAFKA-697. ConsumerFetcherThread can create

[jira] [Commented] (KAFKA-697) ConsoleConsumer throws InvalidConfigException for . in client id

2013-01-15 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554048#comment-13554048 ] Jun Rao commented on KAFKA-697: --- Thanks for the latest patch. Committed to 0.8 and merged to

[jira] [Commented] (KAFKA-693) Consumer rebalance fails if no leader available for a partition and stops all fetchers

2013-01-15 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554068#comment-13554068 ] Jun Rao commented on KAFKA-693: --- Thanks for the patch. Some comments: 10.

[jira] [Issue Comment Deleted] (KAFKA-699) Disallow clients to set replicaId in FetchRequest

2013-01-15 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-699: -- Comment: was deleted (was: This doesn't seem too hard. In Processor.read(), we can add

[jira] [Commented] (KAFKA-700) log client ip when we log each request on the broker

2013-01-15 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554755#comment-13554755 ] Jun Rao commented on KAFKA-700: --- This doesn't seem too hard. In Processor.read(), we can add

[jira] [Updated] (KAFKA-699) Disallow clients to set replicaId in FetchRequest

2013-01-15 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-699: -- Resolution: Fixed Fix Version/s: 0.8 Status: Resolved (was: Patch Available) Thanks for the

[jira] [Commented] (KAFKA-700) log client ip when we log each request on the broker

2013-01-15 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554773#comment-13554773 ] Jun Rao commented on KAFKA-700: --- I was thinking of just putting the ip in

[jira] [Commented] (KAFKA-649) Cleanup log4j logging

2013-01-16 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555150#comment-13555150 ] Jun Rao commented on KAFKA-649: --- I can take a look at this. Cleanup log4j

[jira] [Assigned] (KAFKA-649) Cleanup log4j logging

2013-01-16 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao reassigned KAFKA-649: - Assignee: Jun Rao Cleanup log4j logging - Key: KAFKA-649

[jira] [Commented] (KAFKA-631) Implement log compaction

2013-01-16 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555154#comment-13555154 ] Jun Rao commented on KAFKA-631: --- Thanks for the patch. Do you know the revision of trunk on

[jira] [Commented] (KAFKA-693) Consumer rebalance fails if no leader available for a partition and stops all fetchers

2013-01-16 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555251#comment-13555251 ] Jun Rao commented on KAFKA-693: --- Thanks for patch v2. Looks good. Some minor comments: 11. I

[jira] [Updated] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-16 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-691: -- Attachment: kafka-691_extra.patch The last patch introduced a bug. DefaultEventHander.getPartition() is

[jira] [Updated] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-16 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-691: -- Attachment: kafka-691_extra.patch Attach the right patch (kafka-691_extra.patch). Fault

[jira] [Commented] (KAFKA-691) Fault tolerance broken with replication factor 1

2013-01-17 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556380#comment-13556380 ] Jun Rao commented on KAFKA-691: --- Actually, the current code works since partitionId is always

[jira] [Updated] (KAFKA-693) Consumer rebalance fails if no leader available for a partition and stops all fetchers

2013-01-17 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-693: -- Resolution: Fixed Fix Version/s: 0.8 Status: Resolved (was: Patch Available) Thanks for the

[jira] [Commented] (KAFKA-696) Fix toString() API for all requests to make logging easier to read

2013-01-20 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558439#comment-13558439 ] Jun Rao commented on KAFKA-696: --- Thanks for the patch. Some comments: 1.

[jira] [Commented] (KAFKA-671) DelayedProduce requests should not hold full producer request data

2013-01-20 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558448#comment-13558448 ] Jun Rao commented on KAFKA-671: --- Thinking about this a bit more. There is another approach.

[jira] [Updated] (KAFKA-710) Some arguments are always set to default in ProducerPerformance

2013-01-20 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-710: -- Resolution: Fixed Fix Version/s: 0.8 Assignee: John Fung Status: Resolved (was:

[jira] [Commented] (KAFKA-710) Some arguments are always set to default in ProducerPerformance

2013-01-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13558867#comment-13558867 ] Jun Rao commented on KAFKA-710: --- Just to clarify. The problem is that there are duplicated

[jira] [Commented] (KAFKA-139) cross-compile multiple Scala versions and upgrade to SBT 0.12.1

2013-01-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559073#comment-13559073 ] Jun Rao commented on KAFKA-139: --- Joe, after your check in. I saw a couple of changes: (1)

[jira] [Updated] (KAFKA-714) ConsoleConsumer throws SocketTimeoutException when fetching topic metadata

2013-01-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-714: -- Attachment: kafka-714.patch Thanks for opening the jira. Attach a patch that allows socket timeout to be

[jira] [Updated] (KAFKA-714) ConsoleConsumer throws SocketTimeoutException when fetching topic metadata

2013-01-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-714: -- Status: Patch Available (was: Open) ConsoleConsumer throws SocketTimeoutException when fetching topic

[jira] [Updated] (KAFKA-714) ConsoleConsumer throws SocketTimeoutException when fetching topic metadata

2013-01-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-714?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-714: -- Component/s: core Priority: Blocker (was: Critical) Affects Version/s: 0.8

[jira] [Commented] (KAFKA-708) ISR becomes empty while marking a partition offline

2013-01-21 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559334#comment-13559334 ] Jun Rao commented on KAFKA-708: --- Thanks for the patch. Overall, looks good. A couple of minor

[jira] [Created] (KAFKA-721) FileNotFoundException on index file

2013-01-22 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-721: - Summary: FileNotFoundException on index file Key: KAFKA-721 URL: https://issues.apache.org/jira/browse/KAFKA-721 Project: Kafka Issue Type: Bug Components:

[jira] [Commented] (KAFKA-721) FileNotFoundException on index file

2013-01-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559897#comment-13559897 ] Jun Rao commented on KAFKA-721: --- The following is what happened: 1. We are starting a

[jira] [Created] (KAFKA-727) broker can still expose uncommitted data to a consumer

2013-01-22 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-727: - Summary: broker can still expose uncommitted data to a consumer Key: KAFKA-727 URL: https://issues.apache.org/jira/browse/KAFKA-727 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-727) broker can still expose uncommitted data to a consumer

2013-01-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560412#comment-13560412 ] Jun Rao commented on KAFKA-727: --- Jay, sure, you can take this on. The way we saw this is that

[jira] [Commented] (KAFKA-726) Add ReplicaFetcherThread name to mbean names

2013-01-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560421#comment-13560421 ] Jun Rao commented on KAFKA-726: --- Thanks for the patch. In ReplicaFetcherManager, it's

[jira] [Commented] (KAFKA-139) cross-compile multiple Scala versions and upgrade to SBT 0.12.1

2013-01-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560825#comment-13560825 ] Jun Rao commented on KAFKA-139: --- Also, when running bin/kafka-console-producer.sh

[jira] [Commented] (KAFKA-708) ISR becomes empty while marking a partition offline

2013-01-23 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561024#comment-13561024 ] Jun Rao commented on KAFKA-708: --- There is a typo logIndent in Logging that causes a

[jira] [Commented] (KAFKA-695) Broker shuts down due to attempt to read a closed index file

2013-01-24 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561888#comment-13561888 ] Jun Rao commented on KAFKA-695: --- Another piece of info is that the log segment seems to exist

[jira] [Commented] (KAFKA-700) log client ip when we log each request on the broker

2013-01-25 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13562890#comment-13562890 ] Jun Rao commented on KAFKA-700: --- Looks good. Just 1 comment: 10. RichString.format() seems

[jira] [Updated] (KAFKA-695) Broker shuts down due to attempt to read a closed index file

2013-01-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-695: -- Attachment: kafka-695.patch I have a theory of what's happening here. What we overlooked is that there is

[jira] [Updated] (KAFKA-695) Broker shuts down due to attempt to read a closed index file

2013-01-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-695: -- Fix Version/s: 0.8 Status: Patch Available (was: Open) Broker shuts down due to attempt to

[jira] [Created] (KAFKA-738) correlationId is not set in FetchRequest in AbstractFetcherThread

2013-01-27 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-738: - Summary: correlationId is not set in FetchRequest in AbstractFetcherThread Key: KAFKA-738 URL: https://issues.apache.org/jira/browse/KAFKA-738 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-631) Implement log compaction

2013-01-28 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13564388#comment-13564388 ] Jun Rao commented on KAFKA-631: --- A few more comments: 73.

[jira] [Commented] (KAFKA-695) Broker shuts down due to attempt to read a closed index file

2013-01-28 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13564393#comment-13564393 ] Jun Rao commented on KAFKA-695: --- So, do you think the patch is ok or do you plan to provide a

[jira] [Updated] (KAFKA-695) Broker shuts down due to attempt to read a closed index file

2013-01-28 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-695: -- Attachment: kafka-695_v2.patch Attach patch v2. Simplified the logic a bit. ExpiredRequestReaper now checks if

[jira] [Updated] (KAFKA-738) correlationId is not set in FetchRequest in AbstractFetcherThread

2013-01-28 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-738: -- Attachment: kafka-738.patch Attach a patch. Yes, we have to create a new FetchRequestBuilder every time,

[jira] [Assigned] (KAFKA-738) correlationId is not set in FetchRequest in AbstractFetcherThread

2013-01-28 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao reassigned KAFKA-738: - Assignee: Jun Rao correlationId is not set in FetchRequest in AbstractFetcherThread

[jira] [Updated] (KAFKA-738) correlationId is not set in FetchRequest in AbstractFetcherThread

2013-01-29 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-738: -- Resolution: Fixed Fix Version/s: 0.8 Status: Resolved (was: Patch Available) Thanks for the

[jira] [Updated] (KAFKA-737) System Test : Disable shallow.iterator in Mirror Maker test cases to make compression work correctly

2013-01-29 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-737: -- Resolution: Fixed Fix Version/s: 0.8 Status: Resolved (was: Patch Available) Thanks for the

[jira] [Commented] (KAFKA-683) Fix correlation ids in all requests sent to kafka

2013-01-30 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566563#comment-13566563 ] Jun Rao commented on KAFKA-683: --- Yes, the main changes were made by me in kafka-203. If we

[jira] [Updated] (KAFKA-743) PreferredReplicaLeaderElectionCommand has command line error

2013-01-30 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-743: -- Status: Patch Available (was: Open) PreferredReplicaLeaderElectionCommand has command line error

[jira] [Updated] (KAFKA-743) PreferredReplicaLeaderElectionCommand has command line error

2013-01-30 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-743: -- Attachment: kafka-743.patch Attach a fix. PreferredReplicaLeaderElectionCommand has command

[jira] [Updated] (KAFKA-695) Broker shuts down due to attempt to read a closed index file

2013-01-30 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-695: -- Attachment: kafka-695_followup.patch Attach a follow up patch. 1. Make ExpiredRequestReaper a non-daemon

[jira] [Commented] (KAFKA-736) Add an option to the 0.8 producer to mimic 0.7 producer behavior

2013-02-03 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569828#comment-13569828 ] Jun Rao commented on KAFKA-736: --- Thanks for the results. The case with 20 producer threads is

[jira] [Created] (KAFKA-750) inconsistent index offset during broker startup

2013-02-04 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-750: - Summary: inconsistent index offset during broker startup Key: KAFKA-750 URL: https://issues.apache.org/jira/browse/KAFKA-750 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-695) Broker shuts down due to attempt to read a closed index file

2013-02-05 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-695: -- Attachment: kafka-695_followup_v2.patch Attach followup patch v2. Broker shuts down due to

[jira] [Commented] (KAFKA-748) Append to index fails due to invalid offset

2013-02-08 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13574678#comment-13574678 ] Jun Rao commented on KAFKA-748: --- Thanks for the patch. It looks good. So +1. I suggest that

[jira] [Created] (KAFKA-755) standardizing json values stored in ZK

2013-02-11 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-755: - Summary: standardizing json values stored in ZK Key: KAFKA-755 URL: https://issues.apache.org/jira/browse/KAFKA-755 Project: Kafka Issue Type: Bug Components:

[jira] [Commented] (KAFKA-756) Processor thread blocks due to infinite loop during fetch response send

2013-02-11 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576271#comment-13576271 ] Jun Rao commented on KAFKA-756: --- Thanks for patch v2. Looks good overall. A few minor

[jira] [Updated] (KAFKA-743) PreferredReplicaLeaderElectionCommand has command line error

2013-02-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-743: -- Resolution: Fixed Fix Version/s: 0.8 Assignee: Jun Rao Status: Resolved (was: Patch

[jira] [Commented] (KAFKA-755) standardizing json values stored in ZK

2013-02-12 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577218#comment-13577218 ] Jun Rao commented on KAFKA-755: --- Proposed the new format in

[jira] [Commented] (KAFKA-736) Add an option to the 0.8 producer to mimic 0.7 producer behavior

2013-02-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577800#comment-13577800 ] Jun Rao commented on KAFKA-736: --- Because of the problem identified in KAFKA-706, only the v3

  1   2   3   4   5   6   7   8   9   10   >