GitHub user rhauch opened a pull request:

    https://github.com/apache/kafka/pull/1871

    KAFKA-4183 Corrected Kafka Connect's JSON Converter to properly convert 
from null to logical values

    The `JsonConverter` class has `LogicalTypeConverter` implementations for 
Date, Time, Timestamp, and Decimal, but these implementations fail when the 
input literal value (deserialized from the message) is null. 
    
    Test cases were added to check for these cases, and these failed before the 
`LogicalTypeConverter` implementations were fixed to consider whether the 
schema has a default value or is optional, similarly to how the 
`JsonToConnectTypeConverter` implementations do this. Once the fixes were made, 
the new tests pass.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rhauch/kafka kafka-4183-0.10.0

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1871.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1871
    
----
commit 4ffb9409f5a75345cf53aed0d799e6c694f636ca
Author: Randall Hauch <rha...@gmail.com>
Date:   2016-09-16T19:05:06Z

    KAFKA-4183 Corrected Kafka Connect's JSON Converter to properly convert 
from deserialized null values.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to