[GitHub] kafka pull request #2015: Small refactoring to improve readability and reduc...

2016-10-24 Thread picadoh
Github user picadoh closed the pull request at:

https://github.com/apache/kafka/pull/2015


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] kafka pull request #2015: Small refactoring to improve readability and reduc...

2016-10-12 Thread picadoh
GitHub user picadoh opened a pull request:

https://github.com/apache/kafka/pull/2015

Small refactoring to improve readability and reduce method complexity

Small method extraction to reduce complexity and improve readability of the 
assign method. 

Private methods were created for:
- Get the assignment suppliers based on the subscriptions (decoding of 
subscriptions info is also done at this point, where it is used)
- Calculate the number of partitions for internal topic
- Add tasks to state change log topic subscribers

These methods are being called inside the assign method.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/picadoh/kafka trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2015.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2015


commit 001c890d02bf04b6f498e87d6ab347565db07dc0
Author: Hugo Picado 
Date:   2016-10-12T22:19:07Z

MINOR: small method extraction to reduce complexity and improve readability 
of assign method: get the assignment suppliers, calculate the number of 
partitions for internal topic and add tasks to state changelog topic.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---