Re: [VOTE] KIP-298: Error Handling in Connect kafka

2018-05-25 Thread Arjun Satish
All, The PR discussions prompted us to consider adding a new configuration property for the dead letter queue. This (boolean) property when enabled, would add headers to the raw record that contain details about the error (such as original topic, partition, offset of the record, connector name, ta

Re: [VOTE] KIP-298: Error Handling in Connect kafka

2018-05-22 Thread Arjun Satish
All, I'm closing this voting thread with 5 binding votes (Gwen, Guozhang, Matthias, Ewen, Jason) and 3 non-binding votes (Konstantine, Magesh, Randall). Thanks everyone for your comments and feedback. Much appreciated! Best, Arjun On Tue, May 22, 2018 at 11:39 AM, Jason Gustafson wrote: > +1.

Re: [VOTE] KIP-298: Error Handling in Connect kafka

2018-05-22 Thread Jason Gustafson
+1. Thanks for the KIP! On Mon, May 21, 2018 at 1:34 PM, Arjun Satish wrote: > All, > > Thanks so much for your feedback on this KIP. I've made some small > modifications today. I'll wait till midnight today (PDT) to close this > vote. Please let me know if there are any further comments. > > Be

Re: [VOTE] KIP-298: Error Handling in Connect kafka

2018-05-21 Thread Arjun Satish
All, Thanks so much for your feedback on this KIP. I've made some small modifications today. I'll wait till midnight today (PDT) to close this vote. Please let me know if there are any further comments. Best, On Mon, May 21, 2018 at 11:29 AM, Ewen Cheslack-Postava wrote: > +1 binding. I had on

Re: [VOTE] KIP-298: Error Handling in Connect kafka

2018-05-21 Thread Ewen Cheslack-Postava
+1 binding. I had one last comment in the DISCUSS thread, but not really a blocker. -Ewen On Mon, May 21, 2018 at 9:48 AM Matthias J. Sax wrote: > +1 (binding) > > > > On 5/21/18 9:30 AM, Randall Hauch wrote: > > Thanks, Arjun. +1 (non-binding) > > > > Regards, > > Randall > > > > On Mon, May 2

Re: [VOTE] KIP-298: Error Handling in Connect kafka

2018-05-21 Thread Matthias J. Sax
+1 (binding) On 5/21/18 9:30 AM, Randall Hauch wrote: > Thanks, Arjun. +1 (non-binding) > > Regards, > Randall > > On Mon, May 21, 2018 at 11:14 AM, Guozhang Wang wrote: > >> Thanks for the KIP. +1 (binding) >> >> >> Guozhang >> >> On Fri, May 18, 2018 at 3:36 PM, Gwen Shapira wrote: >> >>>

Re: [VOTE] KIP-298: Error Handling in Connect kafka

2018-05-21 Thread Randall Hauch
Thanks, Arjun. +1 (non-binding) Regards, Randall On Mon, May 21, 2018 at 11:14 AM, Guozhang Wang wrote: > Thanks for the KIP. +1 (binding) > > > Guozhang > > On Fri, May 18, 2018 at 3:36 PM, Gwen Shapira wrote: > > > +1 > > > > Thank you! Error handling in Connect will be a huge improvement. >

Re: [VOTE] KIP-298: Error Handling in Connect kafka

2018-05-21 Thread Guozhang Wang
Thanks for the KIP. +1 (binding) Guozhang On Fri, May 18, 2018 at 3:36 PM, Gwen Shapira wrote: > +1 > > Thank you! Error handling in Connect will be a huge improvement. > > On Thu, May 17, 2018, 1:58 AM Arjun Satish wrote: > > > All, > > > > Many thanks for all the feedback on KIP-298. Highly

Re: [VOTE] KIP-298: Error Handling in Connect kafka

2018-05-18 Thread Gwen Shapira
+1 Thank you! Error handling in Connect will be a huge improvement. On Thu, May 17, 2018, 1:58 AM Arjun Satish wrote: > All, > > Many thanks for all the feedback on KIP-298. Highly appreciate the time and > effort you all put into it. > > I've updated the KIP accordingly, and would like to star

Re: [VOTE] KIP-298: Error Handling in Connect kafka

2018-05-18 Thread Magesh Nandakumar
+1 (non-binding) Thanks, Magesh On Fri, May 18, 2018 at 2:38 PM, Konstantine Karantasis < konstant...@confluent.io> wrote: > +1 (non-binding) > > - Konstantine > > On Thu, May 17, 2018 at 12:58 AM, Arjun Satish > wrote: > > > All, > > > > Many thanks for all the feedback on KIP-298. Highly appr

Re: [VOTE] KIP-298: Error Handling in Connect kafka

2018-05-18 Thread Konstantine Karantasis
+1 (non-binding) - Konstantine On Thu, May 17, 2018 at 12:58 AM, Arjun Satish wrote: > All, > > Many thanks for all the feedback on KIP-298. Highly appreciate the time and > effort you all put into it. > > I've updated the KIP accordingly, and would like to start to start a vote > on it. > > KI

[VOTE] KIP-298: Error Handling in Connect kafka

2018-05-17 Thread Arjun Satish
All, Many thanks for all the feedback on KIP-298. Highly appreciate the time and effort you all put into it. I've updated the KIP accordingly, and would like to start to start a vote on it. KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP- 298%3A+Error+Handling+in+Connect JIRA: https:/