Re: [VOTE] KIP-621: Deprecate and replace DescribeLogDirsResult.all() and .values()

2020-07-10 Thread Tom Bentley
Thanks Dongjin, I was hoping to close the vote, but was waiting till we had consensus around the points you raised on the discussion thread. On Fri, Jul 10, 2020 at 2:39 PM Dongjin Lee wrote: > +1. (non-binding) > > As of present, it has 3 bindings (Colin, Manikumar, and Mickael) and 2 >

Re: [VOTE] KIP-621: Deprecate and replace DescribeLogDirsResult.all() and .values()

2020-07-10 Thread Dongjin Lee
+1. (non-binding) As of present, it has 3 bindings (Colin, Manikumar, and Mickael) and 2 non-bindings (David, Dongjin). Since it has 3 binding +1 votes and more binding +1 votes than -1 votes, this KIP is accepted. Thanks everyone for the votes. On Thu, Jul 9, 2020 at 6:19 PM Mickael Maison

Re: [VOTE] KIP-621: Deprecate and replace DescribeLogDirsResult.all() and .values()

2020-07-09 Thread Mickael Maison
+1 (binding) Thanks On Thu, Jul 9, 2020 at 9:11 AM David Jacot wrote: > > I couldn't think of a better alternative either. Thanks for the KIP! > > +1 (non-binding) > > On Wed, Jul 8, 2020 at 12:42 PM Manikumar wrote: > > > +1 (binding) > > > > Thanks for the KIP. > > > > On Tue, Jul 7, 2020 at

Re: [VOTE] KIP-621: Deprecate and replace DescribeLogDirsResult.all() and .values()

2020-07-09 Thread David Jacot
I couldn't think of a better alternative either. Thanks for the KIP! +1 (non-binding) On Wed, Jul 8, 2020 at 12:42 PM Manikumar wrote: > +1 (binding) > > Thanks for the KIP. > > On Tue, Jul 7, 2020 at 8:19 PM Colin McCabe wrote: > > > Thanks, Tom. > > > > I tried to think of a better way to

Re: [VOTE] KIP-621: Deprecate and replace DescribeLogDirsResult.all() and .values()

2020-07-08 Thread Manikumar
+1 (binding) Thanks for the KIP. On Tue, Jul 7, 2020 at 8:19 PM Colin McCabe wrote: > Thanks, Tom. > > I tried to think of a better way to do this, but I think you're right that > we probably just need different methods. > > +1 (binding). > > best, > Colin > > On Mon, Jul 6, 2020, at 01:14,

Re: [VOTE] KIP-621: Deprecate and replace DescribeLogDirsResult.all() and .values()

2020-07-07 Thread Colin McCabe
Thanks, Tom. I tried to think of a better way to do this, but I think you're right that we probably just need different methods. +1 (binding). best, Colin On Mon, Jul 6, 2020, at 01:14, Tom Bentley wrote: > Hi, > > I'd like to start a vote on KIP-621 which is about deprecating methods in >

[VOTE] KIP-621: Deprecate and replace DescribeLogDirsResult.all() and .values()

2020-07-06 Thread Tom Bentley
Hi, I'd like to start a vote on KIP-621 which is about deprecating methods in DescribeLogDirsResult which leak internal classes, replacing them with public API classes. https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=158862109 Thanks, Tom