Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and consumer configuration override

2020-10-08 Thread Dániel Urbán
Thank you for the votes! The KIP passes with 3 binding votes (Manikumar, Mickael, Ismael) and 3 non-binding votes (Viktor, Kamal, David). Daniel Ismael Juma ezt írta (időpont: 2020. okt. 8., Cs, 16:27): > Thanks for the KIP, +1 (binding). > > On Mon, Jul 27, 2020 at 1:09 AM Dániel Urbán >

Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and consumer configuration override

2020-10-08 Thread Ismael Juma
Thanks for the KIP, +1 (binding). On Mon, Jul 27, 2020 at 1:09 AM Dániel Urbán wrote: > Hello everyone, > > I'd like to start a vote on KIP-635. The KIP enhances the GetOffsetShell > tool by enabling querying multiple topic-partitions, adding new filtering > options, and adding a config

Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and consumer configuration override

2020-09-14 Thread Mickael Maison
+1 (binding) Thanks for the KIP Daniel On Mon, Aug 31, 2020 at 2:31 PM Dániel Urbán wrote: > > Hello everyone, > > I'd like to ask you to consider voting for this KIP, it only needs 2 more > binding votes. > > This KIP focuses on the GetOffsetShell tool. The tool is useful for > monitoring and

Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and consumer configuration override

2020-08-31 Thread Dániel Urbán
Hello everyone, I'd like to ask you to consider voting for this KIP, it only needs 2 more binding votes. This KIP focuses on the GetOffsetShell tool. The tool is useful for monitoring and investigations as well. Unfortunately, the tool misses one key, and some quality-of-life features: - Because

Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and consumer configuration override

2020-08-27 Thread Dániel Urbán
Hi all, Please vote if you'd like to see this implemented. This one fixes a long-time debt, would be nice to see it pass. Thank you, Daniel Dániel Urbán ezt írta (időpont: 2020. aug. 18., K, 14:06): > Hello everyone, > > Please, if you are interested in this KIP and PR, don't forget to vote.

Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and consumer configuration override

2020-08-18 Thread Dániel Urbán
Hello everyone, Please, if you are interested in this KIP and PR, don't forget to vote. Thank you, Daniel Dániel Urbán ezt írta (időpont: 2020. aug. 13., Cs, 14:00): > Hi David, > > Thank you for the suggestion. KIP-635 was referencing the --broker-list > issue, but based on your suggestion,

Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and consumer configuration override

2020-08-13 Thread Dániel Urbán
Hi David, Thank you for the suggestion. KIP-635 was referencing the --broker-list issue, but based on your suggestion, I pinged the PR https://github.com/apache/kafka/pull/8123. Since I got no response, I updated KIP-635 to deprecate --broker-list. Will update the PR related to KIP-635 to reflect

Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and consumer configuration override

2020-08-10 Thread David Jacot
Hi Daniel, I was not aware of that PR. At minimum, I would add `--bootstrap-server` to the list in the KIP for completeness. Regarding the implementation, I would leave a comment in that PR asking if they plan to continue it. If not, we could do it as part of your PR directly. Cheers, David On

Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and consumer configuration override

2020-08-10 Thread Dániel Urbán
Hi everyone, Just a reminder, please vote if you are interested in this KIP being implemented. Thanks, Daniel Dániel Urbán ezt írta (időpont: 2020. júl. 31., P, 9:01): > Hi David, > > There is another PR linked on KAFKA-8507, which is still open: > https://github.com/apache/kafka/pull/8123 >

Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and consumer configuration override

2020-07-31 Thread Dániel Urbán
Hi David, There is another PR linked on KAFKA-8507, which is still open: https://github.com/apache/kafka/pull/8123 Wasn't sure if it will go in, and wanted to avoid conflicts. Do you think I should do the switch to '--bootstrap-server' anyway? Thanks, Daniel David Jacot ezt írta (időpont:

Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and consumer configuration override

2020-07-30 Thread David Jacot
Hi Daniel, Thanks for the KIP. It seems that we have forgotten to include this tool in KIP-499. KAFKA-8507 is resolved by this tool still uses the deprecated "--broker-list". I suggest to include "--bootstrap-server" in your public interfaces as well and fix this omission during the

Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and consumer configuration override

2020-07-30 Thread Kamal Chandraprakash
+1 (non-binding), thanks for the KIP! On Thu, Jul 30, 2020 at 3:31 PM Manikumar wrote: > +1 (binding) > > Thanks for the KIP! > > > > On Thu, Jul 30, 2020 at 3:07 PM Dániel Urbán > wrote: > > > Hi everyone, > > > > If you are interested in this KIP, please do not forget to vote. > > > >

Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and consumer configuration override

2020-07-30 Thread Manikumar
+1 (binding) Thanks for the KIP! On Thu, Jul 30, 2020 at 3:07 PM Dániel Urbán wrote: > Hi everyone, > > If you are interested in this KIP, please do not forget to vote. > > Thanks, > Daniel > > Viktor Somogyi-Vass ezt írta (időpont: 2020. > júl. > 28., K, 16:06): > > > +1 from me

Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and consumer configuration override

2020-07-30 Thread Dániel Urbán
Hi everyone, If you are interested in this KIP, please do not forget to vote. Thanks, Daniel Viktor Somogyi-Vass ezt írta (időpont: 2020. júl. 28., K, 16:06): > +1 from me (non-binding), thanks for the KIP. > > On Mon, Jul 27, 2020 at 10:02 AM Dániel Urbán > wrote: > > > Hello everyone, > >

Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and consumer configuration override

2020-07-28 Thread Viktor Somogyi-Vass
+1 from me (non-binding), thanks for the KIP. On Mon, Jul 27, 2020 at 10:02 AM Dániel Urbán wrote: > Hello everyone, > > I'd like to start a vote on KIP-635. The KIP enhances the GetOffsetShell > tool by enabling querying multiple topic-partitions, adding new filtering > options, and adding a

[VOTE] KIP-635: GetOffsetShell: support for multiple topics and consumer configuration override

2020-07-27 Thread Dániel Urbán
Hello everyone, I'd like to start a vote on KIP-635. The KIP enhances the GetOffsetShell tool by enabling querying multiple topic-partitions, adding new filtering options, and adding a config override option.