[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2016-10-17 Thread Nacho Solis (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584156#comment-15584156 ] Nacho Solis commented on KAFKA-1351: Thanks [~jjkoshy]. Yes, this is a pet peeve of m

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2016-10-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583851#comment-15583851 ] Joel Koshy commented on KAFKA-1351: --- Yes - this is still an issue. cc [~nsolis] > Strin

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2016-10-17 Thread Andrew Musselman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582973#comment-15582973 ] Andrew Musselman commented on KAFKA-1351: - Still open? > String.format is very ex

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2015-04-26 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513131#comment-14513131 ] Ismael Juma commented on KAFKA-1351: Personally, I think the right way to go is to use

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2015-04-26 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513096#comment-14513096 ] Neha Narkhede commented on KAFKA-1351: -- Not sure that this is still a concern. I was

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2015-04-04 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395970#comment-14395970 ] Jay Kreps commented on KAFKA-1351: -- [~nehanarkhede] is this still active? If not can we c

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2015-03-27 Thread Fabian Lange (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383501#comment-14383501 ] Fabian Lange commented on KAFKA-1351: - [~ijuma] thanks for the hint, i will double che

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2015-03-26 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382919#comment-14382919 ] Ismael Juma commented on KAFKA-1351: Fabian, the `trace` call uses a by-name parameter

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2014-12-11 Thread Fabian Lange (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243223#comment-14243223 ] Fabian Lange commented on KAFKA-1351: - Hi, I was about to create a new issue, but figu

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2014-08-19 Thread Viktor Taranenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102729#comment-14102729 ] Viktor Taranenko commented on KAFKA-1351: - I was just comparing results in single

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2014-08-19 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102584#comment-14102584 ] Neha Narkhede commented on KAFKA-1351: -- Hey [~viktortnk], if you want to measure the

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2014-08-19 Thread Viktor Taranenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102466#comment-14102466 ] Viktor Taranenko commented on KAFKA-1351: - Sorry, to clarify, I mean testing Kafka

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2014-08-19 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102420#comment-14102420 ] Guozhang Wang commented on KAFKA-1351: -- I think a simple for-loop with log.[different

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2014-08-17 Thread Viktor Taranenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100131#comment-14100131 ] Viktor Taranenko commented on KAFKA-1351: - If I would to experiment a bit locally,

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2014-08-17 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100126#comment-14100126 ] Guozhang Wang commented on KAFKA-1351: -- In new clients, we are now using slf4j framew

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2014-08-17 Thread Viktor Taranenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099963#comment-14099963 ] Viktor Taranenko commented on KAFKA-1351: - I believe loggers already do lots of op

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2014-04-09 Thread Ivan Lyutov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964090#comment-13964090 ] Ivan Lyutov commented on KAFKA-1351: Updated reviewboard https://reviews.apache.org/r/

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2014-04-07 Thread Ivan Lyutov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961900#comment-13961900 ] Ivan Lyutov commented on KAFKA-1351: Updated reviewboard https://reviews.apache.org/r/

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2014-04-07 Thread Ivan Lyutov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961874#comment-13961874 ] Ivan Lyutov commented on KAFKA-1351: Created reviewboard https://reviews.apache.org/r/

[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala

2014-03-30 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954877#comment-13954877 ] Neha Narkhede commented on KAFKA-1351: -- It's worth cleaning up unnecessary logging fi