[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584156#comment-15584156 ] Nacho Solis commented on KAFKA-1351: Thanks [~jjkoshy]. Yes, this is a pet peeve of mine. Logging can be slow for many reasons. Not only is string formatting a performance hog; but even with lazy evaluation things will still take while when you use derived values. The newer versions of Scala provide a good alternative for this, macros. Coming from the C world I always find it surprising when the language (or pre-compiler) doesn't provide that type of functionality. Granted, it can make the code hard to follow if used incorrectly, but it can greatly simplify the code while still giving you the desired effect. We could write our own macro-logging layer or we can use something already out there like [scala-logging|https://github.com/typesafehub/scala-logging] which wraps SLF4J. It requires Scala 2.11 or higher. > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch, > KAFKA-1351_2014-04-09_15:40:11.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583851#comment-15583851 ] Joel Koshy commented on KAFKA-1351: --- Yes - this is still an issue. cc [~nsolis] > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch, > KAFKA-1351_2014-04-09_15:40:11.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15582973#comment-15582973 ] Andrew Musselman commented on KAFKA-1351: - Still open? > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch, > KAFKA-1351_2014-04-09_15:40:11.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513131#comment-14513131 ] Ismael Juma commented on KAFKA-1351: Personally, I think the right way to go is to use string interpolation (a Scala 2.10 feature) once we drop support for Scala 2.9. It's less error-prone (IDEs understand it and there are a number of lint tools that check that it's used correctly) and performs better. Of course, we should benchmark it before we use it. > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Fix For: 0.8.3 > > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch, > KAFKA-1351_2014-04-09_15:40:11.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14513096#comment-14513096 ] Neha Narkhede commented on KAFKA-1351: -- Not sure that this is still a concern. I was hoping whoever picks this up can do a quick microbenchmark to see if the suggestion in the description is really worth a change or not. > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Fix For: 0.8.3 > > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch, > KAFKA-1351_2014-04-09_15:40:11.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395970#comment-14395970 ] Jay Kreps commented on KAFKA-1351: -- [~nehanarkhede] is this still active? If not can we close it? > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Fix For: 0.8.3 > > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch, > KAFKA-1351_2014-04-09_15:40:11.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383501#comment-14383501 ] Fabian Lange commented on KAFKA-1351: - [~ijuma] thanks for the hint, i will double check why I saw calls in my profile. the synchronization remains but should be part of an other issue. > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Fix For: 0.8.3 > > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch, > KAFKA-1351_2014-04-09_15:40:11.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382919#comment-14382919 ] Ismael Juma commented on KAFKA-1351: Fabian, the `trace` call uses a by-name parameter, which means that the `format` call will only happen if `isTraceEnabled` is `true`. > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Fix For: 0.8.3 > > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch, > KAFKA-1351_2014-04-09_15:40:11.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243223#comment-14243223 ] Fabian Lange commented on KAFKA-1351: - Hi, I was about to create a new issue, but figured this might host the comment almost as good. As William outlined here: http://www.autoletics.com/posts/quick-performance-hotspot-analysis-apache-kafka the Log.append function (https://github.com/apache/kafka/blob/7847e9c703f3a0b70519666cdb8a6e4c8e37c3a7/core/src/main/scala/kafka/log/Log.scala#L230) is by far the biggest contributor to response time. There are a few reasons for this: A) it has a long synchronized block. I do not know much about the code, so at first glance I do not see much of an option to fix something B) it has a trace logging call. Not sure if that trace call needs to be in synchronized though. The trace call is implemented by https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/utils/Logging.scala#L34 As you might notice this does doe a slow String.format for trace. a log level which is very likely to be off. The above mentioned Log4j2 pattern would help there. However there are more options, like implemented by typesafe: https://github.com/typesafehub/scalalogging/tree/master/scalalogging-log4j/src/main/scala/com/typesafe/scalalogging/log4j they use a macro, which would transform the code so that the actual string format would be moved into the log level checking. I think thats quite nifty, but maybe too much work to integrate. So if you would check out that trace call, I would appreciate that :) > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Fix For: 0.8.3 > > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch, > KAFKA-1351_2014-04-09_15:40:11.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[
https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102729#comment-14102729
]
Viktor Taranenko commented on KAFKA-1351:
-
I was just comparing results in single thread using
Kafka logging + Util.formatString (from patch):
{code}
debug(Utils.formatString("Alive partitions for topic %s are %s ", "topic",
"partitions"))
{code}
Log4j2
{code}
log.debug("Alive partitions for topic {} are {}", "topic", "partitions")
{code}
and the log.info() alternative
While loggers were configured to only print INFO message into file
("logs/server.log")
logging 1 billion messages with debug level took
{noformat}
Kafka: 4.960845 seconds
Log4j2: 6.305278
{noformat}
So Kafka was 20% more efficient in that case
logging 10 million messages with info level:
{noformat}
Kafka: 57.440533 seconds
Log4j2: 12.903711 seconds
{noformat}
> String.format is very expensive in Scala
>
>
> Key: KAFKA-1351
> URL: https://issues.apache.org/jira/browse/KAFKA-1351
> Project: Kafka
> Issue Type: Bug
> Components: core
>Affects Versions: 0.7.2, 0.8.0, 0.8.1
>Reporter: Neha Narkhede
> Labels: newbie
> Fix For: 0.8.2
>
> Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch,
> KAFKA-1351_2014-04-09_15:40:11.patch
>
>
> As found in KAFKA-1350, logging is causing significant overhead in the
> performance of a Kafka server. There are several info statements that use
> String.format which is particularly expensive. We should investigate adding
> our own version of String.format that merely uses string concatenation under
> the covers.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102584#comment-14102584 ] Neha Narkhede commented on KAFKA-1351: -- Hey [~viktortnk], if you want to measure the log4j performance and compare it against different implementations of log4j, a simple stand alone test that uses log4j in a loop (like [~guozhang] described, is the right way to go. > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Fix For: 0.8.2 > > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch, > KAFKA-1351_2014-04-09_15:40:11.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102466#comment-14102466 ] Viktor Taranenko commented on KAFKA-1351: - Sorry, to clarify, I mean testing Kafka server (which currently uses log4j AFAIK) with different logging backend, not clients. Are there any existing benchmarking tools for Kafka server? > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Fix For: 0.8.2 > > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch, > KAFKA-1351_2014-04-09_15:40:11.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14102420#comment-14102420 ] Guozhang Wang commented on KAFKA-1351: -- I think a simple for-loop with log.[different-levels] would work here. > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Fix For: 0.8.2 > > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch, > KAFKA-1351_2014-04-09_15:40:11.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100131#comment-14100131 ] Viktor Taranenko commented on KAFKA-1351: - If I would to experiment a bit locally, what is the better way to compare the performance? > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Fix For: 0.8.2 > > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch, > KAFKA-1351_2014-04-09_15:40:11.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100126#comment-14100126 ] Guozhang Wang commented on KAFKA-1351: -- In new clients, we are now using slf4j framework, maybe we can let it port in log4j2 implementation and check performance difference. > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Fix For: 0.8.2 > > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch, > KAFKA-1351_2014-04-09_15:40:11.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[
https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14099963#comment-14099963
]
Viktor Taranenko commented on KAFKA-1351:
-
I believe loggers already do lots of optimisations for string concatenation.
I see kafka.util.Logging duplicates that functionality a lot
So when you write
{code}
logger.debug("Entry number: {} is {}", i, entry[i]);
{code}
it doesn't do any concatenation if debug level is not enabled (at least in
modern loggers).
http://logging.apache.org/log4j/2.x/performance.html
If logging is really a bottleneck in Kafka, you might consider upgrading
dependency to [log4j2|http://logging.apache.org/log4j/2.x/], which even has
async logging feature based on LMAX Disruptor. I has the similar bindings to
slf4j-api which Kafka currently use. Shouldn't be painful.
Consider http://logging.apache.org/log4j/2.x/manual/async.html
> String.format is very expensive in Scala
>
>
> Key: KAFKA-1351
> URL: https://issues.apache.org/jira/browse/KAFKA-1351
> Project: Kafka
> Issue Type: Bug
> Components: core
>Affects Versions: 0.7.2, 0.8.0, 0.8.1
>Reporter: Neha Narkhede
> Labels: newbie
> Fix For: 0.8.2
>
> Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch,
> KAFKA-1351_2014-04-09_15:40:11.patch
>
>
> As found in KAFKA-1350, logging is causing significant overhead in the
> performance of a Kafka server. There are several info statements that use
> String.format which is particularly expensive. We should investigate adding
> our own version of String.format that merely uses string concatenation under
> the covers.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964090#comment-13964090 ] Ivan Lyutov commented on KAFKA-1351: Updated reviewboard https://reviews.apache.org/r/20083/ against branch apache/trunk > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch, > KAFKA-1351_2014-04-09_15:40:11.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961900#comment-13961900 ] Ivan Lyutov commented on KAFKA-1351: Updated reviewboard https://reviews.apache.org/r/20083/ against branch apache/trunk > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Attachments: KAFKA-1351.patch, KAFKA-1351_2014-04-07_18:02:18.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13961874#comment-13961874 ] Ivan Lyutov commented on KAFKA-1351: Created reviewboard https://reviews.apache.org/r/20083/ against branch apache/trunk > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > Attachments: KAFKA-1351.patch > > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (KAFKA-1351) String.format is very expensive in Scala
[ https://issues.apache.org/jira/browse/KAFKA-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954877#comment-13954877 ] Neha Narkhede commented on KAFKA-1351: -- It's worth cleaning up unnecessary logging first. > String.format is very expensive in Scala > > > Key: KAFKA-1351 > URL: https://issues.apache.org/jira/browse/KAFKA-1351 > Project: Kafka > Issue Type: Bug > Components: core >Affects Versions: 0.7.2, 0.8.0, 0.8.1 >Reporter: Neha Narkhede > Labels: newbie > > As found in KAFKA-1350, logging is causing significant overhead in the > performance of a Kafka server. There are several info statements that use > String.format which is particularly expensive. We should investigate adding > our own version of String.format that merely uses string concatenation under > the covers. -- This message was sent by Atlassian JIRA (v6.2#6252)
