[jira] [Commented] (KAFKA-2607) Review `Time` interface and its usage
[
https://issues.apache.org/jira/browse/KAFKA-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583043#comment-15583043
]
Andrew Musselman commented on KAFKA-2607:
-
Looks like the PR has conflicts now; is this still in progress or is it still
blocked by KAFKA-2247?
> Review `Time` interface and its usage
> -
>
> Key: KAFKA-2607
> URL: https://issues.apache.org/jira/browse/KAFKA-2607
> Project: Kafka
> Issue Type: Improvement
>Affects Versions: 0.8.2.2
>Reporter: Ismael Juma
> Labels: newbie
>
> Two of `Time` interface's methods are `milliseconds` and `nanoseconds` which
> are implemented in `SystemTime` as follows:
> {code}
> @Override
> public long milliseconds() {
> return System.currentTimeMillis();
> }
> @Override
> public long nanoseconds() {
> return System.nanoTime();
> }
> {code}
> The issue with this interface is that it makes it seem that the difference is
> about the unit (`ms` versus `ns`) whereas it's much more than that:
> https://blogs.oracle.com/dholmes/entry/inside_the_hotspot_vm_clocks
> We should probably change the names of the methods and review our usage to
> see if we're using the right one in the various places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-2607) Review `Time` interface and its usage
[
https://issues.apache.org/jira/browse/KAFKA-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124297#comment-15124297
]
ASF GitHub Bot commented on KAFKA-2607:
---
GitHub user afine opened a pull request:
https://github.com/apache/kafka/pull/837
KAFKA-2607: Review `Time` interface and its usage
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afine/kafka KAFKA-2607
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/837.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #837
commit 311d4e06dbc3640d53c896edb23df5a8230df380
Author: Abraham Fine
Date: 2016-01-26T21:21:06Z
init
commit 871e2f0df2371546ec2e426c3e6d217ce03ac422
Author: Abraham Fine
Date: 2016-01-29T22:00:24Z
ashish's review
> Review `Time` interface and its usage
> -
>
> Key: KAFKA-2607
> URL: https://issues.apache.org/jira/browse/KAFKA-2607
> Project: Kafka
> Issue Type: Improvement
>Affects Versions: 0.8.2.2
>Reporter: Ismael Juma
> Labels: newbie
>
> Two of `Time` interface's methods are `milliseconds` and `nanoseconds` which
> are implemented in `SystemTime` as follows:
> {code}
> @Override
> public long milliseconds() {
> return System.currentTimeMillis();
> }
> @Override
> public long nanoseconds() {
> return System.nanoTime();
> }
> {code}
> The issue with this interface is that it makes it seem that the difference is
> about the unit (`ms` versus `ns`) whereas it's much more than that:
> https://blogs.oracle.com/dholmes/entry/inside_the_hotspot_vm_clocks
> We should probably change the names of the methods and review our usage to
> see if we're using the right one in the various places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (KAFKA-2607) Review `Time` interface and its usage
[
https://issues.apache.org/jira/browse/KAFKA-2607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941066#comment-14941066
]
Ismael Juma commented on KAFKA-2607:
We should probably do this after KAFKA-2606 to make the change simpler.
> Review `Time` interface and its usage
> -
>
> Key: KAFKA-2607
> URL: https://issues.apache.org/jira/browse/KAFKA-2607
> Project: Kafka
> Issue Type: Improvement
>Affects Versions: 0.8.2.2
>Reporter: Ismael Juma
> Labels: newbie
>
> Two of `Time` interface's methods are `milliseconds` and `nanoseconds` which
> are implemented in `SystemTime` as follows:
> {code}
> @Override
> public long milliseconds() {
> return System.currentTimeMillis();
> }
> @Override
> public long nanoseconds() {
> return System.nanoTime();
> }
> {code}
> The issue with this interface is that it makes it seem that the difference is
> about the unit (`ms` versus `ns`) whereas it's much more than that:
> https://blogs.oracle.com/dholmes/entry/inside_the_hotspot_vm_clocks
> We should probably change the names of the methods and review our usage to
> see if we're using the right one in the various places.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
