[jira] [Commented] (KAFKA-4598) Create new SourceTask commit callback method that takes offsets param

2017-01-06 Thread Shikhar Bhushan (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-4598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15805460#comment-15805460
 ] 

Shikhar Bhushan commented on KAFKA-4598:


Yeah, that's a reasonable alternative with the caveat you pointed out.

> Create new SourceTask commit callback method that takes offsets param
> -
>
> Key: KAFKA-4598
> URL: https://issues.apache.org/jira/browse/KAFKA-4598
> Project: Kafka
>  Issue Type: Improvement
>  Components: KafkaConnect
>Reporter: Shikhar Bhushan
>Assignee: Ewen Cheslack-Postava
>
> {{SourceTask.commit()}} can be invoked concurrently with a 
> {{SourceTask.poll()}} in progress. Thus it is currently not possible to know 
> what offset state the commit call corresponds to.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-4598) Create new SourceTask commit callback method that takes offsets param

2017-01-06 Thread Ewen Cheslack-Postava (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-4598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15805375#comment-15805375
 ] 

Ewen Cheslack-Postava commented on KAFKA-4598:
--

The alternative would be to synchronize them, right? Are we assuming this isn't 
reasonable since poll() can block indefinitely?

> Create new SourceTask commit callback method that takes offsets param
> -
>
> Key: KAFKA-4598
> URL: https://issues.apache.org/jira/browse/KAFKA-4598
> Project: Kafka
>  Issue Type: Improvement
>  Components: KafkaConnect
>Reporter: Shikhar Bhushan
>Assignee: Ewen Cheslack-Postava
>
> {{SourceTask.commit()}} can be invoked concurrently with a 
> {{SourceTask.poll()}} in progress. Thus it is currently not possible to know 
> what offset state the commit call corresponds to.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (KAFKA-4598) Create new SourceTask commit callback method that takes offsets param

2017-01-05 Thread Shikhar Bhushan (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-4598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802110#comment-15802110
 ] 

Shikhar Bhushan commented on KAFKA-4598:


In the meantime the workaround is to use 
{{SourceTask.commitRecord(SourceRecord)}} to keep track of committable offset 
state.

> Create new SourceTask commit callback method that takes offsets param
> -
>
> Key: KAFKA-4598
> URL: https://issues.apache.org/jira/browse/KAFKA-4598
> Project: Kafka
>  Issue Type: Improvement
>  Components: KafkaConnect
>Reporter: Shikhar Bhushan
>Assignee: Ewen Cheslack-Postava
>
> {{SourceTask.commit()}} can be invoked concurrently with a 
> {{SourceTask.poll()}} in progress. Thus it is currently not possible to know 
> what offset state the commit call corresponds to.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)