[jira] [Commented] (KAFKA-4622) KafkaConsumer does not properly handle authorization errors from offset fetches

2017-01-16 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823777#comment-15823777
 ] 

ASF GitHub Bot commented on KAFKA-4622:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/2384


> KafkaConsumer does not properly handle authorization errors from offset 
> fetches
> ---
>
> Key: KAFKA-4622
> URL: https://issues.apache.org/jira/browse/KAFKA-4622
> Project: Kafka
>  Issue Type: Bug
>  Components: consumer
>Affects Versions: 0.9.0.1, 0.10.0.1, 0.10.1.1
>Reporter: Jason Gustafson
>Assignee: Jason Gustafson
> Fix For: 0.10.2.0
>
>
> It's possible to receive both group and topic authorization exceptions from 
> an OffsetFetch, but the consumer currently treats this as generic unexpected 
> errors. We should probably return {{GroupAuthorizationException}} and 
> {{TopicAuthorizationException}} to be consistent with the other consumer 
> APIs. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-4622) KafkaConsumer does not properly handle authorization errors from offset fetches

2017-01-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823362#comment-15823362
 ] 

ASF GitHub Bot commented on KAFKA-4622:
---

GitHub user hachikuji opened a pull request:

https://github.com/apache/kafka/pull/2384

KAFKA-4622: Consumer should handle group authorization errors in offset 
fetch



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/hachikuji/kafka KAFKA-4622

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/2384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2384


commit 7e9f8f2e8d82988be09e7348b143600d3eb8765b
Author: Jason Gustafson 
Date:   2017-01-16T02:03:03Z

KAFKA-4622: Consumer should handle group authorization errors in offset 
fetch




> KafkaConsumer does not properly handle authorization errors from offset 
> fetches
> ---
>
> Key: KAFKA-4622
> URL: https://issues.apache.org/jira/browse/KAFKA-4622
> Project: Kafka
>  Issue Type: Bug
>  Components: consumer
>Affects Versions: 0.9.0.1, 0.10.0.1, 0.10.1.1
>Reporter: Jason Gustafson
>Assignee: Jason Gustafson
> Fix For: 0.10.2.0
>
>
> It's possible to receive both group and topic authorization exceptions from 
> an OffsetFetch, but the consumer currently treats this as generic unexpected 
> errors. We should probably return {{GroupAuthorizationException}} and 
> {{TopicAuthorizationException}} to be consistent with the other consumer 
> APIs. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-4622) KafkaConsumer does not properly handle authorization errors from offset fetches

2017-01-15 Thread Jason Gustafson (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15823361#comment-15823361
 ] 

Jason Gustafson commented on KAFKA-4622:


One correction to the description: Topic authorization errors are actually not 
possible in the OffsetFetch response. When the client does not have Describe 
access to the topic, we return {{UNKNOWN_TOPIC_OR_PARTITION}} to avoid leaking 
topic existence.

> KafkaConsumer does not properly handle authorization errors from offset 
> fetches
> ---
>
> Key: KAFKA-4622
> URL: https://issues.apache.org/jira/browse/KAFKA-4622
> Project: Kafka
>  Issue Type: Bug
>  Components: consumer
>Affects Versions: 0.9.0.1, 0.10.0.1, 0.10.1.1
>Reporter: Jason Gustafson
>Assignee: Jason Gustafson
> Fix For: 0.10.2.0
>
>
> It's possible to receive both group and topic authorization exceptions from 
> an OffsetFetch, but the consumer currently treats this as generic unexpected 
> errors. We should probably return {{GroupAuthorizationException}} and 
> {{TopicAuthorizationException}} to be consistent with the other consumer 
> APIs. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-4622) KafkaConsumer does not properly handle authorization errors from offset fetches

2017-01-13 Thread Jason Gustafson (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15822022#comment-15822022
 ] 

Jason Gustafson commented on KAFKA-4622:


[~ewencp] Should be an easy fix, so I was planning to get it into 0.10.2.0. I'm 
just awaiting KIP-88 since the patch would likely conflict.

> KafkaConsumer does not properly handle authorization errors from offset 
> fetches
> ---
>
> Key: KAFKA-4622
> URL: https://issues.apache.org/jira/browse/KAFKA-4622
> Project: Kafka
>  Issue Type: Bug
>  Components: consumer
>Affects Versions: 0.9.0.1, 0.10.0.1, 0.10.1.1
>Reporter: Jason Gustafson
>Assignee: Jason Gustafson
> Fix For: 0.10.2.0
>
>
> It's possible to receive both group and topic authorization exceptions from 
> an OffsetFetch, but the consumer currently treats this as generic unexpected 
> errors. We should probably return {{GroupAuthorizationException}} and 
> {{TopicAuthorizationException}} to be consistent with the other consumer 
> APIs. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (KAFKA-4622) KafkaConsumer does not properly handle authorization errors from offset fetches

2017-01-13 Thread Ewen Cheslack-Postava (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821415#comment-15821415
 ] 

Ewen Cheslack-Postava commented on KAFKA-4622:
--

[~hachikuji] You filed this 2 days ago and marked for 0.10.2.0 -- are you 
actually trying to get a patch in for this before release? It'd be fair to 
include in post feature-freeze fixes, but I want to get an idea of whether this 
is truly prioritized for the release (i.e. going to get a patch + committed in 
next couple of weeks) or if this is just aspirational.

> KafkaConsumer does not properly handle authorization errors from offset 
> fetches
> ---
>
> Key: KAFKA-4622
> URL: https://issues.apache.org/jira/browse/KAFKA-4622
> Project: Kafka
>  Issue Type: Bug
>  Components: consumer
>Affects Versions: 0.9.0.1, 0.10.0.1, 0.10.1.1
>Reporter: Jason Gustafson
>Assignee: Jason Gustafson
> Fix For: 0.10.2.0
>
>
> It's possible to receive both group and topic authorization exceptions from 
> an OffsetFetch, but the consumer currently treats this as generic unexpected 
> errors. We should probably return {{GroupAuthorizationException}} and 
> {{TopicAuthorizationException}} to be consistent with the other consumer 
> APIs. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)