答复: 答复: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-11 Thread Hu Xi
发件人: Mickael Maison <mickael.mai...@gmail.com> 发送时间: 2017年12月11日 18:17 收件人: dev@kafka.apache.org 主题: Re: 答复: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer Sorry to only raise this now, but should we also update the

Re: 答复: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-11 Thread Mickael Maison
Sorry to only raise this now, but should we also update the kafka-consumer-groups tool to display the start offset (and possibly the lead) ? Apart from that I'm +1 (non binding) Thanks On Mon, Dec 11, 2017 at 4:19 AM, Guozhang Wang wrote: > The by-laws ask for 72 hours only,

Re: 答复: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-10 Thread Guozhang Wang
The by-laws ask for 72 hours only, since the starting of the vote, and since you have three binding votes you can close this voting now. Please conclude by a summary of the voting status including non-binding and binding votes, thanks. Guozhang On Sun, Dec 10, 2017 at 8:10 PM, Hu Xi

答复: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-10 Thread Hu Xi
Hi all, Would we safely accept this KIP since three binding votes have already been collected (from Jun, Guozhang and Becket)? 发件人: Guozhang Wang 发送时间: 2017年12月6日 22:40 收件人: dev@kafka.apache.org 主题: Re: [VOTE] KIP-223 - Add per-topic min

Re: 答复: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-05 Thread Guozhang Wang
Hello Xi, You can see that in o.a.k.common.metrics.Sensor, we allow constructors to pass in one or more "parent" Sensors of the constructed Sensor, behind the scene when a child sensor's metrics have been updated, the updates will be propagated all the way up to its parents and ancestors (you can

答复: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-04 Thread Hu Xi
Guozhang, Thanks for the vote and comments. I am not sure if I fully understand the parent metrics here. This KIP will introduce a client-level metric named 'records-lead-min' and three per-partition metrics tagged with topic Is it the child-parent relationship you mean?