Re: How do I place a JIRA in status "Patch Available"? (For KAFKA-10473)

[John Roesler]

Thanks, James!

That change looks good to me.

-John

On Fri, 2020-09-11 at 15:54 -0700, James Cheng wrote:
> Thanks John! I can access and edit the wiki now.
> 
> And I improved the instructions for how to change the status of a JIRA to 
> "Patch Available". 
> https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=59689925=36=37
>  
> 
> 
> Thanks for the help,
> -James
> 
> > On Sep 11, 2020, at 12:53 PM, John Roesler  wrote:
> > 
> > Hi James,
> > 
> > Sorry, I overlooked your reply until now. I've granted you
> > access.
> > 
> > Thanks,
> > -John
> > 
> > On Wed, 2020-09-09 at 21:44 -0700, James Cheng wrote:
> > > Thanks John. My wiki user ID is wushujames 
> > > 
> > > -James
> > > 
> > > Sent from my iPhone
> > > 
> > > > On Sep 9, 2020, at 7:03 PM, John Roesler  wrote:
> > > > 
> > > > Hi James,
> > > > 
> > > > Good, I’m glad my incredibly vague response was helpful!
> > > > 
> > > > If you let me know your wiki user id, I can grant you edit permission. 
> > > > It’s a separate account from Jira. 
> > > > 
> > > > Thanks,
> > > > John
> > > > 
> > > > > On Wed, Sep 9, 2020, at 20:45, James Cheng wrote:
> > > > > Thanks John. That worked.
> > > > > 
> > > > > I clicked the button that says "Submit Patch", and a dialog box 
> > > > > popped 
> > > > > up. I didn't fill out anything additional in the dialog, and clicked 
> > > > > "Submit Patch" in the dialog.
> > > > > 
> > > > > The JIRA is now in status "Patch Available"
> > > > > 
> > > > > I would like to improve the docs at 
> > > > > https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
> > > > >  
> > > > > 
> > > > >  to make this step clearer. It looks like I don't have permissions to 
> > > > > edit the page.
> > > > > 
> > > > > Can someone grant me permissions to edit the page? 
> > > > > 
> > > > > Or, if that is too difficult, can someone edit the page as follows?
> > > > > 
> > > > > Change
> > > > > 
> > > > >   7. Change the status of the JIRA to "Patch Available" if it's ready 
> > > > > for review.
> > > > > to be
> > > > > 
> > > > >   7. Change the status of the JIRA to "Patch Available" if it's ready 
> > > > > for review. Do this by clicking the "Submit Patch" button in JIRA, 
> > > > > and 
> > > > > then in the resulting dialog, click "Submit Patch".
> > > > > 
> > > > > -James
> > > > > 
> > > > > > > On Sep 9, 2020, at 6:24 PM, John Roesler  
> > > > > > > wrote:
> > > > > > 
> > > > > > Hi James,
> > > > > > 
> > > > > > I think the button on Jira says “Add Patch” or something confusing 
> > > > > > like that. 
> > > > > > 
> > > > > > Thanks,
> > > > > > John
> > > > > > 
> > > > > > 
> > > > > > On Wed, Sep 9, 2020, at 17:34, James Cheng wrote:
> > > > > > > I have a JIRA that I am working on, and a pull request available 
> > > > > > > for it.
> > > > > > > 
> > > > > > > [KAFKA-10473] Website is missing docs on JMX metrics for 
> > > > > > > partition 
> > > > > > > size-on-disk (kafka.log:type=Log,name=*)
> > > > > > > https://issues.apache.org/jira/browse/KAFKA-10473
> > > > > > > https://github.com/apache/kafka/pull/9276
> > > > > > > 
> > > > > > > The "Contributing Code Changes" instructions say to
> > > > > > >   7. Change the status of the JIRA to "Patch Available" if it's 
> > > > > > > ready for review.
> > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
> > > > > > > 
> > > > > > > How do I do that? 
> > > > > > > * The title of my pull request starts with KAFKA-10473, so the 
> > > > > > > JIRA 
> > > > > > > does have a link to the pull request
> > > > > > > * I *was* able to assign it to myself and then say "Start 
> > > > > > > progress" and 
> > > > > > > now the status says "In Progress".
> > > > > > > * But I can't find how to set it to "Patch Available". In the 
> > > > > > > JIRA 
> > > > > > > website, I can't find a field or menu item that lets me change 
> > > > > > > the 
> > > > > > > status to "Patch Available" . 
> > > > > > > 
> > > > > > > Thanks,
> > > > > > > -James
> > > > > > > 
> > > > > > > 
> > > > > > > 

Re: How do I place a JIRA in status "Patch Available"? (For KAFKA-10473)

[James Cheng]

Thanks John! I can access and edit the wiki now.

And I improved the instructions for how to change the status of a JIRA to 
"Patch Available". 
https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=59689925=36=37
 


Thanks for the help,
-James

> On Sep 11, 2020, at 12:53 PM, John Roesler  wrote:
> 
> Hi James,
> 
> Sorry, I overlooked your reply until now. I've granted you
> access.
> 
> Thanks,
> -John
> 
> On Wed, 2020-09-09 at 21:44 -0700, James Cheng wrote:
>> Thanks John. My wiki user ID is wushujames 
>> 
>> -James
>> 
>> Sent from my iPhone
>> 
>>> On Sep 9, 2020, at 7:03 PM, John Roesler  wrote:
>>> 
>>> Hi James,
>>> 
>>> Good, I’m glad my incredibly vague response was helpful!
>>> 
>>> If you let me know your wiki user id, I can grant you edit permission. It’s 
>>> a separate account from Jira. 
>>> 
>>> Thanks,
>>> John
>>> 
 On Wed, Sep 9, 2020, at 20:45, James Cheng wrote:
 Thanks John. That worked.
 
 I clicked the button that says "Submit Patch", and a dialog box popped 
 up. I didn't fill out anything additional in the dialog, and clicked 
 "Submit Patch" in the dialog.
 
 The JIRA is now in status "Patch Available"
 
 I would like to improve the docs at 
 https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
  
 
  to make this step clearer. It looks like I don't have permissions to edit 
 the page.
 
 Can someone grant me permissions to edit the page? 
 
 Or, if that is too difficult, can someone edit the page as follows?
 
 Change
 
   7. Change the status of the JIRA to "Patch Available" if it's ready for 
 review.
 to be
 
   7. Change the status of the JIRA to "Patch Available" if it's ready 
 for review. Do this by clicking the "Submit Patch" button in JIRA, and 
 then in the resulting dialog, click "Submit Patch".
 
 -James
 
>> On Sep 9, 2020, at 6:24 PM, John Roesler  wrote:
> 
> Hi James,
> 
> I think the button on Jira says “Add Patch” or something confusing like 
> that. 
> 
> Thanks,
> John
> 
> 
> On Wed, Sep 9, 2020, at 17:34, James Cheng wrote:
>> I have a JIRA that I am working on, and a pull request available for it.
>> 
>> [KAFKA-10473] Website is missing docs on JMX metrics for partition 
>> size-on-disk (kafka.log:type=Log,name=*)
>> https://issues.apache.org/jira/browse/KAFKA-10473
>> https://github.com/apache/kafka/pull/9276
>> 
>> The "Contributing Code Changes" instructions say to
>>   7. Change the status of the JIRA to "Patch Available" if it's ready 
>> for review.
>> https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
>> 
>> How do I do that? 
>> * The title of my pull request starts with KAFKA-10473, so the JIRA 
>> does have a link to the pull request
>> * I *was* able to assign it to myself and then say "Start progress" and 
>> now the status says "In Progress".
>> * But I can't find how to set it to "Patch Available". In the JIRA 
>> website, I can't find a field or menu item that lets me change the 
>> status to "Patch Available" . 
>> 
>> Thanks,
>> -James
>> 
>> 
>> 
> 

Re: How do I place a JIRA in status "Patch Available"? (For KAFKA-10473)

[John Roesler]

Hi James,

Sorry, I overlooked your reply until now. I've granted you
access.

Thanks,
-John

On Wed, 2020-09-09 at 21:44 -0700, James Cheng wrote:
> Thanks John. My wiki user ID is wushujames 
> 
> -James
> 
> Sent from my iPhone
> 
> > On Sep 9, 2020, at 7:03 PM, John Roesler  wrote:
> > 
> > Hi James,
> > 
> > Good, I’m glad my incredibly vague response was helpful!
> > 
> > If you let me know your wiki user id, I can grant you edit permission. It’s 
> > a separate account from Jira. 
> > 
> > Thanks,
> > John
> > 
> > > On Wed, Sep 9, 2020, at 20:45, James Cheng wrote:
> > > Thanks John. That worked.
> > > 
> > > I clicked the button that says "Submit Patch", and a dialog box popped 
> > > up. I didn't fill out anything additional in the dialog, and clicked 
> > > "Submit Patch" in the dialog.
> > > 
> > > The JIRA is now in status "Patch Available"
> > > 
> > > I would like to improve the docs at 
> > > https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
> > >  
> > > 
> > >  to make this step clearer. It looks like I don't have permissions to 
> > > edit the page.
> > > 
> > > Can someone grant me permissions to edit the page? 
> > > 
> > > Or, if that is too difficult, can someone edit the page as follows?
> > > 
> > > Change
> > > 
> > >7. Change the status of the JIRA to "Patch Available" if it's ready 
> > > for review.
> > > to be
> > > 
> > >7. Change the status of the JIRA to "Patch Available" if it's ready 
> > > for review. Do this by clicking the "Submit Patch" button in JIRA, and 
> > > then in the resulting dialog, click "Submit Patch".
> > > 
> > > -James
> > > 
> > > > > On Sep 9, 2020, at 6:24 PM, John Roesler  wrote:
> > > > 
> > > > Hi James,
> > > > 
> > > > I think the button on Jira says “Add Patch” or something confusing like 
> > > > that. 
> > > > 
> > > > Thanks,
> > > > John
> > > > 
> > > > 
> > > > On Wed, Sep 9, 2020, at 17:34, James Cheng wrote:
> > > > > I have a JIRA that I am working on, and a pull request available for 
> > > > > it.
> > > > > 
> > > > > [KAFKA-10473] Website is missing docs on JMX metrics for partition 
> > > > > size-on-disk (kafka.log:type=Log,name=*)
> > > > > https://issues.apache.org/jira/browse/KAFKA-10473
> > > > > https://github.com/apache/kafka/pull/9276
> > > > > 
> > > > > The "Contributing Code Changes" instructions say to
> > > > >7. Change the status of the JIRA to "Patch Available" if it's 
> > > > > ready for review.
> > > > > https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
> > > > > 
> > > > > How do I do that? 
> > > > > * The title of my pull request starts with KAFKA-10473, so the JIRA 
> > > > > does have a link to the pull request
> > > > > * I *was* able to assign it to myself and then say "Start progress" 
> > > > > and 
> > > > > now the status says "In Progress".
> > > > > * But I can't find how to set it to "Patch Available". In the JIRA 
> > > > > website, I can't find a field or menu item that lets me change the 
> > > > > status to "Patch Available" . 
> > > > > 
> > > > > Thanks,
> > > > > -James
> > > > > 
> > > > > 
> > > > > 

Re: How do I place a JIRA in status "Patch Available"? (For KAFKA-10473)

[James Cheng]

Thanks John. My wiki user ID is wushujames 

-James

Sent from my iPhone

> On Sep 9, 2020, at 7:03 PM, John Roesler  wrote:
> 
> Hi James,
> 
> Good, I’m glad my incredibly vague response was helpful!
> 
> If you let me know your wiki user id, I can grant you edit permission. It’s a 
> separate account from Jira. 
> 
> Thanks,
> John
> 
>> On Wed, Sep 9, 2020, at 20:45, James Cheng wrote:
>> Thanks John. That worked.
>> 
>> I clicked the button that says "Submit Patch", and a dialog box popped 
>> up. I didn't fill out anything additional in the dialog, and clicked 
>> "Submit Patch" in the dialog.
>> 
>> The JIRA is now in status "Patch Available"
>> 
>> I would like to improve the docs at 
>> https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes 
>> 
>>  to make this step clearer. It looks like I don't have permissions to edit 
>> the page.
>> 
>> Can someone grant me permissions to edit the page? 
>> 
>> Or, if that is too difficult, can someone edit the page as follows?
>> 
>> Change
>> 
>>7. Change the status of the JIRA to "Patch Available" if it's ready for 
>> review.
>> to be
>> 
>>7. Change the status of the JIRA to "Patch Available" if it's ready 
>> for review. Do this by clicking the "Submit Patch" button in JIRA, and 
>> then in the resulting dialog, click "Submit Patch".
>> 
>> -James
>> 
 On Sep 9, 2020, at 6:24 PM, John Roesler  wrote:
>>> 
>>> Hi James,
>>> 
>>> I think the button on Jira says “Add Patch” or something confusing like 
>>> that. 
>>> 
>>> Thanks,
>>> John
>>> 
>>> 
>>> On Wed, Sep 9, 2020, at 17:34, James Cheng wrote:
 I have a JIRA that I am working on, and a pull request available for it.
 
 [KAFKA-10473] Website is missing docs on JMX metrics for partition 
 size-on-disk (kafka.log:type=Log,name=*)
 https://issues.apache.org/jira/browse/KAFKA-10473
 https://github.com/apache/kafka/pull/9276
 
 The "Contributing Code Changes" instructions say to
7. Change the status of the JIRA to "Patch Available" if it's ready for 
 review.
 https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
 
 How do I do that? 
 * The title of my pull request starts with KAFKA-10473, so the JIRA 
 does have a link to the pull request
 * I *was* able to assign it to myself and then say "Start progress" and 
 now the status says "In Progress".
 * But I can't find how to set it to "Patch Available". In the JIRA 
 website, I can't find a field or menu item that lets me change the 
 status to "Patch Available" . 
 
 Thanks,
 -James
 
 
 
>> 
>> 

Re: How do I place a JIRA in status "Patch Available"? (For KAFKA-10473)

[John Roesler]

Hi James,

Good, I’m glad my incredibly vague response was helpful!

If you let me know your wiki user id, I can grant you edit permission. It’s a 
separate account from Jira. 

Thanks,
John

On Wed, Sep 9, 2020, at 20:45, James Cheng wrote:
> Thanks John. That worked.
> 
> I clicked the button that says "Submit Patch", and a dialog box popped 
> up. I didn't fill out anything additional in the dialog, and clicked 
> "Submit Patch" in the dialog.
> 
> The JIRA is now in status "Patch Available"
> 
> I would like to improve the docs at 
> https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes 
>  
> to make this step clearer. It looks like I don't have permissions to edit the 
> page.
> 
> Can someone grant me permissions to edit the page? 
> 
> Or, if that is too difficult, can someone edit the page as follows?
> 
> Change
> 
>   7. Change the status of the JIRA to "Patch Available" if it's ready for 
> review.
> to be
> 
>   7. Change the status of the JIRA to "Patch Available" if it's ready 
> for review. Do this by clicking the "Submit Patch" button in JIRA, and 
> then in the resulting dialog, click "Submit Patch".
> 
> -James
> 
> > On Sep 9, 2020, at 6:24 PM, John Roesler  wrote:
> > 
> > Hi James,
> > 
> > I think the button on Jira says “Add Patch” or something confusing like 
> > that. 
> > 
> > Thanks,
> > John
> > 
> > 
> > On Wed, Sep 9, 2020, at 17:34, James Cheng wrote:
> >> I have a JIRA that I am working on, and a pull request available for it.
> >> 
> >> [KAFKA-10473] Website is missing docs on JMX metrics for partition 
> >> size-on-disk (kafka.log:type=Log,name=*)
> >> https://issues.apache.org/jira/browse/KAFKA-10473
> >> https://github.com/apache/kafka/pull/9276
> >> 
> >> The "Contributing Code Changes" instructions say to
> >>7. Change the status of the JIRA to "Patch Available" if it's ready for 
> >> review.
> >> https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
> >> 
> >> How do I do that? 
> >> * The title of my pull request starts with KAFKA-10473, so the JIRA 
> >> does have a link to the pull request
> >> * I *was* able to assign it to myself and then say "Start progress" and 
> >> now the status says "In Progress".
> >> * But I can't find how to set it to "Patch Available". In the JIRA 
> >> website, I can't find a field or menu item that lets me change the 
> >> status to "Patch Available" . 
> >> 
> >> Thanks,
> >> -James
> >> 
> >> 
> >> 
> 
>

Re: How do I place a JIRA in status "Patch Available"? (For KAFKA-10473)

[James Cheng]

Thanks John. That worked.

I clicked the button that says "Submit Patch", and a dialog box popped up. I 
didn't fill out anything additional in the dialog, and clicked "Submit Patch" 
in the dialog.

The JIRA is now in status "Patch Available"

I would like to improve the docs at 
https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes 
 
to make this step clearer. It looks like I don't have permissions to edit the 
page.

Can someone grant me permissions to edit the page? 

Or, if that is too difficult, can someone edit the page as follows?

Change

7. Change the status of the JIRA to "Patch Available" if it's ready for 
review.
to be

7. Change the status of the JIRA to "Patch Available" if it's ready for 
review. Do this by clicking the "Submit Patch" button in JIRA, and then in the 
resulting dialog, click "Submit Patch".

-James

> On Sep 9, 2020, at 6:24 PM, John Roesler  wrote:
> 
> Hi James,
> 
> I think the button on Jira says “Add Patch” or something confusing like that. 
> 
> Thanks,
> John
> 
> 
> On Wed, Sep 9, 2020, at 17:34, James Cheng wrote:
>> I have a JIRA that I am working on, and a pull request available for it.
>> 
>> [KAFKA-10473] Website is missing docs on JMX metrics for partition 
>> size-on-disk (kafka.log:type=Log,name=*)
>> https://issues.apache.org/jira/browse/KAFKA-10473
>> https://github.com/apache/kafka/pull/9276
>> 
>> The "Contributing Code Changes" instructions say to
>>  7. Change the status of the JIRA to "Patch Available" if it's ready for 
>> review.
>> https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
>> 
>> How do I do that? 
>> * The title of my pull request starts with KAFKA-10473, so the JIRA 
>> does have a link to the pull request
>> * I *was* able to assign it to myself and then say "Start progress" and 
>> now the status says "In Progress".
>> * But I can't find how to set it to "Patch Available". In the JIRA 
>> website, I can't find a field or menu item that lets me change the 
>> status to "Patch Available" . 
>> 
>> Thanks,
>> -James
>> 
>> 
>> 

Re: How do I place a JIRA in status "Patch Available"? (For KAFKA-10473)

[John Roesler]

Hi James,

I think the button on Jira says “Add Patch” or something confusing like that. 

Thanks,
John


On Wed, Sep 9, 2020, at 17:34, James Cheng wrote:
> I have a JIRA that I am working on, and a pull request available for it.
> 
> [KAFKA-10473] Website is missing docs on JMX metrics for partition 
> size-on-disk (kafka.log:type=Log,name=*)
> https://issues.apache.org/jira/browse/KAFKA-10473
> https://github.com/apache/kafka/pull/9276
> 
> The "Contributing Code Changes" instructions say to
>   7. Change the status of the JIRA to "Patch Available" if it's ready for 
> review.
> https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes
> 
> How do I do that? 
> * The title of my pull request starts with KAFKA-10473, so the JIRA 
> does have a link to the pull request
> * I *was* able to assign it to myself and then say "Start progress" and 
> now the status says "In Progress".
> * But I can't find how to set it to "Patch Available". In the JIRA 
> website, I can't find a field or menu item that lets me change the 
> status to "Patch Available" . 
> 
> Thanks,
> -James
> 
> 
>

How do I place a JIRA in status "Patch Available"? (For KAFKA-10473)

[James Cheng]

I have a JIRA that I am working on, and a pull request available for it.

[KAFKA-10473] Website is missing docs on JMX metrics for partition size-on-disk 
(kafka.log:type=Log,name=*)
https://issues.apache.org/jira/browse/KAFKA-10473
https://github.com/apache/kafka/pull/9276

The "Contributing Code Changes" instructions say to
7. Change the status of the JIRA to "Patch Available" if it's ready for 
review.
https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes

How do I do that? 
* The title of my pull request starts with KAFKA-10473, so the JIRA does have a 
link to the pull request
* I *was* able to assign it to myself and then say "Start progress" and now the 
status says "In Progress".
* But I can't find how to set it to "Patch Available". In the JIRA website, I 
can't find a field or menu item that lets me change the status to "Patch 
Available" . 

Thanks,
-James