Re: [DISCUSS] KIP-186: Increase offsets retention default to 7 days

2018-03-05 Thread Ewen Cheslack-Postava
Reviving this thread. @Stevo I think there are more refinements we can make, but I'd like to get at least this pushed through because this keeps biting people unexpectedly. How about we bump the default now just to address the immediate issue and we can follow up with additional refinements in

Re: [DISCUSS] KIP-186: Increase offsets retention default to 7 days

2017-10-06 Thread Manikumar
looks like VOTE thread is *NOT* started for this KIP. On Fri, Oct 6, 2017 at 11:23 PM, Manikumar wrote: > looks like VOTE thread is started for this KIP. > > > On Wed, Aug 16, 2017 at 5:39 PM, Stevo Slavić wrote: > >> +1 for making consistent

Re: [DISCUSS] KIP-186: Increase offsets retention default to 7 days

2017-10-06 Thread Ted Yu
+1 on the KIP. bq. introducing offsets.retention.hours config property Probably the introduction would cause confusion among users due to the existing minutes config. On Fri, Oct 6, 2017 at 10:53 AM, Manikumar wrote: > looks like VOTE thread is started for this KIP.

Re: [DISCUSS] KIP-186: Increase offsets retention default to 7 days

2017-10-06 Thread Manikumar
looks like VOTE thread is started for this KIP. On Wed, Aug 16, 2017 at 5:39 PM, Stevo Slavić wrote: > +1 for making consistent default log and offsets retention time. > I like Stephane's suggestion too, log retention override should override > offset retention too if not

Re: [DISCUSS] KIP-186: Increase offsets retention default to 7 days

2017-08-16 Thread Stevo Slavić
+1 for making consistent default log and offsets retention time. I like Stephane's suggestion too, log retention override should override offset retention too if not explicitly configured. Please consider additionally: - introducing offsets.retention.hours config property - syncing log and

Re: [DISCUSS] KIP-186: Increase offsets retention default to 7 days

2017-08-10 Thread Guozhang Wang
+1 from me On Wed, Aug 9, 2017 at 9:40 AM, Jason Gustafson wrote: > +1 on the bump to 7 days. Wanted to mention one minor point. The > OffsetCommit RPC still provides the ability to set the retention time from > the client, but we do not use it in the consumer. Should we

Re: [DISCUSS] KIP-186: Increase offsets retention default to 7 days

2017-08-10 Thread James Cheng
+1 from me! -James > On Aug 8, 2017, at 5:24 PM, Ewen Cheslack-Postava wrote: > > Hi all, > > I posted a simple new KIP for a problem we see with a lot of users: > KIP-186: Increase offsets retention default to 7 days > >

Re: [DISCUSS] KIP-186: Increase offsets retention default to 7 days

2017-08-10 Thread Vahid S Hashemian
+1 on both the KIP and Jason's suggestion of adding the consumer config. Thanks. --Vahid From: Jason Gustafson <ja...@confluent.io> To: dev@kafka.apache.org Date: 08/09/2017 09:40 AM Subject: Re: [DISCUSS] KIP-186: Increase offsets retention default to 7 days +1 on th

Re: [DISCUSS] KIP-186: Increase offsets retention default to 7 days

2017-08-09 Thread Stephane Maarek
Any interest on having offsets.retention.minutes= log.retention.(ms|minutes|hours) as a dynamic setting if not set, and having the option the override to a constant value? That would address different types of deployments as well, who modify the default log retention period On 10/8/17, 5:11

Re: [DISCUSS] KIP-186: Increase offsets retention default to 7 days

2017-08-09 Thread Apurva Mehta
Thanks for the KIP. +1 from me. On Tue, Aug 8, 2017 at 5:24 PM, Ewen Cheslack-Postava wrote: > Hi all, > > I posted a simple new KIP for a problem we see with a lot of users: > KIP-186: Increase offsets retention default to 7 days > >

Re: [DISCUSS] KIP-186: Increase offsets retention default to 7 days

2017-08-09 Thread Jason Gustafson
+1 on the bump to 7 days. Wanted to mention one minor point. The OffsetCommit RPC still provides the ability to set the retention time from the client, but we do not use it in the consumer. Should we consider adding a consumer config to set this? Given the problems people had with the old default,

Re: [DISCUSS] KIP-186: Increase offsets retention default to 7 days

2017-08-09 Thread Sönke Liebau
Just had this create issues at a customer as well, +1 On Wed, Aug 9, 2017 at 11:46 AM, Mickael Maison wrote: > Yes the current default is too short, +1 > > On Wed, Aug 9, 2017 at 8:56 AM, Ismael Juma wrote: > > Thanks for the KIP, +1 from me. > > >

Re: [DISCUSS] KIP-186: Increase offsets retention default to 7 days

2017-08-09 Thread Mickael Maison
Yes the current default is too short, +1 On Wed, Aug 9, 2017 at 8:56 AM, Ismael Juma wrote: > Thanks for the KIP, +1 from me. > > Ismael > > On Wed, Aug 9, 2017 at 1:24 AM, Ewen Cheslack-Postava > wrote: > >> Hi all, >> >> I posted a simple new KIP for a

Re: [DISCUSS] KIP-186: Increase offsets retention default to 7 days

2017-08-09 Thread Ismael Juma
Thanks for the KIP, +1 from me. Ismael On Wed, Aug 9, 2017 at 1:24 AM, Ewen Cheslack-Postava wrote: > Hi all, > > I posted a simple new KIP for a problem we see with a lot of users: > KIP-186: Increase offsets retention default to 7 days > >