Re: [DISCUSSION] Upgrade system tests to python 3

2020-10-08 Thread Nikolay Izhikov
Guozhang and all others who involved. Thanks for your help! > 7 окт. 2020 г., в 19:42, Guozhang Wang написал(а): > > Hello Nikolay, > > I've merged the PR to trunk. Thanks for your huge effort and patience going > through the review! > > Guozhang > > On Wed, Oct 7, 2020 at 6:52 AM Nikolay

Re: [DISCUSSION] Upgrade system tests to python 3

2020-10-07 Thread Guozhang Wang
Hello Nikolay, I've merged the PR to trunk. Thanks for your huge effort and patience going through the review! Guozhang On Wed, Oct 7, 2020 at 6:52 AM Nikolay Izhikov wrote: > Great news! > Thanks Magnus! > > I’ve updated the PR. > > Looks like we ready to merge it. > > > 7 окт. 2020 г., в

Re: [DISCUSSION] Upgrade system tests to python 3

2020-10-07 Thread Nikolay Izhikov
Great news! Thanks Magnus! I’ve updated the PR. Looks like we ready to merge it. > 7 окт. 2020 г., в 15:29, Magnus Edenhill написал(а): > > Hi, > > ducktape v0.8.0 is now released. > > Regards, > Magnus > > > Den ons 7 okt. 2020 kl 10:50 skrev Nikolay Izhikov : > >> Hello. >> >> Got 4

Re: [DISCUSSION] Upgrade system tests to python 3

2020-10-07 Thread Magnus Edenhill
Hi, ducktape v0.8.0 is now released. Regards, Magnus Den ons 7 okt. 2020 kl 10:50 skrev Nikolay Izhikov : > Hello. > > Got 4 approvals for PR [1] > The only thing we need to be able to merge it is a ducktape 0.8 release. > If ducktape team need any help with the release, please, let me know.

Re: [DISCUSSION] Upgrade system tests to python 3

2020-10-07 Thread Nikolay Izhikov
Hello. Got 4 approvals for PR [1] The only thing we need to be able to merge it is a ducktape 0.8 release. If ducktape team need any help with the release, please, let me know. [1] https://github.com/apache/kafka/pull/9196 > 21 сент. 2020 г., в 12:58, Nikolay Izhikov > написал(а): > >

Re: [DISCUSSION] Upgrade system tests to python 3

2020-09-21 Thread Nikolay Izhikov
Hello. I fixed two system tests that fails in trunk, also. streams_upgrade_test.py::StreamsUpgradeTest.test_version_probing_upgrade streams_static_membership_test.py Please, take a look at my PR [1] [1] https://github.com/apache/kafka/pull/9312 > 20 сент. 2020 г., в 06:11, Guozhang Wang

Re: [DISCUSSION] Upgrade system tests to python 3

2020-09-19 Thread Guozhang Wang
I've triggered a system test on top of your branch. Maybe you could also re-run the jenkins unit tests since currently all of them fails but you've only touched on system tests, so I'd like to confirm at least one successful run. On Wed, Sep 16, 2020 at 3:37 AM Nikolay Izhikov wrote: > Hello,

Re: [DISCUSSION] Upgrade system tests to python 3

2020-09-16 Thread Nikolay Izhikov
Hello, Guozhang. > I can help run the test suite once your PR is cleanly rebased to verify the > whole suite works Thank you for joining to the review. 1. PR rebased on the current trunk. 2. I triggered all tests in my private environment to verify them after rebase. Will inform you

Re: [DISCUSSION] Upgrade system tests to python 3

2020-09-15 Thread Guozhang Wang
Hello Nikolay, I can help run the test suite once your PR is cleanly rebased to verify the whole suite works and then I can merge (I'm trusting Ivan and Magnus here for their reviews :) Guozhang On Mon, Sep 14, 2020 at 3:56 AM Nikolay Izhikov wrote: > Hello! > > I got 2 approvals from Ivan

Re: [DISCUSSION] Upgrade system tests to python 3

2020-09-14 Thread Nikolay Izhikov
Hello! I got 2 approvals from Ivan Daschinskiy and Magnus Edenhill. Committers, please, join the review. > 3 сент. 2020 г., в 11:06, Nikolay Izhikov написал(а): > > Hello! > > Just a friendly reminder. > > Patch to resolve some kind of technical debt - python2 in system tests is > ready! >

Re: [DISCUSSION] Upgrade system tests to python 3

2020-09-03 Thread Nikolay Izhikov
Hello! Just a friendly reminder. Patch to resolve some kind of technical debt - python2 in system tests is ready! Can someone, please, take a look? https://github.com/apache/kafka/pull/9196 > 28 авг. 2020 г., в 11:19, Nikolay Izhikov написал(а): > > Hello! > > Any feedback on this? > What

Re: [DISCUSSION] Upgrade system tests to python 3

2020-08-28 Thread Nikolay Izhikov
Hello! Any feedback on this? What I should additionally do to prepare system tests migration? > 24 авг. 2020 г., в 11:17, Nikolay Izhikov написал(а): > > Hello. > > PR [1] is ready. > Please, review. > > But, I need help with the two following questions: > > 1. We need a new release of

Re: [DISCUSSION] Upgrade system tests to python 3

2020-08-24 Thread Nikolay Izhikov
Hello. PR [1] is ready. Please, review. But, I need help with the two following questions: 1. We need a new release of ducktape which includes fixes [2], [3] for python3. I created the issue in ducktape repo [4]. Can someone help me with the release? 2. I know that some companies run system

Re: [DISCUSSION] Upgrade system tests to python 3

2020-08-14 Thread Ismael Juma
+1 On Fri, Aug 14, 2020 at 7:42 AM John Roesler wrote: > Thanks Nikolay, > > No objection. This would be very nice to have. > > Thanks, > John > > On Fri, Aug 14, 2020, at 09:18, Nikolay Izhikov wrote: > > Hello. > > > > > If anyone's interested in porting it to Python 3 it would be a good >

Re: [DISCUSSION] Upgrade system tests to python 3

2020-08-14 Thread John Roesler
Thanks Nikolay, No objection. This would be very nice to have. Thanks, John On Fri, Aug 14, 2020, at 09:18, Nikolay Izhikov wrote: > Hello. > > > If anyone's interested in porting it to Python 3 it would be a good change. > > I’ve created a ticket [1] to upgrade system tests to python3. >