Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL

-- >> > >> > Edoardo Comar >> > >> > IBM Message Hub >> > >> > IBM UK Ltd, Hursley Park, SO21 2JN >> > >> > >> > >> > From: Jason Gustafson <ja...@confluent.io> >> >

Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL

; > attributes without the hacks we're doing today :-) > > > > cheers > > -- > > > > Edoardo Comar > > > > IBM Message Hub > > > > IBM UK Ltd, Hursley Park, SO21 2JN > > > > > > > > From: Jason Gustafson <ja...

Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL

v@kafka.apache.org > Date: 07/09/2017 17:23 > Subject: Re: [VOTE] KIP-189 - Improve principal builder interface > and add support for SASL > > > > I am closing the vote. Here are the totals: > > Binding: Ismael, Rajini, Jun, (Me) > Non-binding: Mayuresh,

Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL

-- Edoardo Comar IBM Message Hub IBM UK Ltd, Hursley Park, SO21 2JN From: Jason Gustafson <ja...@confluent.io> To: dev@kafka.apache.org Date: 07/09/2017 17:23 Subject: Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL I am c

Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL

I am closing the vote. Here are the totals: Binding: Ismael, Rajini, Jun, (Me) Non-binding: Mayuresh, Manikumar, Mickael Thanks all for the reviews! On Wed, Sep 6, 2017 at 2:22 PM, Jason Gustafson wrote: > Hi All, > > When implementing this, I found that the

Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL

Hi All, When implementing this, I found that the SecurityProtocol class has some internal details which we might not want to expose to users (in particular to enable testing). Since it's still useful to know the security protocol in use in some cases, and since the security protocol names are

Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL

Thanks for the KIP, +1 (binding). Ismael On Wed, Aug 30, 2017 at 4:51 PM, Jason Gustafson wrote: > I'd like to open the vote for KIP-189: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 189%3A+Improve+principal+builder+interface+and+add+support+for+SASL. > Thanks

Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL

+1 (binding) Thank you for the KIP, Jason. On Thu, Aug 31, 2017 at 8:33 PM, Mickael Maison wrote: > +1 (non binding) > > Thanks for the KIP > > On Thu, Aug 31, 2017 at 10:10 AM, Jun Rao wrote: > > That's also fine as long as it's documented in the

Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL

+1 (non binding) Thanks for the KIP On Thu, Aug 31, 2017 at 10:10 AM, Jun Rao wrote: > That's also fine as long as it's documented in the interface somehow. The > only thing with java Closeable is that it throws IOException. In most of > our usage, we use close() with no

Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL

That's also fine as long as it's documented in the interface somehow. The only thing with java Closeable is that it throws IOException. In most of our usage, we use close() with no exception since it's not clear what you will do when an exception is thrown in close(). Thanks, Jun On Thu, Aug

Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL

Hey Jun, I will add a note to the KIP, but my plan was to dynamically check whether the KafkaPrincipalBuilder implemented Configurable or Closeable. That makes implementing close() and configure() optional. Does that seem reasonable? -Jason On Thu, Aug 31, 2017 at 9:53 AM, Jun Rao

Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL

Hi, Jason, Thanks for the KIP. +1. Just one minor comment. It seems that the new KafkaPrincipalBuilder interface should support Configurable and close() as the existing PrincipalBuilder? Jun On Wed, Aug 30, 2017 at 8:51 AM, Jason Gustafson wrote: > I'd like to open the

Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL

+1 (non-binding). On Wed, Aug 30, 2017 at 9:29 PM, Mayuresh Gharat wrote: > +1 (non-binding) > > Thanks, > > Mayuresh > > On Wed, Aug 30, 2017 at 8:51 AM, Jason Gustafson > wrote: > > > I'd like to open the vote for KIP-189: > >

Re: [VOTE] KIP-189 - Improve principal builder interface and add support for SASL

+1 (non-binding) Thanks, Mayuresh On Wed, Aug 30, 2017 at 8:51 AM, Jason Gustafson wrote: > I'd like to open the vote for KIP-189: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 189%3A+Improve+principal+builder+interface+and+add+support+for+SASL. > Thanks to