Re: [VOTE] KIP-244: Add Record Header support to Kafka Streams

Hi, I'd like to point out that: org.apache.kafka.streams.test.ConsumerRecordFactory Has also been included as part of this KIP to support changes on test cases, just in case there is additional feedback here. Cheers, Jorge. El lun., 21 may. 2018 a las 16:46, Jorge Esteban Quilcate Otoya (<

Re: [VOTE] KIP-244: Add Record Header support to Kafka Streams

Thanks for your votes and your feedback. This KIP has been approved with the following results: Binding +1s: 3 (Matthias, Damina, Guozhang) Non-biniding +1s: (Bill, Ted) Jorge. El mar., 15 may. 2018 a las 20:01, Bill Bejeck () escribió: > Thanks for the KIP! > > +1 > >

Re: [VOTE] KIP-244: Add Record Header support to Kafka Streams

Thanks for the KIP! +1 -Bill On Tue, May 15, 2018 at 1:47 PM, Damian Guy wrote: > Thanks. +1 (binding) > > On Tue, 15 May 2018 at 01:04 Jorge Esteban Quilcate Otoya < > quilcate.jo...@gmail.com> wrote: > > > @Guozhang added. Thanks! > > > > El mar., 15 may. 2018 a las

Re: [VOTE] KIP-244: Add Record Header support to Kafka Streams

Thanks. +1 (binding) On Tue, 15 May 2018 at 01:04 Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > @Guozhang added. Thanks! > > El mar., 15 may. 2018 a las 5:50, Matthias J. Sax ( >) > escribió: > > > +1 (binding) > > > > Thanks a lot for the KIP! > > > >

Re: [VOTE] KIP-244: Add Record Header support to Kafka Streams

@Guozhang added. Thanks! El mar., 15 may. 2018 a las 5:50, Matthias J. Sax () escribió: > +1 (binding) > > Thanks a lot for the KIP! > > -Matthias > > On 5/14/18 10:17 AM, Guozhang Wang wrote: > > +1 from me > > > > One more comment on the wiki: while reviewing the PR I

Re: [VOTE] KIP-244: Add Record Header support to Kafka Streams

+1 (binding) Thanks a lot for the KIP! -Matthias On 5/14/18 10:17 AM, Guozhang Wang wrote: > +1 from me > > One more comment on the wiki: while reviewing the PR I realized that in ` > MockProcessorContext.java >

Re: [VOTE] KIP-244: Add Record Header support to Kafka Streams

+1 from me One more comment on the wiki: while reviewing the PR I realized that in ` MockProcessorContext.java ` we are also adding one additional API plus modifying the existing `setRecordMetadata` API. Since

Re: [VOTE] KIP-244: Add Record Header support to Kafka Streams

+1 On Mon, May 14, 2018 at 8:31 AM, Jorge Esteban Quilcate Otoya < quilcate.jo...@gmail.com> wrote: > Hi everyone, > > I would like to start a vote on KIP-244: Add Record Header support to Kafka > Streams > > KIP wiki page: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- >