Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

2019-09-20 Thread David Jacot
Great. I have updated the KIP. Thanks, David On Thu, Sep 19, 2019 at 10:56 PM Colin McCabe wrote: > Sounds good to me. It makes sense to add this functionality to the > command line. > > best, > Colin > > On Wed, Sep 18, 2019, at 11:26, David Jacot wrote: > > Indeed, I have forgotten to add th

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

2019-09-19 Thread Colin McCabe
Sounds good to me. It makes sense to add this functionality to the command line. best, Colin On Wed, Sep 18, 2019, at 11:26, David Jacot wrote: > Indeed, I have forgotten to add the action. There will be a new action « > —delete-offsets ». Sorry! > > *Proposed API* > kafka-consumer-groups.sh

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

2019-09-18 Thread David Jacot
Indeed, I have forgotten to add the action. There will be a new action « —delete-offsets ». Sorry! *Proposed API* kafka-consumer-groups.sh --bootstrap-server —delete-offsets --group --topic : ex: --bootstrap-server localhost:9092 --group my-group --topic topic1 --topic topic2:0,1,2 When partit

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

2019-09-18 Thread Colin McCabe
On Tue, Sep 17, 2019, at 09:07, David Jacot wrote: > Hi all, > > We haven't included the changes in the command line tool to support the new > API. Therefore, > I would like to amend the current KIP to cover the changes in the > `kafka-consumer-groups` > command line tool. The change is rather sma

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

2019-09-17 Thread David Jacot
Hi all, We haven't included the changes in the command line tool to support the new API. Therefore, I would like to amend the current KIP to cover the changes in the `kafka-consumer-groups` command line tool. The change is rather small and it does not need to add any new arguments to the command l

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

2019-09-13 Thread Colin McCabe
Hi David, Sounds good. best, Colin On Fri, Sep 13, 2019, at 04:45, David Jacot wrote: > Hi all, > > I would like to do another modification to the proposal. In the proposal, > the OffsetDeleteResponse > doesn't have a top level error field so I would like to add one. Many > errors concern the

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

2019-09-13 Thread David Jacot
Hi all, I would like to do another modification to the proposal. In the proposal, the OffsetDeleteResponse doesn't have a top level error field so I would like to add one. Many errors concern the whole group (e.g. GROUP_ID_NOT_FOUND) so it would be great to have a way to communicate them back to t

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

2019-09-04 Thread David Jacot
Hi all, While implementing the KIP, I have realized that a new error code and exception is required to notify the caller that offsets of a topic can not be deleted because the group is actively subscribed to the topic. I would like to know if there are any concerns with these changes before updat

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

2019-08-16 Thread Mickael Maison
+1 (non binding) Thanks! On Thu, Aug 15, 2019 at 11:53 PM Colin McCabe wrote: > > On Thu, Aug 15, 2019, at 11:47, Jason Gustafson wrote: > > Hey Colin, I think deleting all offsets is equivalent to deleting the > > group, which can be done with the `deleteConsumerGroups` api. I debated > > whethe

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

2019-08-15 Thread Colin McCabe
On Thu, Aug 15, 2019, at 11:47, Jason Gustafson wrote: > Hey Colin, I think deleting all offsets is equivalent to deleting the > group, which can be done with the `deleteConsumerGroups` api. I debated > whether there should be a way to delete partitions for all unsubscribed > topics, but I decided

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

2019-08-15 Thread Jason Gustafson
Hey Colin, I think deleting all offsets is equivalent to deleting the group, which can be done with the `deleteConsumerGroups` api. I debated whether there should be a way to delete partitions for all unsubscribed topics, but I decided to start with a simple API. I'm going to close this vote. The

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

2019-08-13 Thread Colin McCabe
Hi Jason, Thanks for the KIP. Is there ever a desire to delete all the offsets for a given group? Should the protocol and tools support this? +1 (binding) best, Colin On Mon, Aug 12, 2019, at 10:57, Guozhang Wang wrote: > +1 (binding). > > Thanks Jason! > > On Wed, Aug 7, 2019 at 11:18 AM

Re: [VOTE] KIP-496: Administrative API to delete consumer offsets

2019-08-12 Thread Guozhang Wang
+1 (binding). Thanks Jason! On Wed, Aug 7, 2019 at 11:18 AM Jason Gustafson wrote: > Hi All, > > I'd like to start a vote on KIP-496: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-496%3A+Administrative+API+to+delete+consumer+offsets > . > +1 > from me of course. > > -Jason > -- -