Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
Thank you to all that voted. I have 4 binding votes and 4 non-binding votes. I will begin work on this KIP soon. Thanks, Sanjana On Mar 26, 2020, 3:03 PM -0700, Konstantine Karantasis , wrote: > Thank you Sanjana! > > +1 (binding) from me too. > > Konstantine > > > On Wed, Mar 25, 2020 at 1:57 PM Sanjana Kaundinya > wrote: > > > Hi Konstantine, > > > > Thanks for the feedback, I have addressed it on the [DISCUSS] thread and > > will update the KIP shortly. > > > > Thanks, > > Sanjana > > On Mar 25, 2020, 10:52 AM -0700, Konstantine Karantasis < > > konstant...@confluent.io>, wrote: > > > Hi Sanjana. > > > Thanks for the KIP! Seems quite useful not to overwhelm the brokers with > > > the described requests from clients. > > > > > > You have the votes already, and I'm also in favor overall, but I've made > > a > > > couple of questions (sorry for the delay) regarding Connect, which is > > also > > > using retry.backoff.ms but currently is not mentioned in the KIP, as > > well > > > as a question around how we expect the new setting to work with > > rebalances > > > in clients that inherit from the AbstractCoordinator (Consumer and > > Connect > > > at a minimum). > > > > > > Maybe it's worth clarifying these points in the KIP, or the mailing list > > > thread in case I missed something w/r/t the intent of the changes. > > > > > > Best, > > > Konstantine > > > > > > > > > On Tue, Mar 24, 2020 at 9:42 PM David Jacot wrote: > > > > > > > +1 (non-binding) > > > > > > > > Thanks for the KIP, great improvement! > > > > > > > > Le mer. 25 mars 2020 à 04:44, Gwen Shapira a > > écrit : > > > > > > > > > +1 (binding) - thank you > > > > > > > > > > On Mon, Mar 23, 2020, 10:50 AM Sanjana Kaundinya < > > skaundi...@gmail.com> > > > > > wrote: > > > > > > > > > > > Hi Everyone, > > > > > > > > > > > > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka > > > > > > Clients. The link to the KIP can be found here: > > > > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients > > > > > > . > > > > > > > > > > > > Thanks, > > > > > > Sanjana > > > > > > > > > > > > > > > > > > > > > > >
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
Thank you Sanjana! +1 (binding) from me too. Konstantine On Wed, Mar 25, 2020 at 1:57 PM Sanjana Kaundinya wrote: > Hi Konstantine, > > Thanks for the feedback, I have addressed it on the [DISCUSS] thread and > will update the KIP shortly. > > Thanks, > Sanjana > On Mar 25, 2020, 10:52 AM -0700, Konstantine Karantasis < > konstant...@confluent.io>, wrote: > > Hi Sanjana. > > Thanks for the KIP! Seems quite useful not to overwhelm the brokers with > > the described requests from clients. > > > > You have the votes already, and I'm also in favor overall, but I've made > a > > couple of questions (sorry for the delay) regarding Connect, which is > also > > using retry.backoff.ms but currently is not mentioned in the KIP, as > well > > as a question around how we expect the new setting to work with > rebalances > > in clients that inherit from the AbstractCoordinator (Consumer and > Connect > > at a minimum). > > > > Maybe it's worth clarifying these points in the KIP, or the mailing list > > thread in case I missed something w/r/t the intent of the changes. > > > > Best, > > Konstantine > > > > > > On Tue, Mar 24, 2020 at 9:42 PM David Jacot wrote: > > > > > +1 (non-binding) > > > > > > Thanks for the KIP, great improvement! > > > > > > Le mer. 25 mars 2020 à 04:44, Gwen Shapira a > écrit : > > > > > > > +1 (binding) - thank you > > > > > > > > On Mon, Mar 23, 2020, 10:50 AM Sanjana Kaundinya < > skaundi...@gmail.com> > > > > wrote: > > > > > > > > > Hi Everyone, > > > > > > > > > > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka > > > > > Clients. The link to the KIP can be found here: > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients > > > > > . > > > > > > > > > > Thanks, > > > > > Sanjana > > > > > > > > > > > > > > > > > >
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
Hi Konstantine, Thanks for the feedback, I have addressed it on the [DISCUSS] thread and will update the KIP shortly. Thanks, Sanjana On Mar 25, 2020, 10:52 AM -0700, Konstantine Karantasis , wrote: > Hi Sanjana. > Thanks for the KIP! Seems quite useful not to overwhelm the brokers with > the described requests from clients. > > You have the votes already, and I'm also in favor overall, but I've made a > couple of questions (sorry for the delay) regarding Connect, which is also > using retry.backoff.ms but currently is not mentioned in the KIP, as well > as a question around how we expect the new setting to work with rebalances > in clients that inherit from the AbstractCoordinator (Consumer and Connect > at a minimum). > > Maybe it's worth clarifying these points in the KIP, or the mailing list > thread in case I missed something w/r/t the intent of the changes. > > Best, > Konstantine > > > On Tue, Mar 24, 2020 at 9:42 PM David Jacot wrote: > > > +1 (non-binding) > > > > Thanks for the KIP, great improvement! > > > > Le mer. 25 mars 2020 à 04:44, Gwen Shapira a écrit : > > > > > +1 (binding) - thank you > > > > > > On Mon, Mar 23, 2020, 10:50 AM Sanjana Kaundinya > > > wrote: > > > > > > > Hi Everyone, > > > > > > > > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka > > > > Clients. The link to the KIP can be found here: > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients > > > > . > > > > > > > > Thanks, > > > > Sanjana > > > > > > > > > > > > >
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
Hi Sanjana. Thanks for the KIP! Seems quite useful not to overwhelm the brokers with the described requests from clients. You have the votes already, and I'm also in favor overall, but I've made a couple of questions (sorry for the delay) regarding Connect, which is also using retry.backoff.ms but currently is not mentioned in the KIP, as well as a question around how we expect the new setting to work with rebalances in clients that inherit from the AbstractCoordinator (Consumer and Connect at a minimum). Maybe it's worth clarifying these points in the KIP, or the mailing list thread in case I missed something w/r/t the intent of the changes. Best, Konstantine On Tue, Mar 24, 2020 at 9:42 PM David Jacot wrote: > +1 (non-binding) > > Thanks for the KIP, great improvement! > > Le mer. 25 mars 2020 à 04:44, Gwen Shapira a écrit : > > > +1 (binding) - thank you > > > > On Mon, Mar 23, 2020, 10:50 AM Sanjana Kaundinya > > wrote: > > > > > Hi Everyone, > > > > > > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka > > > Clients. The link to the KIP can be found here: > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients > > > . > > > > > > Thanks, > > > Sanjana > > > > > > > > >
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
+1 (non-binding) Thanks for the KIP, great improvement! Le mer. 25 mars 2020 à 04:44, Gwen Shapira a écrit : > +1 (binding) - thank you > > On Mon, Mar 23, 2020, 10:50 AM Sanjana Kaundinya > wrote: > > > Hi Everyone, > > > > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka > > Clients. The link to the KIP can be found here: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients > > . > > > > Thanks, > > Sanjana > > > > >
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
+1 (binding) - thank you On Mon, Mar 23, 2020, 10:50 AM Sanjana Kaundinya wrote: > Hi Everyone, > > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka > Clients. The link to the KIP can be found here: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients > . > > Thanks, > Sanjana > >
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
+1 Thanks for the KIP! On Tue, Mar 24, 2020 at 10:31 AM Boyang Chen wrote: > +1 (non-binding). > > agree with Guozhang for the warning. > > On Tue, Mar 24, 2020 at 9:57 AM Guozhang Wang wrote: > > > +1 (binding). > > > > One minor thing is that upon starting, when we find the specified > > `max.backoff` config < `backoff`, we can log a warning message. > > > > > > Guozhang > > > > On Tue, Mar 24, 2020 at 12:22 AM Kamal Chandraprakash < > > kamal.chandraprak...@gmail.com> wrote: > > > > > +1 (non-binding). Thanks for the KIP! > > > > > > On Mon, Mar 23, 2020 at 11:20 PM Sanjana Kaundinya < > skaundi...@gmail.com > > > > > > wrote: > > > > > > > Hi Everyone, > > > > > > > > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka > > > > Clients. The link to the KIP can be found here: > > > > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients > > > > . > > > > > > > > Thanks, > > > > Sanjana > > > > > > > > > > > > > > > > > -- > > -- Guozhang > > >
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
+1 (non-binding). agree with Guozhang for the warning. On Tue, Mar 24, 2020 at 9:57 AM Guozhang Wang wrote: > +1 (binding). > > One minor thing is that upon starting, when we find the specified > `max.backoff` config < `backoff`, we can log a warning message. > > > Guozhang > > On Tue, Mar 24, 2020 at 12:22 AM Kamal Chandraprakash < > kamal.chandraprak...@gmail.com> wrote: > > > +1 (non-binding). Thanks for the KIP! > > > > On Mon, Mar 23, 2020 at 11:20 PM Sanjana Kaundinya > > > wrote: > > > > > Hi Everyone, > > > > > > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka > > > Clients. The link to the KIP can be found here: > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients > > > . > > > > > > Thanks, > > > Sanjana > > > > > > > > > > > -- > -- Guozhang >
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
+1 (binding). One minor thing is that upon starting, when we find the specified `max.backoff` config < `backoff`, we can log a warning message. Guozhang On Tue, Mar 24, 2020 at 12:22 AM Kamal Chandraprakash < kamal.chandraprak...@gmail.com> wrote: > +1 (non-binding). Thanks for the KIP! > > On Mon, Mar 23, 2020 at 11:20 PM Sanjana Kaundinya > wrote: > > > Hi Everyone, > > > > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka > > Clients. The link to the KIP can be found here: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients > > . > > > > Thanks, > > Sanjana > > > > > -- -- Guozhang
Re: [VOTE] KIP-580: Exponential Backoff for Kafka Clients
+1 (non-binding). Thanks for the KIP! On Mon, Mar 23, 2020 at 11:20 PM Sanjana Kaundinya wrote: > Hi Everyone, > > I’d like to start a vote for KIP-580: Exponential Backoff for Kafka > Clients. The link to the KIP can be found here: > https://cwiki.apache.org/confluence/display/KAFKA/KIP-580%3A+Exponential+Backoff+for+Kafka+Clients > . > > Thanks, > Sanjana > >
