Re: [VOTE] KIP-616: Rename implicit Serdes instances in kafka-streams-scala

[John Roesler]

Hello again, all!

After Leah proposed KIP-659, we realized that it's not
possible to provide a correct implicit TimeWindowedSerde, so
we decided to drop it from KIP-616.

See 
https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=153816723=15=14

And here's the discussion Yuriy and I had in the PR:
https://github.com/apache/kafka/pull/8955#discussion_r477358755

I've taken the liberty of updating the KIP so that I can go
ahead and merge Yuriy's PR today.
Here's the diff for your perusal:
https://cwiki.apache.org/confluence/pages/diffpagesbyversion.action?pageId=153816723=15=14

I don't think this will be controversial, since we can
always add an implicit for it later if we have any brilliant
ideas. Nevertheless, if you have concerns, please let me
know!

Thanks,
-John

On Wed, 2020-08-19 at 09:36 +0700, Yuriy Badalyantc wrote:
> Hi,
> 
> Looks like there are enough votes to accept the KIP: 3 binding and 1
> non-binding. The pull request is waiting for the merge:
> https://github.com/apache/kafka/pull/8955
> 
> Thanks, everybody!
> 
> -Yuriy
> 
> On Wed, Aug 19, 2020 at 4:51 AM Bill Bejeck  wrote:
> 
> > Thanks for the KIP Yuriy, this will be a great addition.
> > 
> > +1 (binding)
> > 
> > -Bill
> > 
> > On Tue, Aug 18, 2020 at 5:47 PM Matthias J. Sax  wrote:
> > 
> > > Thanks for the KIP Yuriy!
> > > 
> > > +1 (binding)
> > > 
> > > 
> > > -Matthias
> > > 
> > > On 8/13/20 9:49 PM, John Roesler wrote:
> > > > Hi Yuriy,
> > > > 
> > > > What a coincidence! I was just about to bump this thread myself. It
> > > would be really nice to get some more votes to push this over the line.
> > > > Thanks for your patience!
> > > > 
> > > > -John
> > > > 
> > > > On Thu, Aug 13, 2020, at 23:45, Yuriy Badalyantc wrote:
> > > > > Hi all
> > > > > 
> > > > > Bumping this thread again
> > > > > 
> > > > > On Mon, Aug 10, 2020 at 10:07 AM William Reynolds <
> > > > > william.reyno...@instaclustr.com> wrote:
> > > > > 
> > > > > > Looks good,
> > > > > > +1 (non binding)
> > > > > > 
> > > > > > 
> > > > > > *William Reynolds**Technical Operations Engineer*
> > > > > > 
> > > > > > 
> > > > > >    <
> > > https://twitter.com/instaclustr>
> > > > > > 
> > > > > > 
> > > > > > Read our latest technical blog posts here
> > > > > > ;.
> > > > > > 
> > > > > > This email has been sent on behalf of Instaclustr Pty. Limited
> > > (Australia)
> > > > > > and Instaclustr Inc (USA).
> > > > > > 
> > > > > > This email and any attachments may contain confidential and legally
> > > > > > privileged information.  If you are not the intended recipient, do
> > not
> > > copy
> > > > > > or disclose its content, but please reply to this email immediately
> > and
> > > > > > highlight the error to the sender and then immediately delete the
> > > message.
> > > > > > Instaclustr values your privacy. Our privacy policy can be found at
> > > > > > https://www.instaclustr.com/company/policies/privacy-policy
> > > > > > 
> > > > > > 
> > > > > > On Mon, 10 Aug 2020 at 13:01, Yuriy Badalyantc 
> > > wrote:
> > > > > > > Hi everybody.
> > > > > > > 
> > > > > > > Just bumping this thread. This is a pretty minor change only for 
> > > > > > > the
> > > > > > Scala
> > > > > > > API and it's pending in the voting state for a while.
> > > > > > > 
> > > > > > > -Yuriy
> > > > > > > 
> > > > > > > On Fri, Aug 7, 2020 at 8:10 AM Yuriy Badalyantc 
> > > > > > > 
> > > > > > wrote:
> > > > > > > > Hi everybody.
> > > > > > > > 
> > > > > > > > There was some minor change since the voting process started
> > > (nullSerde
> > > > > > > > added). Let's continue to vote.
> > > > > > > > 
> > > > > > > > -Yuriy.
> > > > > > > > 
> > > > > > > > On Thu, Jul 9, 2020 at 10:00 PM John Roesler 
> > > > > > > > 
> > > > > > > wrote:
> > > > > > > > > Thanks Yuriy,
> > > > > > > > > 
> > > > > > > > > I'm +1 (binding)
> > > > > > > > > 
> > > > > > > > > -John
> > > > > > > > > 
> > > > > > > > > On Wed, Jul 8, 2020, at 23:08, Yuriy Badalyantc wrote:
> > > > > > > > > > Hi everybody
> > > > > > > > > > 
> > > > > > > > > > I would like to start a vote  for KIP-616:
> > > > > > > > > > 
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-616%3A+Rename+implicit+Serdes+instances+in+kafka-streams-scala
> > > > > > > > > > This KIP fixes name clash in the
> > > > > > > org.apache.kafka.streams.scala.Serdes.
> > > > > > > > > > -Yuriy
> > > > > > > > > > 

Re: [VOTE] KIP-616: Rename implicit Serdes instances in kafka-streams-scala

[Yuriy Badalyantc]

Hi,

Looks like there are enough votes to accept the KIP: 3 binding and 1
non-binding. The pull request is waiting for the merge:
https://github.com/apache/kafka/pull/8955

Thanks, everybody!

-Yuriy

On Wed, Aug 19, 2020 at 4:51 AM Bill Bejeck  wrote:

> Thanks for the KIP Yuriy, this will be a great addition.
>
> +1 (binding)
>
> -Bill
>
> On Tue, Aug 18, 2020 at 5:47 PM Matthias J. Sax  wrote:
>
> > Thanks for the KIP Yuriy!
> >
> > +1 (binding)
> >
> >
> > -Matthias
> >
> > On 8/13/20 9:49 PM, John Roesler wrote:
> > > Hi Yuriy,
> > >
> > > What a coincidence! I was just about to bump this thread myself. It
> > would be really nice to get some more votes to push this over the line.
> > >
> > > Thanks for your patience!
> > >
> > > -John
> > >
> > > On Thu, Aug 13, 2020, at 23:45, Yuriy Badalyantc wrote:
> > >> Hi all
> > >>
> > >> Bumping this thread again
> > >>
> > >> On Mon, Aug 10, 2020 at 10:07 AM William Reynolds <
> > >> william.reyno...@instaclustr.com> wrote:
> > >>
> > >>> Looks good,
> > >>> +1 (non binding)
> > >>>
> > >>>
> > >>> *William Reynolds**Technical Operations Engineer*
> > >>>
> > >>>
> > >>>    <
> > https://twitter.com/instaclustr>
> > >>> 
> > >>>
> > >>> Read our latest technical blog posts here
> > >>> .
> > >>>
> > >>> This email has been sent on behalf of Instaclustr Pty. Limited
> > (Australia)
> > >>> and Instaclustr Inc (USA).
> > >>>
> > >>> This email and any attachments may contain confidential and legally
> > >>> privileged information.  If you are not the intended recipient, do
> not
> > copy
> > >>> or disclose its content, but please reply to this email immediately
> and
> > >>> highlight the error to the sender and then immediately delete the
> > message.
> > >>>
> > >>> Instaclustr values your privacy. Our privacy policy can be found at
> > >>> https://www.instaclustr.com/company/policies/privacy-policy
> > >>>
> > >>>
> > >>> On Mon, 10 Aug 2020 at 13:01, Yuriy Badalyantc 
> > wrote:
> > >>>
> >  Hi everybody.
> > 
> >  Just bumping this thread. This is a pretty minor change only for the
> > >>> Scala
> >  API and it's pending in the voting state for a while.
> > 
> >  -Yuriy
> > 
> >  On Fri, Aug 7, 2020 at 8:10 AM Yuriy Badalyantc 
> > >>> wrote:
> > 
> > > Hi everybody.
> > >
> > > There was some minor change since the voting process started
> > (nullSerde
> > > added). Let's continue to vote.
> > >
> > > -Yuriy.
> > >
> > > On Thu, Jul 9, 2020 at 10:00 PM John Roesler 
> >  wrote:
> > >
> > >> Thanks Yuriy,
> > >>
> > >> I'm +1 (binding)
> > >>
> > >> -John
> > >>
> > >> On Wed, Jul 8, 2020, at 23:08, Yuriy Badalyantc wrote:
> > >>> Hi everybody
> > >>>
> > >>> I would like to start a vote  for KIP-616:
> > >>>
> > >>
> > 
> > >>>
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-616%3A+Rename+implicit+Serdes+instances+in+kafka-streams-scala
> > >>>
> > >>> This KIP fixes name clash in the
> >  org.apache.kafka.streams.scala.Serdes.
> > >>>
> > >>> -Yuriy
> > >>>
> > >>
> > >
> > 
> > >>>
> > >>
> >
> >
>

Re: [VOTE] KIP-616: Rename implicit Serdes instances in kafka-streams-scala

[Bill Bejeck]

Thanks for the KIP Yuriy, this will be a great addition.

+1 (binding)

-Bill

On Tue, Aug 18, 2020 at 5:47 PM Matthias J. Sax  wrote:

> Thanks for the KIP Yuriy!
>
> +1 (binding)
>
>
> -Matthias
>
> On 8/13/20 9:49 PM, John Roesler wrote:
> > Hi Yuriy,
> >
> > What a coincidence! I was just about to bump this thread myself. It
> would be really nice to get some more votes to push this over the line.
> >
> > Thanks for your patience!
> >
> > -John
> >
> > On Thu, Aug 13, 2020, at 23:45, Yuriy Badalyantc wrote:
> >> Hi all
> >>
> >> Bumping this thread again
> >>
> >> On Mon, Aug 10, 2020 at 10:07 AM William Reynolds <
> >> william.reyno...@instaclustr.com> wrote:
> >>
> >>> Looks good,
> >>> +1 (non binding)
> >>>
> >>>
> >>> *William Reynolds**Technical Operations Engineer*
> >>>
> >>>
> >>>    <
> https://twitter.com/instaclustr>
> >>> 
> >>>
> >>> Read our latest technical blog posts here
> >>> .
> >>>
> >>> This email has been sent on behalf of Instaclustr Pty. Limited
> (Australia)
> >>> and Instaclustr Inc (USA).
> >>>
> >>> This email and any attachments may contain confidential and legally
> >>> privileged information.  If you are not the intended recipient, do not
> copy
> >>> or disclose its content, but please reply to this email immediately and
> >>> highlight the error to the sender and then immediately delete the
> message.
> >>>
> >>> Instaclustr values your privacy. Our privacy policy can be found at
> >>> https://www.instaclustr.com/company/policies/privacy-policy
> >>>
> >>>
> >>> On Mon, 10 Aug 2020 at 13:01, Yuriy Badalyantc 
> wrote:
> >>>
>  Hi everybody.
> 
>  Just bumping this thread. This is a pretty minor change only for the
> >>> Scala
>  API and it's pending in the voting state for a while.
> 
>  -Yuriy
> 
>  On Fri, Aug 7, 2020 at 8:10 AM Yuriy Badalyantc 
> >>> wrote:
> 
> > Hi everybody.
> >
> > There was some minor change since the voting process started
> (nullSerde
> > added). Let's continue to vote.
> >
> > -Yuriy.
> >
> > On Thu, Jul 9, 2020 at 10:00 PM John Roesler 
>  wrote:
> >
> >> Thanks Yuriy,
> >>
> >> I'm +1 (binding)
> >>
> >> -John
> >>
> >> On Wed, Jul 8, 2020, at 23:08, Yuriy Badalyantc wrote:
> >>> Hi everybody
> >>>
> >>> I would like to start a vote  for KIP-616:
> >>>
> >>
> 
> >>>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-616%3A+Rename+implicit+Serdes+instances+in+kafka-streams-scala
> >>>
> >>> This KIP fixes name clash in the
>  org.apache.kafka.streams.scala.Serdes.
> >>>
> >>> -Yuriy
> >>>
> >>
> >
> 
> >>>
> >>
>
>

Re: [VOTE] KIP-616: Rename implicit Serdes instances in kafka-streams-scala

[Matthias J. Sax]

Thanks for the KIP Yuriy!

+1 (binding)


-Matthias

On 8/13/20 9:49 PM, John Roesler wrote:
> Hi Yuriy,
> 
> What a coincidence! I was just about to bump this thread myself. It would be 
> really nice to get some more votes to push this over the line. 
> 
> Thanks for your patience!
> 
> -John
> 
> On Thu, Aug 13, 2020, at 23:45, Yuriy Badalyantc wrote:
>> Hi all
>>
>> Bumping this thread again
>>
>> On Mon, Aug 10, 2020 at 10:07 AM William Reynolds <
>> william.reyno...@instaclustr.com> wrote:
>>
>>> Looks good,
>>> +1 (non binding)
>>>
>>>
>>> *William Reynolds**Technical Operations Engineer*
>>>
>>>
>>>    
>>> 
>>>
>>> Read our latest technical blog posts here
>>> .
>>>
>>> This email has been sent on behalf of Instaclustr Pty. Limited (Australia)
>>> and Instaclustr Inc (USA).
>>>
>>> This email and any attachments may contain confidential and legally
>>> privileged information.  If you are not the intended recipient, do not copy
>>> or disclose its content, but please reply to this email immediately and
>>> highlight the error to the sender and then immediately delete the message.
>>>
>>> Instaclustr values your privacy. Our privacy policy can be found at
>>> https://www.instaclustr.com/company/policies/privacy-policy
>>>
>>>
>>> On Mon, 10 Aug 2020 at 13:01, Yuriy Badalyantc  wrote:
>>>
 Hi everybody.

 Just bumping this thread. This is a pretty minor change only for the
>>> Scala
 API and it's pending in the voting state for a while.

 -Yuriy

 On Fri, Aug 7, 2020 at 8:10 AM Yuriy Badalyantc 
>>> wrote:

> Hi everybody.
>
> There was some minor change since the voting process started (nullSerde
> added). Let's continue to vote.
>
> -Yuriy.
>
> On Thu, Jul 9, 2020 at 10:00 PM John Roesler 
 wrote:
>
>> Thanks Yuriy,
>>
>> I'm +1 (binding)
>>
>> -John
>>
>> On Wed, Jul 8, 2020, at 23:08, Yuriy Badalyantc wrote:
>>> Hi everybody
>>>
>>> I would like to start a vote  for KIP-616:
>>>
>>

>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-616%3A+Rename+implicit+Serdes+instances+in+kafka-streams-scala
>>>
>>> This KIP fixes name clash in the
 org.apache.kafka.streams.scala.Serdes.
>>>
>>> -Yuriy
>>>
>>
>

>>>
>>



signature.asc
Description: OpenPGP digital signature

Re: [VOTE] KIP-616: Rename implicit Serdes instances in kafka-streams-scala

[John Roesler]

Hi Yuriy,

What a coincidence! I was just about to bump this thread myself. It would be 
really nice to get some more votes to push this over the line. 

Thanks for your patience!

-John

On Thu, Aug 13, 2020, at 23:45, Yuriy Badalyantc wrote:
> Hi all
> 
> Bumping this thread again
> 
> On Mon, Aug 10, 2020 at 10:07 AM William Reynolds <
> william.reyno...@instaclustr.com> wrote:
> 
> > Looks good,
> > +1 (non binding)
> >
> >
> > *William Reynolds**Technical Operations Engineer*
> >
> >
> >    
> > 
> >
> > Read our latest technical blog posts here
> > .
> >
> > This email has been sent on behalf of Instaclustr Pty. Limited (Australia)
> > and Instaclustr Inc (USA).
> >
> > This email and any attachments may contain confidential and legally
> > privileged information.  If you are not the intended recipient, do not copy
> > or disclose its content, but please reply to this email immediately and
> > highlight the error to the sender and then immediately delete the message.
> >
> > Instaclustr values your privacy. Our privacy policy can be found at
> > https://www.instaclustr.com/company/policies/privacy-policy
> >
> >
> > On Mon, 10 Aug 2020 at 13:01, Yuriy Badalyantc  wrote:
> >
> > > Hi everybody.
> > >
> > > Just bumping this thread. This is a pretty minor change only for the
> > Scala
> > > API and it's pending in the voting state for a while.
> > >
> > > -Yuriy
> > >
> > > On Fri, Aug 7, 2020 at 8:10 AM Yuriy Badalyantc 
> > wrote:
> > >
> > > > Hi everybody.
> > > >
> > > > There was some minor change since the voting process started (nullSerde
> > > > added). Let's continue to vote.
> > > >
> > > > -Yuriy.
> > > >
> > > > On Thu, Jul 9, 2020 at 10:00 PM John Roesler 
> > > wrote:
> > > >
> > > >> Thanks Yuriy,
> > > >>
> > > >> I'm +1 (binding)
> > > >>
> > > >> -John
> > > >>
> > > >> On Wed, Jul 8, 2020, at 23:08, Yuriy Badalyantc wrote:
> > > >> > Hi everybody
> > > >> >
> > > >> > I would like to start a vote  for KIP-616:
> > > >> >
> > > >>
> > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-616%3A+Rename+implicit+Serdes+instances+in+kafka-streams-scala
> > > >> >
> > > >> > This KIP fixes name clash in the
> > > org.apache.kafka.streams.scala.Serdes.
> > > >> >
> > > >> > -Yuriy
> > > >> >
> > > >>
> > > >
> > >
> >
>

Re: [VOTE] KIP-616: Rename implicit Serdes instances in kafka-streams-scala

[Yuriy Badalyantc]

Hi all

Bumping this thread again

On Mon, Aug 10, 2020 at 10:07 AM William Reynolds <
william.reyno...@instaclustr.com> wrote:

> Looks good,
> +1 (non binding)
>
>
> *William Reynolds**Technical Operations Engineer*
>
>
>    
> 
>
> Read our latest technical blog posts here
> .
>
> This email has been sent on behalf of Instaclustr Pty. Limited (Australia)
> and Instaclustr Inc (USA).
>
> This email and any attachments may contain confidential and legally
> privileged information.  If you are not the intended recipient, do not copy
> or disclose its content, but please reply to this email immediately and
> highlight the error to the sender and then immediately delete the message.
>
> Instaclustr values your privacy. Our privacy policy can be found at
> https://www.instaclustr.com/company/policies/privacy-policy
>
>
> On Mon, 10 Aug 2020 at 13:01, Yuriy Badalyantc  wrote:
>
> > Hi everybody.
> >
> > Just bumping this thread. This is a pretty minor change only for the
> Scala
> > API and it's pending in the voting state for a while.
> >
> > -Yuriy
> >
> > On Fri, Aug 7, 2020 at 8:10 AM Yuriy Badalyantc 
> wrote:
> >
> > > Hi everybody.
> > >
> > > There was some minor change since the voting process started (nullSerde
> > > added). Let's continue to vote.
> > >
> > > -Yuriy.
> > >
> > > On Thu, Jul 9, 2020 at 10:00 PM John Roesler 
> > wrote:
> > >
> > >> Thanks Yuriy,
> > >>
> > >> I'm +1 (binding)
> > >>
> > >> -John
> > >>
> > >> On Wed, Jul 8, 2020, at 23:08, Yuriy Badalyantc wrote:
> > >> > Hi everybody
> > >> >
> > >> > I would like to start a vote  for KIP-616:
> > >> >
> > >>
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-616%3A+Rename+implicit+Serdes+instances+in+kafka-streams-scala
> > >> >
> > >> > This KIP fixes name clash in the
> > org.apache.kafka.streams.scala.Serdes.
> > >> >
> > >> > -Yuriy
> > >> >
> > >>
> > >
> >
>

Re: [VOTE] KIP-616: Rename implicit Serdes instances in kafka-streams-scala

[William Reynolds]

Looks good,
+1 (non binding)


*William Reynolds**Technical Operations Engineer*


   


Read our latest technical blog posts here
.

This email has been sent on behalf of Instaclustr Pty. Limited (Australia)
and Instaclustr Inc (USA).

This email and any attachments may contain confidential and legally
privileged information.  If you are not the intended recipient, do not copy
or disclose its content, but please reply to this email immediately and
highlight the error to the sender and then immediately delete the message.

Instaclustr values your privacy. Our privacy policy can be found at
https://www.instaclustr.com/company/policies/privacy-policy


On Mon, 10 Aug 2020 at 13:01, Yuriy Badalyantc  wrote:

> Hi everybody.
>
> Just bumping this thread. This is a pretty minor change only for the Scala
> API and it's pending in the voting state for a while.
>
> -Yuriy
>
> On Fri, Aug 7, 2020 at 8:10 AM Yuriy Badalyantc  wrote:
>
> > Hi everybody.
> >
> > There was some minor change since the voting process started (nullSerde
> > added). Let's continue to vote.
> >
> > -Yuriy.
> >
> > On Thu, Jul 9, 2020 at 10:00 PM John Roesler 
> wrote:
> >
> >> Thanks Yuriy,
> >>
> >> I'm +1 (binding)
> >>
> >> -John
> >>
> >> On Wed, Jul 8, 2020, at 23:08, Yuriy Badalyantc wrote:
> >> > Hi everybody
> >> >
> >> > I would like to start a vote  for KIP-616:
> >> >
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-616%3A+Rename+implicit+Serdes+instances+in+kafka-streams-scala
> >> >
> >> > This KIP fixes name clash in the
> org.apache.kafka.streams.scala.Serdes.
> >> >
> >> > -Yuriy
> >> >
> >>
> >
>

Re: [VOTE] KIP-616: Rename implicit Serdes instances in kafka-streams-scala

[Yuriy Badalyantc]

Hi everybody.

Just bumping this thread. This is a pretty minor change only for the Scala
API and it's pending in the voting state for a while.

-Yuriy

On Fri, Aug 7, 2020 at 8:10 AM Yuriy Badalyantc  wrote:

> Hi everybody.
>
> There was some minor change since the voting process started (nullSerde
> added). Let's continue to vote.
>
> -Yuriy.
>
> On Thu, Jul 9, 2020 at 10:00 PM John Roesler  wrote:
>
>> Thanks Yuriy,
>>
>> I'm +1 (binding)
>>
>> -John
>>
>> On Wed, Jul 8, 2020, at 23:08, Yuriy Badalyantc wrote:
>> > Hi everybody
>> >
>> > I would like to start a vote  for KIP-616:
>> >
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-616%3A+Rename+implicit+Serdes+instances+in+kafka-streams-scala
>> >
>> > This KIP fixes name clash in the org.apache.kafka.streams.scala.Serdes.
>> >
>> > -Yuriy
>> >
>>
>

Re: [VOTE] KIP-616: Rename implicit Serdes instances in kafka-streams-scala

[Yuriy Badalyantc]

Hi everybody.

There was some minor change since the voting process started (nullSerde
added). Let's continue to vote.

-Yuriy.

On Thu, Jul 9, 2020 at 10:00 PM John Roesler  wrote:

> Thanks Yuriy,
>
> I'm +1 (binding)
>
> -John
>
> On Wed, Jul 8, 2020, at 23:08, Yuriy Badalyantc wrote:
> > Hi everybody
> >
> > I would like to start a vote  for KIP-616:
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-616%3A+Rename+implicit+Serdes+instances+in+kafka-streams-scala
> >
> > This KIP fixes name clash in the org.apache.kafka.streams.scala.Serdes.
> >
> > -Yuriy
> >
>

Re: [VOTE] KIP-616: Rename implicit Serdes instances in kafka-streams-scala

[John Roesler]

Thanks Yuriy,

I'm +1 (binding)

-John

On Wed, Jul 8, 2020, at 23:08, Yuriy Badalyantc wrote:
> Hi everybody
> 
> I would like to start a vote  for KIP-616:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-616%3A+Rename+implicit+Serdes+instances+in+kafka-streams-scala
> 
> This KIP fixes name clash in the org.apache.kafka.streams.scala.Serdes.
> 
> -Yuriy
>