Re: [VOTE] KIP-632: Add DirectoryConfigProvider

2020-08-06 Thread Konstantine Karantasis
A bit late on this thread, but I've reviewed the KIP and I'm also +1. Thanks Tom. Happy to see this improvement making it in. Konstantine On Thu, Aug 6, 2020 at 10:27 AM Tom Bentley wrote: > With 3 binding +1 (Manikumar, Mickael and Rajini) and 2 non-binding +1 > (David and William) the vote

Re: [VOTE] KIP-632: Add DirectoryConfigProvider

2020-08-06 Thread Tom Bentley
With 3 binding +1 (Manikumar, Mickael and Rajini) and 2 non-binding +1 (David and William) the vote passes. Thanks to all who voted. Tom On Thu, Aug 6, 2020 at 12:39 PM Rajini Sivaram wrote: > Hi Tom, > > +1 (binding) > > Thanks for the KIP. Apart from being useful when using frameworks like

Re: [VOTE] KIP-632: Add DirectoryConfigProvider

2020-08-06 Thread Rajini Sivaram
Hi Tom, +1 (binding) Thanks for the KIP. Apart from being useful when using frameworks like Kubernetes, it also seems like a neater way of storing complex multi-line configs without embedding into a property file. Regards, Rajini On Thu, Aug 6, 2020 at 12:29 PM William Reynolds <

Re: [VOTE] KIP-632: Add DirectoryConfigProvider

2020-08-06 Thread William Reynolds
+1 (non binding) Looks like a good addition! On 06/08/2020, Tom Bentley wrote: > This pretty minor change has 2 binding and 1 non-binding votes. It would be > great if more people could take a look and either vote or give feedback > about how it should be improved. > > Many thanks, > > Tom > >

Re: [VOTE] KIP-632: Add DirectoryConfigProvider

2020-08-06 Thread Tom Bentley
This pretty minor change has 2 binding and 1 non-binding votes. It would be great if more people could take a look and either vote or give feedback about how it should be improved. Many thanks, Tom On Wed, Jul 8, 2020 at 7:07 PM Mickael Maison wrote: > +1 (binding) > Thanks > > On Wed, Jul 8,

Re: [VOTE] KIP-632: Add DirectoryConfigProvider

2020-07-08 Thread Mickael Maison
+1 (binding) Thanks On Wed, Jul 8, 2020 at 11:31 AM Manikumar wrote: > > +1 (bindig) > > Thanks for the KIP. > > On Tue, Jul 7, 2020 at 10:30 PM David Jacot wrote: > > > +1 (non-binding). Thanks for the KIP! > > > > On Tue, Jul 7, 2020 at 12:54 PM Tom Bentley wrote: > > > > > Hi, > > > > > >

Re: [VOTE] KIP-632: Add DirectoryConfigProvider

2020-07-08 Thread Manikumar
+1 (bindig) Thanks for the KIP. On Tue, Jul 7, 2020 at 10:30 PM David Jacot wrote: > +1 (non-binding). Thanks for the KIP! > > On Tue, Jul 7, 2020 at 12:54 PM Tom Bentley wrote: > > > Hi, > > > > I'd like to start a vote on KIP-632, which is about making the config > > provider mechanism more

Re: [VOTE] KIP-632: Add DirectoryConfigProvider

2020-07-07 Thread David Jacot
+1 (non-binding). Thanks for the KIP! On Tue, Jul 7, 2020 at 12:54 PM Tom Bentley wrote: > Hi, > > I'd like to start a vote on KIP-632, which is about making the config > provider mechanism more ergonomic on Kubernetes: > > >