Re: [Decanter] - Collector socket marshaller improvement

2017-11-03 Thread François Papon
Yes, that's it :) Le 3 nov. 2017 12:30, Jean-Baptiste Onofré a écrit : > > That's before the socket appender sends json. So you are talking about > unmarshaller, not marshaller. The socket collector receives json data and > transforms to a map. That's normal and the expected

Re: [Decanter] - Collector socket marshaller improvement

2017-11-03 Thread Jean-Baptiste Onofré
That's before the socket appender sends json. So you are talking about unmarshaller, not marshaller. The socket collector receives json data and transforms to a map. That's normal and the expected behavior. If you want to be able to change the unmarshaller, that makes sense. Regards JB On Nov

Re: [Decanter] - Collector socket marshaller improvement

2017-11-03 Thread François Papon
Ok, I miss something, because I see the unmarshall method in the collector and for me it take json and transform it to a Map. I would explain that how could the collector take another format than json from the socket inputstream reader. Le 3 nov. 2017 12:08, Jean-Baptiste Onofré

Re: [Decanter] - Collector socket marshaller improvement

2017-11-03 Thread Jean-Baptiste Onofré
See my last e-mail in the thread. The collector should only send map. Marshaller should be called by the appender. That's really important to both decouple collectors and appenders and be able to use the alerts checker. Regards JB On Nov 3, 2017, 09:05, at 09:05, Francois Papon

Re: [Decanter] - Collector socket marshaller improvement

2017-11-03 Thread Jean-Baptiste Onofré
Hi No it's not a good idea. The collector doesn't del with marshalling. It should send only data as a map. The marshaller is at appender level. Regards JB On Nov 3, 2017, 08:56, at 08:56, Francois Papon wrote: >Hi, > >I'm back with Decanter :) > >I'm thinking

Re: [Decanter] - Collector socket marshaller improvement

2017-11-03 Thread Francois Papon
We also have to change the target of the @Reference unmarshaller in the SocketCollector @Reference(target=Marshaller.SERVICE_KEY_DATAFORMAT + "=my-data-format")     public void setUnmarshaller(Unmarshaller unmarshaller) {     this.unmarshaller = unmarshaller;     } where my-data-format is a