Re: PR608 - Updated Scheduler feature to support persistence - Failed
Ah, this is it. I was always compiling with -Pfastinstall ... Thanks Rgds, Miroslav V V tor., 11. sep. 2018 ob 11:01 je oseba Jean-Baptiste Onofré < j...@nanthrax.net> napisala: > Hi, > > Jenkins is doing the same as local. > > Just do a complete: > > mvn clean install -Prat > > you will have the same. > > Regards > JB > > On 11/09/2018 10:58, Miroslav Beranič wrote: > > Hi François, > > > > I have to be logged in to access > > > https://builds.apache.org/view/K/view/Karaf/job/karaf-pr/ws/target/karaf-4.2.2-SNAPSHOT.rat/*view*/ > > > > Is registration open or I need invite? I did not see a registration form. > > > > But more important: > > > > How do I compile locally in a way, to have this error before pushing to > > Apache's Jenkins - save me embarrassment and you resources on servers. > > > > Regards, > > Miroslav > > > > > > V V tor., 11. sep. 2018 ob 08:46 je oseba Francois Papon < > > francois.pa...@openobject.fr> napisala: > > > >> Hi, > >> > >> You are missing the Apache License header in files : > >> > >> 4 Unknown Licenses > >> > >> * > >> > >> Files with unapproved licenses: > >> > >> > scheduler/src/main/java/org/apache/karaf/scheduler/SchedulerStorage.java > >> > >> > scheduler/src/main/java/org/apache/karaf/scheduler/core/StdOsgiScheduler.java > >> > >> > scheduler/src/main/java/org/apache/karaf/scheduler/core/QuartzSchedulerStorage.java > >> > >> > scheduler/src/main/java/org/apache/karaf/scheduler/core/StdOsgiSchedulerFactory.java > >> > >> I put some comments on your PR ;) > >> > >> You can see the detailed files here : > >> > >> > >> > https://builds.apache.org/view/K/view/Karaf/job/karaf-pr/ws/target/karaf-4.2.2-SNAPSHOT.rat/*view*/ > >> > >> regards, > >> > >> François Papon > >> fpa...@apache.org > >> > >> Le 11/09/2018 à 10:35, Miroslav Beranič a écrit : > >>> Hi, > >>> > >>> I've subscribed to dev mailing list. > >>> > >>> I've submitted a pull request at > >> https://github.com/apache/karaf/pull/608, > >>> but I see Jenkins build failed do to: > >>> Caused by: org.apache.rat.mp.RatCheckException: Too many files with > >>> unapproved license: 4 See RAT report in: > >>> > >> > /home/jenkins/jenkins-slave/workspace/karaf-pr/target/karaf-4.2.2-SNAPSHOT.rat > >>> > >>> > >>> located at : > >>> https://builds.apache.org/job/karaf-pr/665/console > >>> > >>> What should I update, to make this work? > >>> > >>> Kind Regards, > >>> Miroslav > >>> > >>> > >> > >> > >> > > > > -- > Jean-Baptiste Onofré > jbono...@apache.org > http://blog.nanthrax.net > Talend - http://www.talend.com > -- Miroslav Beranič MIBESIS +386(0)40/814-843 miroslav.bera...@mibesis.si http://www.mibesis.si
Re: PR608 - Updated Scheduler feature to support persistence - Failed
Hi, Jenkins is doing the same as local. Just do a complete: mvn clean install -Prat you will have the same. Regards JB On 11/09/2018 10:58, Miroslav Beranič wrote: > Hi François, > > I have to be logged in to access > https://builds.apache.org/view/K/view/Karaf/job/karaf-pr/ws/target/karaf-4.2.2-SNAPSHOT.rat/*view*/ > > Is registration open or I need invite? I did not see a registration form. > > But more important: > > How do I compile locally in a way, to have this error before pushing to > Apache's Jenkins - save me embarrassment and you resources on servers. > > Regards, > Miroslav > > > V V tor., 11. sep. 2018 ob 08:46 je oseba Francois Papon < > francois.pa...@openobject.fr> napisala: > >> Hi, >> >> You are missing the Apache License header in files : >> >> 4 Unknown Licenses >> >> * >> >> Files with unapproved licenses: >> >> scheduler/src/main/java/org/apache/karaf/scheduler/SchedulerStorage.java >> >> scheduler/src/main/java/org/apache/karaf/scheduler/core/StdOsgiScheduler.java >> >> scheduler/src/main/java/org/apache/karaf/scheduler/core/QuartzSchedulerStorage.java >> >> scheduler/src/main/java/org/apache/karaf/scheduler/core/StdOsgiSchedulerFactory.java >> >> I put some comments on your PR ;) >> >> You can see the detailed files here : >> >> >> https://builds.apache.org/view/K/view/Karaf/job/karaf-pr/ws/target/karaf-4.2.2-SNAPSHOT.rat/*view*/ >> >> regards, >> >> François Papon >> fpa...@apache.org >> >> Le 11/09/2018 à 10:35, Miroslav Beranič a écrit : >>> Hi, >>> >>> I've subscribed to dev mailing list. >>> >>> I've submitted a pull request at >> https://github.com/apache/karaf/pull/608, >>> but I see Jenkins build failed do to: >>> Caused by: org.apache.rat.mp.RatCheckException: Too many files with >>> unapproved license: 4 See RAT report in: >>> >> /home/jenkins/jenkins-slave/workspace/karaf-pr/target/karaf-4.2.2-SNAPSHOT.rat >>> >>> >>> located at : >>> https://builds.apache.org/job/karaf-pr/665/console >>> >>> What should I update, to make this work? >>> >>> Kind Regards, >>> Miroslav >>> >>> >> >> >> > -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
Re: PR608 - Updated Scheduler feature to support persistence - Failed
Hi François, I have to be logged in to access https://builds.apache.org/view/K/view/Karaf/job/karaf-pr/ws/target/karaf-4.2.2-SNAPSHOT.rat/*view*/ Is registration open or I need invite? I did not see a registration form. But more important: How do I compile locally in a way, to have this error before pushing to Apache's Jenkins - save me embarrassment and you resources on servers. Regards, Miroslav V V tor., 11. sep. 2018 ob 08:46 je oseba Francois Papon < francois.pa...@openobject.fr> napisala: > Hi, > > You are missing the Apache License header in files : > > 4 Unknown Licenses > > * > > Files with unapproved licenses: > > scheduler/src/main/java/org/apache/karaf/scheduler/SchedulerStorage.java > > scheduler/src/main/java/org/apache/karaf/scheduler/core/StdOsgiScheduler.java > > scheduler/src/main/java/org/apache/karaf/scheduler/core/QuartzSchedulerStorage.java > > scheduler/src/main/java/org/apache/karaf/scheduler/core/StdOsgiSchedulerFactory.java > > I put some comments on your PR ;) > > You can see the detailed files here : > > > https://builds.apache.org/view/K/view/Karaf/job/karaf-pr/ws/target/karaf-4.2.2-SNAPSHOT.rat/*view*/ > > regards, > > François Papon > fpa...@apache.org > > Le 11/09/2018 à 10:35, Miroslav Beranič a écrit : > > Hi, > > > > I've subscribed to dev mailing list. > > > > I've submitted a pull request at > https://github.com/apache/karaf/pull/608, > > but I see Jenkins build failed do to: > > Caused by: org.apache.rat.mp.RatCheckException: Too many files with > > unapproved license: 4 See RAT report in: > > > /home/jenkins/jenkins-slave/workspace/karaf-pr/target/karaf-4.2.2-SNAPSHOT.rat > > > > > > located at : > > https://builds.apache.org/job/karaf-pr/665/console > > > > What should I update, to make this work? > > > > Kind Regards, > > Miroslav > > > > > > > -- Miroslav Beranič MIBESIS +386(0)40/814-843 miroslav.bera...@mibesis.si http://www.mibesis.si
Re: PR608 - Updated Scheduler feature to support persistence - Failed
Hi, Catcha. I will provide my comments directly in the PR. Regards JB On 11/09/2018 09:12, Miroslav Beranič wrote: > Hi JB, > > yes, I know. I need Quartz API, so this was my main motivation. I guess not > all changes are valid. > Open for any suggestion, let me know. > > Regards, > Miroslav > > > V V tor., 11. sep. 2018 ob 08:49 je oseba Jean-Baptiste Onofré < > j...@nanthrax.net> napisala: > >> Hi, >> >> The ASF headers are missing. >> >> By the way, I see a lot of incoherent changes here and not good IMHO. >> >> I will do a complete review. >> >> Regards >> JB >> >> On 11/09/2018 08:35, Miroslav Beranič wrote: >>> Hi, >>> >>> I've subscribed to dev mailing list. >>> >>> I've submitted a pull request at >> https://github.com/apache/karaf/pull/608, >>> but I see Jenkins build failed do to: >>> Caused by: org.apache.rat.mp.RatCheckException: Too many files with >>> unapproved license: 4 See RAT report in: >>> >> /home/jenkins/jenkins-slave/workspace/karaf-pr/target/karaf-4.2.2-SNAPSHOT.rat >>> >>> >>> located at : >>> https://builds.apache.org/job/karaf-pr/665/console >>> >>> What should I update, to make this work? >>> >>> Kind Regards, >>> Miroslav >>> >>> >> >> -- >> Jean-Baptiste Onofré >> jbono...@apache.org >> http://blog.nanthrax.net >> Talend - http://www.talend.com >> > > -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
Re: PR608 - Updated Scheduler feature to support persistence - Failed
Hi François, thanks! Regards, Miroslav V V tor., 11. sep. 2018 ob 08:46 je oseba Francois Papon < francois.pa...@openobject.fr> napisala: > Hi, > > You are missing the Apache License header in files : > > 4 Unknown Licenses > > * > > Files with unapproved licenses: > > scheduler/src/main/java/org/apache/karaf/scheduler/SchedulerStorage.java > > scheduler/src/main/java/org/apache/karaf/scheduler/core/StdOsgiScheduler.java > > scheduler/src/main/java/org/apache/karaf/scheduler/core/QuartzSchedulerStorage.java > > scheduler/src/main/java/org/apache/karaf/scheduler/core/StdOsgiSchedulerFactory.java > > I put some comments on your PR ;) > > You can see the detailed files here : > > > https://builds.apache.org/view/K/view/Karaf/job/karaf-pr/ws/target/karaf-4.2.2-SNAPSHOT.rat/*view*/ > > regards, > > François Papon > fpa...@apache.org > > Le 11/09/2018 à 10:35, Miroslav Beranič a écrit : > > Hi, > > > > I've subscribed to dev mailing list. > > > > I've submitted a pull request at > https://github.com/apache/karaf/pull/608, > > but I see Jenkins build failed do to: > > Caused by: org.apache.rat.mp.RatCheckException: Too many files with > > unapproved license: 4 See RAT report in: > > > /home/jenkins/jenkins-slave/workspace/karaf-pr/target/karaf-4.2.2-SNAPSHOT.rat > > > > > > located at : > > https://builds.apache.org/job/karaf-pr/665/console > > > > What should I update, to make this work? > > > > Kind Regards, > > Miroslav > > > > > > > -- Miroslav Beranič MIBESIS +386(0)40/814-843 miroslav.bera...@mibesis.si http://www.mibesis.si
Re: PR608 - Updated Scheduler feature to support persistence - Failed
Hi, The ASF headers are missing. By the way, I see a lot of incoherent changes here and not good IMHO. I will do a complete review. Regards JB On 11/09/2018 08:35, Miroslav Beranič wrote: > Hi, > > I've subscribed to dev mailing list. > > I've submitted a pull request at https://github.com/apache/karaf/pull/608, > but I see Jenkins build failed do to: > Caused by: org.apache.rat.mp.RatCheckException: Too many files with > unapproved license: 4 See RAT report in: > /home/jenkins/jenkins-slave/workspace/karaf-pr/target/karaf-4.2.2-SNAPSHOT.rat > > > located at : > https://builds.apache.org/job/karaf-pr/665/console > > What should I update, to make this work? > > Kind Regards, > Miroslav > > -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
Re: PR608 - Updated Scheduler feature to support persistence - Failed
Hi, You are missing the Apache License header in files : 4 Unknown Licenses * Files with unapproved licenses: scheduler/src/main/java/org/apache/karaf/scheduler/SchedulerStorage.java scheduler/src/main/java/org/apache/karaf/scheduler/core/StdOsgiScheduler.java scheduler/src/main/java/org/apache/karaf/scheduler/core/QuartzSchedulerStorage.java scheduler/src/main/java/org/apache/karaf/scheduler/core/StdOsgiSchedulerFactory.java I put some comments on your PR ;) You can see the detailed files here : https://builds.apache.org/view/K/view/Karaf/job/karaf-pr/ws/target/karaf-4.2.2-SNAPSHOT.rat/*view*/ regards, François Papon fpa...@apache.org Le 11/09/2018 à 10:35, Miroslav Beranič a écrit : > Hi, > > I've subscribed to dev mailing list. > > I've submitted a pull request at https://github.com/apache/karaf/pull/608, > but I see Jenkins build failed do to: > Caused by: org.apache.rat.mp.RatCheckException: Too many files with > unapproved license: 4 See RAT report in: > /home/jenkins/jenkins-slave/workspace/karaf-pr/target/karaf-4.2.2-SNAPSHOT.rat > > > located at : > https://builds.apache.org/job/karaf-pr/665/console > > What should I update, to make this work? > > Kind Regards, > Miroslav > >
