[GitHub] [knox] goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag…

2019-11-12 Thread GitBox
goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag… URL: https://github.com/apache/knox/pull/143#issuecomment-553274967 Any updates on this one please? When can we merge this ? Its been idle for too long now. --

[GitHub] [knox] goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag…

2019-10-11 Thread GitBox
goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag… URL: https://github.com/apache/knox/pull/143#issuecomment-540972301 @moresandeep Can you please merge this PR? I want to raise another PR for KNOX-2204 and its changes are dependent on

[GitHub] [knox] goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag…

2019-10-03 Thread GitBox
goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag… URL: https://github.com/apache/knox/pull/143#issuecomment-537927512 @moresandeep Please check and merge this one as well. --

[GitHub] [knox] goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag…

2019-09-29 Thread GitBox
goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag… URL: https://github.com/apache/knox/pull/143#issuecomment-536410866 Test case changes have been done. Please check and merge. --

[GitHub] [knox] goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag…

2019-09-27 Thread GitBox
goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag… URL: https://github.com/apache/knox/pull/143#issuecomment-535857982 Travis build failed due to failure in test case WebsocketServerInitiatedMessageTest, however the same test case is p

[GitHub] [knox] goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag…

2019-09-20 Thread GitBox
goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag… URL: https://github.com/apache/knox/pull/143#issuecomment-533539074 @smolnar82 Test case is passing on my local build setup. However, I have increased timeout now and updated the test

[GitHub] [knox] goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag…

2019-09-20 Thread GitBox
goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag… URL: https://github.com/apache/knox/pull/143#issuecomment-533527313 @smolnar82 Done. Thanks This is an automated messag

[GitHub] [knox] goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag…

2019-09-20 Thread GitBox
goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag… URL: https://github.com/apache/knox/pull/143#issuecomment-533499116 @risdenk Rebase has no impact: bash-3.2$ git pull origin master From https://github.com/goelrajat/knox * b

[GitHub] [knox] goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag…

2019-09-18 Thread GitBox
goelrajat commented on issue #143: KNOX-1997: Adding changes to buffer messages from backend in onMessag… URL: https://github.com/apache/knox/pull/143#issuecomment-532994833 Any updates on whether this PR can be merged or something more needs to be done here. -