[GitHub] [knox] smolnar82 commented on pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…

2020-08-28 Thread GitBox


smolnar82 commented on pull request #369:
URL: https://github.com/apache/knox/pull/369#issuecomment-682435824


   There is an ongoing issue with Github Actions for a while (for some PRs it's 
intermittent, for some it's more severe). Luckily, we have Travis in place 
which proves this PR is OK to merge so I'm going to do it now.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [knox] smolnar82 commented on pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…

2020-08-27 Thread GitBox


smolnar82 commented on pull request #369:
URL: https://github.com/apache/knox/pull/369#issuecomment-681841673


   > > @arvaiadam , in the PR description you say this is needed for Oozie 5.x. 
Would not be better to create a new version within gateway-service-definitions 
(e.g. 5.0.0) and leave the previous version as-is?
   > 
   > Thanks for your feedback, i changed accordingly.
   
   Thanks, @arvaiadam! I really appreciate your fast feedback and action you've 
taken here!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [knox] smolnar82 commented on pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…

2020-08-27 Thread GitBox


smolnar82 commented on pull request #369:
URL: https://github.com/apache/knox/pull/369#issuecomment-681835861


   @moresandeep, please review this PR when you have time. Thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [knox] smolnar82 commented on pull request #369: KNOX-2436 Add new service for replacing resourceManager property duri…

2020-08-27 Thread GitBox


smolnar82 commented on pull request #369:
URL: https://github.com/apache/knox/pull/369#issuecomment-681743389


   @arvaiadam , in the PR description you say this is needed for Oozie 5.x. 
Would not be better to create a new version within 
`gateway-service-definitions` (e.g. `5.0.0`) and leave the previous version 
as-is?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org