[jira] [Work logged] (KNOX-3223) Review exclusions from PR 1114
[
https://issues.apache.org/jira/browse/KNOX-3223?focusedWorklogId=996705&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-996705
]
ASF GitHub Bot logged work on KNOX-3223:
Author: ASF GitHub Bot
Created on: 17/Dec/25 14:26
Start Date: 17/Dec/25 14:26
Worklog Time Spent: 10m
Work Description: hanicz merged PR #1133:
URL: https://github.com/apache/knox/pull/1133
Issue Time Tracking
---
Worklog Id: (was: 996705)
Time Spent: 0.5h (was: 20m)
> Review exclusions from PR 1114
> --
>
> Key: KNOX-3223
> URL: https://issues.apache.org/jira/browse/KNOX-3223
> Project: Apache Knox
> Issue Type: Task
> Components: Server
>Affects Versions: 3.0.0
>Reporter: Sandor Molnar
>Assignee: Tamás Hanicz
>Priority: Major
> Fix For: 3.0.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Last week the team switched to JDK 17 with a giant change in [PR
> 1114|https://github.com/apache/knox/pull/1114]. During code reviews we found
> that there are many "suppress" annotations ({{{}@SuppressForbidden{}}} and
> {{{}@SuppressWarnings("PMD"){}}}) were added as well as exclusions and
> ignoredNonTestScopedDependencies for static code analyzer tools.
> We should review them and make a decision if they are ok or fix the root
> cause and enable them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (KNOX-3223) Review exclusions from PR 1114
[
https://issues.apache.org/jira/browse/KNOX-3223?focusedWorklogId=996673&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-996673
]
ASF GitHub Bot logged work on KNOX-3223:
Author: ASF GitHub Bot
Created on: 17/Dec/25 12:33
Start Date: 17/Dec/25 12:33
Worklog Time Spent: 10m
Work Description: github-actions[bot] commented on PR #1133:
URL: https://github.com/apache/knox/pull/1133#issuecomment-3665148462
## Test Results
7 tests 7 ✅ 1s ⏱️
1 suites 0 💤
1 files 0 ❌
Results for commit f03bbe91.
[test-results]:data:application/gzip;base64,H4sIACujQmkC/1WMyQ6DIBRFf8Ww7kJEFPozDSAveXGgYVg1/feidcDdPecm50MAJxvIs6KPioSE8YQheRXRLTvmI65Xf+xXSMbcxYjvLOpTgMLpJqz3zu/Gp+XorbPM/fmqbVzENi5bxs0zxgwEaqa1lZRRBky3RvEepKRCDlQA75pGdEq3XJHvD0/2A5L7
Issue Time Tracking
---
Worklog Id: (was: 996673)
Time Spent: 20m (was: 10m)
> Review exclusions from PR 1114
> --
>
> Key: KNOX-3223
> URL: https://issues.apache.org/jira/browse/KNOX-3223
> Project: Apache Knox
> Issue Type: Task
> Components: Server
>Affects Versions: 3.0.0
>Reporter: Sandor Molnar
>Assignee: Tamás Hanicz
>Priority: Major
> Fix For: 3.0.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Last week the team switched to JDK 17 with a giant change in [PR
> 1114|https://github.com/apache/knox/pull/1114]. During code reviews we found
> that there are many "suppress" annotations ({{{}@SuppressForbidden{}}} and
> {{{}@SuppressWarnings("PMD"){}}}) were added as well as exclusions and
> ignoredNonTestScopedDependencies for static code analyzer tools.
> We should review them and make a decision if they are ok or fix the root
> cause and enable them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (KNOX-3223) Review exclusions from PR 1114
[
https://issues.apache.org/jira/browse/KNOX-3223?focusedWorklogId=996672&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-996672
]
ASF GitHub Bot logged work on KNOX-3223:
Author: ASF GitHub Bot
Created on: 17/Dec/25 12:12
Start Date: 17/Dec/25 12:12
Worklog Time Spent: 10m
Work Description: hanicz opened a new pull request, #1133:
URL: https://github.com/apache/knox/pull/1133
[KNOX-3223](https://issues.apache.org/jira/browse/KNOX-3223) - Remove
redundant SuppressWarnings
## What changes were proposed in this pull request?
- Removed redundant SuppressWarnings
- Replaced deprecated forbiddenapis failOnUnresolvableSignatures with
ignoreSignaturesOfMissingClasses
- Replaced forbidden Subject.getSubject(AccessController.getContext()) with
SubjectUtils.getCurrentSubject() where possible. The AccessController call is
still there is SubjectUtils however its on one place which makesa it easier to
replace with JDK18+.
- Fixed the order of a few asserts in KnoxPam and KnoxLdap tests
## How was this patch tested?
Ran clean verify locally. There are no business logic changes.
Issue Time Tracking
---
Worklog Id: (was: 996672)
Remaining Estimate: 0h
Time Spent: 10m
> Review exclusions from PR 1114
> --
>
> Key: KNOX-3223
> URL: https://issues.apache.org/jira/browse/KNOX-3223
> Project: Apache Knox
> Issue Type: Task
> Components: Server
>Affects Versions: 3.0.0
>Reporter: Sandor Molnar
>Assignee: Tamás Hanicz
>Priority: Major
> Fix For: 3.0.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Last week the team switched to JDK 17 with a giant change in [PR
> 1114|https://github.com/apache/knox/pull/1114]. During code reviews we found
> that there are many "suppress" annotations ({{{}@SuppressForbidden{}}} and
> {{{}@SuppressWarnings("PMD"){}}}) were added as well as exclusions and
> ignoredNonTestScopedDependencies for static code analyzer tools.
> We should review them and make a decision if they are ok or fix the root
> cause and enable them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
