Re: [PR] KNOX-3171 - Remove trailing slash for yarn proxy rewrite [knox]
Kimahriman commented on PR #1066: URL: https://github.com/apache/knox/pull/1066#issuecomment-3675201674 Yeah we haven't updated our history server to spark 4 yet because of the Jakarta thing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3171 - Remove trailing slash for yarn proxy rewrite [knox]
smolnar82 commented on PR #1066: URL: https://github.com/apache/knox/pull/1066#issuecomment-3675176673 You may also want to check out https://issues.apache.org/jira/browse/KNOX-3231. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3171 - Remove trailing slash for yarn proxy rewrite [knox]
pan3793 commented on PR #1066: URL: https://github.com/apache/knox/pull/1066#issuecomment-3675030991 so do I ... good to know it's not a backport issue caused by us ... anyway, this is not a big deal, thank you again for making it work with Spark 4 > I've just been manually inserting the missing `executors/` part when I need to see it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3171 - Remove trailing slash for yarn proxy rewrite [knox]
Kimahriman commented on PR #1066: URL: https://github.com/apache/knox/pull/1066#issuecomment-3674995016 Yes that's another issue we've seen. I think that might be partially on the Spark side because the links end with a trailing slash directly from Spark which is awkward. Haven't looked into exactly why that breaks the Knox rewrites -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3171 - Remove trailing slash for yarn proxy rewrite [knox]
pan3793 commented on PR #1066: URL: https://github.com/apache/knox/pull/1066#issuecomment-3674955451 @Kimahriman, does the "Thread Dump" of the "Executors" tab work correctly on your side? It seems broken on my side :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3171 - Remove trailing slash for yarn proxy rewrite [knox]
Kimahriman commented on PR #1066: URL: https://github.com/apache/knox/pull/1066#issuecomment-3617294670 > @Kimahriman and @pan3793 Can you close the JIRA and also update it with the proper release version (`2.1.0`) Thank you a lot for your contribution the Apache Knox! Closed as resolved and set the version to 3.0.0 since it looks like 2.1.0 was already released? > feedback - applied this patch to our internal cluster, now Knox works as expected with Spark 4.0 and 4.1 Thanks for verifying! We've also hit another error unrelated to this on the structured streaming page for a single stream. I'll write up an issue but basically there's a nested module-based script in the HTML that gets rewritten from ```html
Re: [PR] KNOX-3171 - Remove trailing slash for yarn proxy rewrite [knox]
moresandeep commented on PR #1066: URL: https://github.com/apache/knox/pull/1066#issuecomment-3616645355 @Kimahriman and @pan3793 Can you close the JIRA and also update it with the proper release version (`2.1.0`) Thank you a lot for your contribution the Apache Knox! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3171 - Remove trailing slash for yarn proxy rewrite [knox]
moresandeep commented on PR #1066: URL: https://github.com/apache/knox/pull/1066#issuecomment-3616639265 Perfect, thank you so much @Kimahriman and @pan3793 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3171 - Remove trailing slash for yarn proxy rewrite [knox]
moresandeep merged PR #1066: URL: https://github.com/apache/knox/pull/1066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3171 - Remove trailing slash for yarn proxy rewrite [knox]
pan3793 commented on PR #1066: URL: https://github.com/apache/knox/pull/1066#issuecomment-3615794691 feedback - applied this patch to our internal cluster, now Knox works as expected with Spark 4.0 and 4.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3171 - Remove trailing slash for yarn proxy rewrite [knox]
smolnar82 commented on PR #1066: URL: https://github.com/apache/knox/pull/1066#issuecomment-3602268990 @Kimahriman - Can you please rebase your change? We have switched to JDK17 last week and I want all pending PRs to be re-ran to be safe. @moresandeep - Are you satisfied with the above explanation from @Kimahriman ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3171 - Remove trailing slash for yarn proxy rewrite [knox]
Kimahriman commented on PR #1066: URL: https://github.com/apache/knox/pull/1066#issuecomment-3128486761 It's not related to the version of YARN, it's a new version of spark that hits an edge case that has probably always existed. I don't see why you would ever want to insert a trailing slash when it didn't already exist, and I don't see any of the other rewrites for either of those services that do the same thing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3171 - Remove trailing slash for yarn proxy rewrite [knox]
moresandeep commented on PR #1066: URL: https://github.com/apache/knox/pull/1066#issuecomment-3128431129 @Kimahriman looks like this is for newer version of Yarn instead of updating 3.0.0 can you create a new version 4.0.0 and make changes there? We want to make sure that older version work as well and there is no regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3171 - Remove trailing slash for yarn proxy rewrite [knox]
Kimahriman commented on PR #1066: URL: https://github.com/apache/knox/pull/1066#issuecomment-3128258817 > @Kimahriman - I see you modified both 2.7.0 and 3.0.0 too. Does it mean you tested both versions? 3.0.0 is for the V2 UI, and yeah confirmed it also has the issue and this also fixes in the same way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3171 - Remove trailing slash for yarn proxy rewrite [knox]
smolnar82 commented on PR #1066: URL: https://github.com/apache/knox/pull/1066#issuecomment-3126069488 @Kimahriman - I see you modified both 2.7.0 and 3.0.0 too. Does it mean you tested both versions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3171 - Remove trailing slash for yarn proxy rewrite [knox]
smolnar82 commented on PR #1066: URL: https://github.com/apache/knox/pull/1066#issuecomment-3126064989 Hi @moresandeep ! Whenever you have time, can you please review this change? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
