Re: [PR] KNOX-3243 : Added Ambari 3.0.0 support [knox]
harshith-21 commented on PR #1140: URL: https://github.com/apache/knox/pull/1140#issuecomment-4067828452 Thanks !! @lmccay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3243 : Added Ambari 3.0.0 support [knox]
lmccay commented on PR #1140: URL: https://github.com/apache/knox/pull/1140#issuecomment-4063829718 @harshith-21 - this has been merged and will be available in the next Knox release. Thank you for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3243 : Added Ambari 3.0.0 support [knox]
lmccay merged PR #1140: URL: https://github.com/apache/knox/pull/1140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3243 : Added Ambari 3.0.0 support [knox]
harshith-21 commented on PR #1140: URL: https://github.com/apache/knox/pull/1140#issuecomment-4057403062 @lmccay, apologies, i thought i did it. i found some of the screenshots i have taken before and have attached in same jira, including a knox home page picture with new ambari version. please check it [here](https://issues.apache.org/jira/browse/KNOX-3243) and help me with reviewing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3243 : Added Ambari 3.0.0 support [knox]
lmccay commented on PR #1140: URL: https://github.com/apache/knox/pull/1140#issuecomment-4057316034 @harshith-21 - thanks for your continued commitment to this. I don't see that you have satisfied the asks from @smolnar82 above for the additional screenshots including the homepage though. Can you take a look? Of course, take on the airflow tasks as well if you like! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3243 : Added Ambari 3.0.0 support [knox]
harshith-21 commented on PR #1140: URL: https://github.com/apache/knox/pull/1140#issuecomment-4022554366 @lmccay , apologies for direct mention. This PR has been pending for a bit after updates, so I just wanted to kindly ask if you might be able to help with a review when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3243 : Added Ambari 3.0.0 support [knox]
harshith-21 commented on PR #1140: URL: https://github.com/apache/knox/pull/1140#issuecomment-3918073311 @moresandeep, please review the PR again, have done the suggested changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3243 : Added Ambari 3.0.0 support [knox]
harshith-21 commented on PR #1140: URL: https://github.com/apache/knox/pull/1140#issuecomment-3794274640 on a side note, the [airflow integration](https://github.com/apache/knox/pull/182) seem to be abandoned, can i give it a try too :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3243 : Added Ambari 3.0.0 support [knox]
harshith-21 commented on code in PR #1140: URL: https://github.com/apache/knox/pull/1140#discussion_r2718244587 ## gateway-service-definitions/src/main/resources/services/ambari/3.0.0/service.xml: ## @@ -0,0 +1,66 @@ + + + +API +/ambari/api +Apache Ambari API +The Ambari API facilitates the management and monitoring of the resources of an Apache Hadoop cluster. + + +Fetch all Ambari-managed clusters +GET +v1/clusters + + +Get the DATANODE component resource for the HDFS service of the cluster named 'c1' +GET +v1/clusters/c1/services/HDFS/components/DATANODE + + +Create the HDFS service. +POST +v1/clusters/c1/services/HDFS + + +Delete the cluster named 'c1' +DELETE +v1/clusters/c1 + + +See the Apache Ambari's REST API documentation here + https://github.com/apache/ambari/blob/trunk/ambari-server/docs/api/v1/index.md + + + + + + Review Comment: So, most of the files / code added is a copy of existing `gateway-service-definitions/src/main/resources/services/ambari/2.2.0` and I believe this line ``` ``` is present in the `ambari/2.2.0/service.xml` And the reason i believe it is that way is to avoid double auth from knox and then ambari. please correct me if missed anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3243 : Added Ambari 3.0.0 support [knox]
moresandeep commented on code in PR #1140: URL: https://github.com/apache/knox/pull/1140#discussion_r2718201425 ## gateway-service-definitions/src/main/resources/services/ambariui/3.0.0/service.xml: ## @@ -0,0 +1,107 @@ + + + +UI +/ambari/ +Apache Ambari Web UI +The Apache Ambari project is aimed at making Hadoop management simpler by developing software for provisioning, managing, and monitoring Apache Hadoop clusters. +Ambari provides an intuitive, easy-to-use Hadoop management web UI backed by its RESTful APIs. + + + + + + + + + + + + + + + + + + + + + + + + + + + Review Comment: instead of specifying file names such as`main.js` can you not use ** ? this would help you keep rules shorter and prevent issues when file name changes. ## gateway-service-definitions/src/main/resources/services/ambari/3.0.0/service.xml: ## @@ -0,0 +1,66 @@ + + + +API +/ambari/api +Apache Ambari API +The Ambari API facilitates the management and monitoring of the resources of an Apache Hadoop cluster. + + +Fetch all Ambari-managed clusters +GET +v1/clusters + + +Get the DATANODE component resource for the HDFS service of the cluster named 'c1' +GET +v1/clusters/c1/services/HDFS/components/DATANODE + + +Create the HDFS service. +POST +v1/clusters/c1/services/HDFS + + +Delete the cluster named 'c1' +DELETE +v1/clusters/c1 + + +See the Apache Ambari's REST API documentation here + https://github.com/apache/ambari/blob/trunk/ambari-server/docs/api/v1/index.md + + + + + + Review Comment: @harshith-21 why is the authentication Anonymous? ## gateway-service-definitions/src/main/resources/services/ambariui/3.0.0/service.xml: ## @@ -0,0 +1,107 @@ + + + +UI +/ambari/ +Apache Ambari Web UI +The Apache Ambari project is aimed at making Hadoop management simpler by developing software for provisioning, managing, and monitoring Apache Hadoop clusters. +Ambari provides an intuitive, easy-to-use Hadoop management web UI backed by its RESTful APIs. + + + + Review Comment: Same as above, this should not be Anonymous ## gateway-service-definitions/src/main/resources/services/ambariws/3.0.0/service.xml: ## @@ -0,0 +1,33 @@ + + + + + Review Comment: Same as above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3243 : Added Ambari 3.0.0 support [knox]
harshith-21 commented on code in PR #1140: URL: https://github.com/apache/knox/pull/1140#discussion_r2718296564 ## gateway-service-definitions/src/main/resources/services/ambariui/3.0.0/service.xml: ## @@ -0,0 +1,107 @@ + + + +UI +/ambari/ +Apache Ambari Web UI +The Apache Ambari project is aimed at making Hadoop management simpler by developing software for provisioning, managing, and monitoring Apache Hadoop clusters. +Ambari provides an intuitive, easy-to-use Hadoop management web UI backed by its RESTful APIs. + + + + + + + + + + + + + + + + + + + + + + + + + + + Review Comment: makes sense, ill get back after testing this. thanks for the suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3243 : Added Ambari 3.0.0 support [knox]
smolnar82 commented on PR #1140: URL: https://github.com/apache/knox/pull/1140#issuecomment-3786060980 > @hanicz , Ive added few details in the [jira description](https://issues.apache.org/jira/projects/KNOX/issues/KNOX-3243) Thanks, @harshith-21 ! Can you please attach 2-3 more screenshots from different areas on the new Ambari UI (via the Knox Gateway)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3243 : Added Ambari 3.0.0 support [knox]
harshith-21 commented on code in PR #1140: URL: https://github.com/apache/knox/pull/1140#discussion_r2718252409 ## gateway-service-definitions/src/main/resources/services/ambariui/3.0.0/service.xml: ## @@ -0,0 +1,107 @@ + + + +UI +/ambari/ +Apache Ambari Web UI +The Apache Ambari project is aimed at making Hadoop management simpler by developing software for provisioning, managing, and monitoring Apache Hadoop clusters. +Ambari provides an intuitive, easy-to-use Hadoop management web UI backed by its RESTful APIs. + + + + Review Comment: [same as above ](https://github.com/apache/knox/pull/1140#discussion_r2718244587) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3243 : Added Ambari 3.0.0 support [knox]
harshith-21 commented on PR #1140: URL: https://github.com/apache/knox/pull/1140#issuecomment-3785809207 @hanicz , Ive added few details in the [jira description](https://issues.apache.org/jira/projects/KNOX/issues/KNOX-3243) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3243 : Added Ambari 3.0.0 support [knox]
harshith-21 commented on PR #1140: URL: https://github.com/apache/knox/pull/1140#issuecomment-3783283893 Hi @hanicz, Sure ill add the more details in ticket and a few screenshots here too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3243 : Added Ambari 3.0.0 support [knox]
github-actions[bot] commented on PR #1140: URL: https://github.com/apache/knox/pull/1140#issuecomment-3783283376 ## Test Results 7 tests 7 ✅ 1s ⏱️ 1 suites 0 💤 1 files 0 ❌ Results for commit 83a6b468. [test-results]:data:application/gzip;base64,H4sIABbncWkC/1WMyw6DIBBFf8Ww7mKs+OrPNANiMqlKM8DK9N+Lb9zdc25yZtHTYJx4ZfkjEy6QP6ELjJ7stGM8/HLVx367oPVdfOgbBZyiRxpuwjBb3g2H6egtM81tfNVWTmIrpy1tx5F8BNEUWClZNaBaKcGgUXkBJcTZQg0dPEtELaUWvz9wa8nx+w== -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KNOX-3243 : Added Ambari 3.0.0 support [knox]
hanicz commented on PR #1140: URL: https://github.com/apache/knox/pull/1140#issuecomment-3783217713 - Please add a few screenshots of the UI working. - Please give a few details on the changes that's different in this version compared to the last. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
