How do people feel about this warning?
warning: function 'kudu::InsertLoadgen::InserterThread' has a definition
with different parameter names
[readability-inconsistent-declaration-parameter-name]
void InserterThread(Generator::Mode gen_mode, int64_t seed,
^
gen_seed
src/kudu/tools/insert-generate
Personally I haven't seen much of a need for abbreviated parameter
names. I'd vote for keeping the warning.
On Mon, Sep 19, 2016 at 2:14 PM, Todd Lipcon wrote:
> How do people feel about this warning?
>
> warning: function 'kudu::InsertLoadgen::InserterThread' has a definition
> with different pa
I'd vote to keep as well.
- Dan
On Mon, Sep 19, 2016 at 2:19 PM, Adar Dembo wrote:
> Personally I haven't seen much of a need for abbreviated parameter
> names. I'd vote for keeping the warning.
>
> On Mon, Sep 19, 2016 at 2:14 PM, Todd Lipcon wrote:
> > How do people feel about this warning?
+1 to keep, abbreviating from the definition seems evil.
-david
On Mon, Sep 19, 2016 at 2:19 PM, Adar Dembo wrote:
> Personally I haven't seen much of a need for abbreviated parameter
> names. I'd vote for keeping the warning.
>
> On Mon, Sep 19, 2016 at 2:14 PM, Todd Lipcon wrote:
> > How do
