Review Request 37760: LENS-755: rename LogicalTableCrudCommand to ConceptualTableCrudCommand and PhysicalTableCrudCommand to LogicalTableCrudCommand

2015-08-25 Thread Rajat Khandelwal
/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a1ccec682330d48f116e06a085d07db179888327 Diff: https://reviews.apache.org/r/37760/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 39651: LENS-845: Take regex rename arguments in columnar sql rewriter

2015-10-26 Thread Rajat Khandelwal
e94c2f35f998796dd6e40d440db75305c56b9f1d lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 31c7dadec795141769d12448c9381a6a73482f61 Diff: https://reviews.apache.org/r/39651/diff/ Testing --- Thanks, Rajat Khandelwal

Review Request 39651: LENS-845: Add Driver level UDF rename

2015-10-26 Thread Rajat Khandelwal
://reviews.apache.org/r/39651/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

2015-10-27 Thread Rajat Khandelwal
lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 163ed42daf49a182ead3eca048b3ada6e53e2c0b Diff: https://reviews.apache.org/r/39680/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

2015-10-27 Thread Rajat Khandelwal
] [INFO] Total time: 23:47.270s [INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015 [INFO] Final Memory: 179M/1101M [INFO] Thanks, Rajat Khandelwal

Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

2015-10-27 Thread Rajat Khandelwal
/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 39652: LENS-847 Columnar JDBC Rewriter in incorrectly pushing filter against wrong alias when fact columns map to a single dimension

2015-10-27 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39652/#review104163 --- Ship it! Ship It! - Rajat Khandelwal On Oct. 27, 2015, 12:17

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

2015-10-27 Thread Rajat Khandelwal
] [INFO] Total time: 23:47.270s [INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015 [INFO] Final Memory: 179M/1101M [INFO] jdbc driver test cases and checkstyle passed Thanks, Rajat

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

2015-10-27 Thread Rajat Khandelwal
] [INFO] Total time: 23:47.270s [INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015 [INFO] Final Memory: 179M/1101M [INFO] jdbc driver test cases and checkstyle passed Thanks, Rajat Khandelwal

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

2015-10-27 Thread Rajat Khandelwal
] jdbc driver test cases and checkstyle passed Thanks, Rajat Khandelwal

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

2015-10-27 Thread Rajat Khandelwal
] jdbc driver test cases and checkstyle passed Thanks, Rajat Khandelwal

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

2015-10-27 Thread Rajat Khandelwal
] jdbc driver test cases and checkstyle passed Thanks, Rajat Khandelwal

Re: Review Request 39686: LENS-849 : Fix NPE in CandidateTableResolver with expression dimension

2015-10-27 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39686/#review104168 --- Ship it! Ship It! - Rajat Khandelwal On Oct. 27, 2015, 7:34

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

2015-10-27 Thread Rajat Khandelwal
] jdbc driver test cases and checkstyle passed Thanks, Rajat Khandelwal

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

2015-10-28 Thread Rajat Khandelwal
] jdbc driver test cases and checkstyle passed Thanks, Rajat Khandelwal

Re: Review Request 39651: LENS-845: Take regex rename arguments in columnar sql rewriter

2015-10-26 Thread Rajat Khandelwal
eviews.apache.org/r/39651/#review103996 --- On Oct. 26, 2015, 5:56 p.m., Rajat Khandelwal wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39651/ > ---

Re: Review Request 39651: LENS-845: Take regex rename arguments in columnar sql rewriter

2015-10-26 Thread Rajat Khandelwal
/TestColumnarSQLRewriter.java 31c7dadec795141769d12448c9381a6a73482f61 lens-driver-jdbc/src/test/resources/jdbcdriver-site.xml 1dc0a85b485232ebb3513f910899d34323042605 Diff: https://reviews.apache.org/r/39651/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 39685: LENS-850 Queries with column name alias like "year" fails on some DBs

2015-10-27 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39685/#review104164 --- Ship it! Ship It! - Rajat Khandelwal On Oct. 27, 2015, 7 p.m

Re: Review Request 39680: LENS-848: Allow JDBC driver to take connection properties in configuration

2015-10-27 Thread Rajat Khandelwal
: 23:47.270s [INFO] Finished at: Tue Oct 27 08:04:55 UTC 2015 [INFO] Final Memory: 179M/1101M [INFO] jdbc driver test cases and checkstyle passed Thanks, Rajat Khandelwal

Re: Review Request 39686: LENS-849 : Fix NPE in CandidateTableResolver with expression dimension

2015-10-27 Thread Rajat Khandelwal
(line 77) <https://reviews.apache.org/r/39686/#comment162443> The function doesn't return -1 now. - Rajat Khandelwal On Oct. 27, 2015, 7 p.m., Amareshwari Sriramadasu wrote: > > --- > This is an automatically g

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-09 Thread Rajat Khandelwal
/parse/TestQuery.java 8e35ea9bd9cd727cc25ff011a03d6a38a6f0229f Diff: https://reviews.apache.org/r/39895/diff/ Testing --- Tested for some queries in the test cases themselves. Need to add proper asserts. Thanks, Rajat Khandelwal

Re: Review Request 39911: LENS-760 : Session close should not result in running query failures

2015-11-09 Thread Rajat Khandelwal
/HiveDriver.java (line 1260) <https://reviews.apache.org/r/39911/#comment164275> Add test cases for not closeable? - Rajat Khandelwal On Nov. 9, 2015, 12:28 a.m., Deepak Barr wrote: > > --- > This is an automatically g

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-09 Thread Rajat Khandelwal
8e35ea9bd9cd727cc25ff011a03d6a38a6f0229f Diff: https://reviews.apache.org/r/39895/diff/ Testing --- Tested for some queries in the test cases themselves. Need to add proper asserts. Thanks, Rajat Khandelwal

Re: Review Request 39390: LENS-828: Add derived cube validation

2015-11-09 Thread Rajat Khandelwal
[INFO] Final Memory: 194M/2045M [INFO] Thanks, Rajat Khandelwal

Re: November report

2015-11-09 Thread Rajat Khandelwal
+1

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-11-12 Thread Rajat Khandelwal
] Total time: 23:16.273s [INFO] Finished at: Fri Oct 30 11:23:40 UTC 2015 [INFO] Final Memory: 198M/2047M [INFO] Thanks, Rajat Khandelwal

Re: Lens Hangout Today - Thursday 7 PM IST

2015-11-12 Thread Rajat Khandelwal
Welcome Raj Feel free to ask any question, basic or advanced. Questions you ask will help us understand the gaps in our documentation. :)

Re: Review Request 40333: LENS - 864

2015-11-16 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40333/#review106663 --- Ship it! Ship It! - Rajat Khandelwal On Nov. 16, 2015, 1:11

Re: Review Request 40333: LENS - 864

2015-11-16 Thread Rajat Khandelwal
tps://reviews.apache.org/r/40333/#comment165351> Can you mention the changes as experienced on UI? And testing done for those? - Rajat Khandelwal On Nov. 16, 2015, 1:11 a.m., Ankeet Maini wrote: > > --- > This is an automatica

Re: Review Request 40333: LENS - 864

2015-11-15 Thread Rajat Khandelwal
) <https://reviews.apache.org/r/40333/#comment165314> This is just for optimization, right? - Rajat Khandelwal On Nov. 16, 2015, 1:11 a.m., Ankeet Maini wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Question about Installation

2015-11-12 Thread Rajat Khandelwal
Hi Raj I don't see any issues, but jus to re iterate, here's what I did after which I verified the server to be up. rajat.khandelwal@lappy:~/apache-lens-2.3.0-beta-bin [0] $ ls LICENSE LICENSE-CDDLv1.1-GPLv2_withCPE LICENSE-GPLv3 README LICENSE-CDDL-v1.0 LICENSE-EDL LICENSE-LGPL client

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-17 Thread Rajat Khandelwal
( testcube . alias1 ) HAVING (count(( testcube . alias3 )) > 10 ) ORDER BY testcube . alias1 desc LIMIT 5 ``` - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3989

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-17 Thread Rajat Khandelwal
] Thanks, Rajat Khandelwal

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-17 Thread Rajat Khandelwal
8e35ea9bd9cd727cc25ff011a03d6a38a6f0229f Diff: https://reviews.apache.org/r/39895/diff/ Testing --- Tested for some queries in the test cases themselves. Need to add proper asserts. Thanks, Rajat Khandelwal

Re: Review Request 39390: LENS-828: Add derived cube validation

2015-11-17 Thread Rajat Khandelwal
[INFO] Final Memory: 194M/2045M [INFO] Thanks, Rajat Khandelwal

Re: Review Request 40383: Updating release doc information

2015-11-17 Thread Rajat Khandelwal
tps://reviews.apache.org/r/40383/#comment165668> No need to mention review request here. jira should be enough to point the readers. - Rajat Khandelwal On Nov. 17, 2015, 4:51 p.m., Raju Bairishetti wrote: > > --- > This is a

Re: Review Request 39390: LENS-828: Add derived cube validation

2015-11-17 Thread Rajat Khandelwal
[INFO] Final Memory: 194M/2045M [INFO] Thanks, Rajat Khandelwal

Re: Review Request 40383: Updating release doc information

2015-11-17 Thread Rajat Khandelwal
> On Nov. 17, 2015, 7:25 p.m., Rajat Khandelwal wrote: > > src/site/apt/releases/release-history.apt, line 53 > > <https://reviews.apache.org/r/40383/diff/1/?file=1128106#file1128106line53> > > > > No need to mention review request here. jira should be

Re: Review Request 39390: LENS-828: Add derived cube validation

2015-11-17 Thread Rajat Khandelwal
] [INFO] Total time: 23:04.131s [INFO] Finished at: Tue Nov 17 17:24:12 UTC 2015 [INFO] Final Memory: 198M/2050M [INFO] Thanks, Rajat Khandelwal

Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-10-30 Thread Rajat Khandelwal
f67fc260bf9b5964189df2a5e083bd40e8f90062 lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java dc11b4ce4598bf6d1dc2dc7ad814bd8757ee34fd Diff: https://reviews.apache.org/r/39809/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 39891: Change /savedqueries/parameters call to POST

2015-11-03 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39891/#review104890 --- Ship it! Ship It! - Rajat Khandelwal On Nov. 3, 2015, 12:07

Review Request 39893: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-03 Thread Rajat Khandelwal
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d7484d83dc0a3f7810ab2109ec882b19b940803b Diff: https://reviews.apache.org/r/39893/diff/ Testing --- Thanks, Rajat Khandelwal

New Committers: Sushil Mohanty, Pranav Kumar Agarwal, Deepak Barr, Amruth S

2015-11-03 Thread Rajat Khandelwal
The PMC for Apache Lens has asked Sushil, Pranav, Deepak and Amruth to become Lens Committers. We are pleased to announce that they have accepted. Being a committer enables access to commit to the source repositories and binding votes for code reviews. Join me in Congratulating them.

Re: Review Request 39867: LENS - 856: Better error propagation

2015-11-03 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39867/#review104897 --- Ship it! Ship It! - Rajat Khandelwal On Nov. 3, 2015, 3:40 p.m

Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-03 Thread Rajat Khandelwal
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java d7484d83dc0a3f7810ab2109ec882b19b940803b Diff: https://reviews.apache.org/r/39895/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-10-30 Thread Rajat Khandelwal
[INFO] Final Memory: 198M/2047M [INFO] Thanks, Rajat Khandelwal

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-11-02 Thread Rajat Khandelwal
] Total time: 23:16.273s [INFO] Finished at: Fri Oct 30 11:23:40 UTC 2015 [INFO] Final Memory: 198M/2047M [INFO] Thanks, Rajat Khandelwal

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-11-02 Thread Rajat Khandelwal
or? Just simplifying the regular expression. - Rajat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39809/#review104567 --- On Nov. 2, 2015,

Re: Test run failure

2015-11-04 Thread Rajat Khandelwal
Yes. We've encountered this issue earlier. I've even discussed it on stack overflow: http://stackoverflow.com/questions/32988172/java-creating-a-date-in-pst-returns-a-date-in-pdt/32988326?noredirect=1#comment53803610_32988326 Simple solution would be to run the test cases in any other time zone

Re: Review Request 39576: LENS-833 : Limit number of open sessions per user on session service

2015-11-02 Thread Rajat Khandelwal
/BaseLensService.java (line 281) <https://reviews.apache.org/r/39576/#comment162941> What if it's already 0? - Rajat Khandelwal On Oct. 31, 2015, 5:54 a.m., Raju Bairishetti wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 39809: LENS-719: Allow fact start time to be specified for a storage and a update period

2015-11-02 Thread Rajat Khandelwal
] Total time: 23:16.273s [INFO] Finished at: Fri Oct 30 11:23:40 UTC 2015 [INFO] Final Memory: 198M/2047M [INFO] Thanks, Rajat Khandelwal

Re: Review Request 39842: Ability to load different instances of same driver class

2015-11-02 Thread Rajat Khandelwal
/lens/server/query/QueryExecutionServiceImpl.java (line 423) <https://reviews.apache.org/r/39842/#comment162944> Should we throw an error here? It'll be better to fail fast. - Rajat Khandelwal On Nov. 2, 2015, 9:38

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-03 Thread Rajat Khandelwal
/ Testing (updated) --- Tested for some queries in the test cases themselves. Need to add proper asserts. Thanks, Rajat Khandelwal

Re: New Committers: Sushil Mohanty, Pranav Kumar Agarwal, Deepak Barr, Amruth S

2015-11-03 Thread Rajat Khandelwal
amareshwarisr . <amareshw...@gmail.com> >>> wrote: >>> >>> > Congratulations to all of you! Welcome on board! >>> > >>> > On Tue, Nov 3, 2015 at 5:04 PM, Rajat Khandelwal <pro...@apache.org> >>> > wrote: >>&

Re: Review Request 39191: LENS-615 Refactoring of testQueryCommands test case

2015-10-14 Thread Rajat Khandelwal
/TestLensQueryCommands.java (line 416) <https://reviews.apache.org/r/39191/#comment160328> can you take care of the TODO? - Rajat Khandelwal On Oct. 14, 2015, 7 a.m., Gabor Liptak wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 39311: LENS-820: Add relative end time for facts

2015-10-14 Thread Rajat Khandelwal
/MetastoreConstants.java da47fa5cb1fb5fbf6065b45de8e6f413c01bf779 Diff: https://reviews.apache.org/r/39311/diff/ Testing --- Thanks, Rajat Khandelwal

Review Request 39311: LENS-820: Add relative end time for facts

2015-10-14 Thread Rajat Khandelwal
da47fa5cb1fb5fbf6065b45de8e6f413c01bf779 Diff: https://reviews.apache.org/r/39311/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 39311: LENS-820: Add relative end time for facts

2015-10-14 Thread Rajat Khandelwal
/MetastoreConstants.java da47fa5cb1fb5fbf6065b45de8e6f413c01bf779 lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java PRE-CREATION Diff: https://reviews.apache.org/r/39311/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 39314: LENS-815 : Query list api should have an option to filter by driver

2015-10-14 Thread Rajat Khandelwal
/QueryExecutionServiceImpl.java (line 2076) <https://reviews.apache.org/r/39314/#comment160331> Should we do a contains check instead of equality? As a cli user I doubt I'd like to give whole class name to get queries of a driver. - Rajat Khandelwal On Oct. 14, 2015, 4:33 p.m., Deepa

Re: Review Request 39311: LENS-820: Add relative end time for facts

2015-10-14 Thread Rajat Khandelwal
/MetastoreConstants.java da47fa5cb1fb5fbf6065b45de8e6f413c01bf779 lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java PRE-CREATION Diff: https://reviews.apache.org/r/39311/diff/ Testing (updated) --- all cube tests passed Thanks, Rajat Khandelwal

Re: Review Request 39311: LENS-820: Add relative end time for facts

2015-10-14 Thread Rajat Khandelwal
] Final Memory: 194M/2045M [INFO] Thanks, Rajat Khandelwal

Re: October report

2015-10-08 Thread Rajat Khandelwal
+1 On Mon, Oct 5, 2015 at 3:58 PM amareshwarisr . wrote: > Hi all, > > I have put up report for the month of October - > https://cwiki.apache.org/confluence/display/LENS/October%2C2015. Let me > know if you have any comments. > > Will submit report to the board tomorrow.

Re: Review Request 38920: LENS-797: Improve CLI documentation to mention the helpful role of pressing tab while writing commands

2015-10-08 Thread Rajat Khandelwal
be93b8cfe982fcf60b13dbd3abaa15879537c3fd Diff: https://reviews.apache.org/r/38920/diff/ Testing --- Thanks, Rajat Khandelwal

Review Request 39127: LENS-807: Priority is not getting set in QueryContext. It's always NORMAL

2015-10-08 Thread Rajat Khandelwal
0c980a20953efc6c2d7cc17c97b1552c64a8eb5f lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java ac942077d78515404b83f4a02f841b73dd39e3df Diff: https://reviews.apache.org/r/39127/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 39127: LENS-807: Priority is not getting set in QueryContext. It's always NORMAL

2015-10-08 Thread Rajat Khandelwal
Oct 08 12:59:09 UTC 2015 [INFO] Final Memory: 194M/2044M [INFO] Thanks, Rajat Khandelwal

Re: Review Request 39161: LENS-292 : Query result retention policy

2015-10-16 Thread Rajat Khandelwal
/QueryExecutionServiceImpl.java (lines 1139 - 1140) <https://reviews.apache.org/r/39161/#comment160718> Constructor can take conf instead of a separate method. - Rajat Khandelwal On Oct. 16, 2015, 3:14 p.m., Deepak Barr

Review Request 39390: LENS-828: Add derived cube validation

2015-10-16 Thread Rajat Khandelwal
--- Thanks, Rajat Khandelwal

Re: Review Request 39161: LENS-292 : Query result retention policy

2015-10-16 Thread Rajat Khandelwal
va/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1098) <https://reviews.apache.org/r/39161/#comment160714> add purger thread to health check of execution service. - Rajat Khandelwal On Oct. 16, 2015, 3:14 p.m., Deepa

Review Request 39394: LENS-830: Checkstyle version should be picked from project version

2015-10-16 Thread Rajat Khandelwal
/browse/LENS-830 Repository: lens Description --- Diffs - pom.xml 714003835bccc217eb32e7c4ee782e1e6aacc434 Diff: https://reviews.apache.org/r/39394/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 39390: LENS-828: Add derived cube validation

2015-10-16 Thread Rajat Khandelwal
] [INFO] Total time: 24:32.375s [INFO] Finished at: Fri Oct 16 11:15:05 UTC 2015 [INFO] Final Memory: 194M/2045M [INFO] Thanks, Rajat Khandelwal

Re: Review Request 39314: LENS-815 : Query list api should have an option to filter by driver

2015-10-16 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39314/#review102910 --- Ship it! Ship It! - Rajat Khandelwal On Oct. 16, 2015, 3:20

Re: Review Request 39434: LENS-832 : Fix recovery for Queued queries

2015-10-20 Thread Rajat Khandelwal
/QueryExecutionServiceImpl.java (line 2331) <https://reviews.apache.org/r/39434/#comment161207> there's a wrapper `setSelectedDriverQuery` for it. Can we use that? - Rajat Khandelwal On Oct. 19, 2015, 3:56 p.m., Amareshwari Sriramadasu

Re: Review Request 39483: LENS-838 : Literals with escaped quotes are not honoured in columnarSQLRewriter

2015-10-21 Thread Rajat Khandelwal
/TestColumnarSQLRewriter.java (lines 1028 - 1038) <https://reviews.apache.org/r/39483/#comment161398> Can we make the test case simpler? As in a simpler query can also test the feature added. - Rajat Khandelwal On Oct. 20, 2015, 10:10 p.m., Sushil Mohanty

Re: Review Request 39314: LENS-815 : Query list api should have an option to filter by driver

2015-10-14 Thread Rajat Khandelwal
add param here. lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java (line 109) <https://reviews.apache.org/r/39314/#comment160375> param update - Rajat Khandelwal On Oct. 14

Re: Review Request 39315: LENS-821:Filters with comma in IN filters not replacing table alias properly

2015-10-14 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39315/#review102625 --- Ship it! Ship It! - Rajat Khandelwal On Oct. 14, 2015, 5:41

Re: Review Request 38521: LENS-607: Fix Test failures in java8

2015-10-09 Thread Rajat Khandelwal
comparison in upper case and then `enum.getName()` can be used which does no computation. lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java (line 81) <https://reviews.apache.org/r/38521/#comment159562> use `assertEquals` - Rajat Khandelwal

Re: Review Request 38521: LENS-607: Fix Test failures in java8

2015-10-09 Thread Rajat Khandelwal
/TestLensCubeCommands.java (lines 126 - 130) <https://reviews.apache.org/r/38521/#comment159567> Can we do a set compare? `new HashSet(joinChains.getJoinChain())` - Rajat Khandelwal On Oct. 9, 2015, 2:38 p.m., Raju Bairishetti

Re: Review Request 39221: LENS-533 : Update critical metrics on monitoring doc

2015-10-12 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39221/#review102216 --- Ship it! Ship It! - Rajat Khandelwal On Oct. 12, 2015, 12:21

Re: Review Request 38521: LENS-607: Fix Test failures in java8

2015-10-12 Thread Rajat Khandelwal
che.org/r/38521/#comment159789> let's also implement `toString` function. lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java (lines 94 - 110) <https://reviews.apache.org/r/38521/#comment159786> Can we use `TestQuery` here? - Rajat Khandelwal

Re: Review Request 39127: LENS-807: Priority is not getting set in QueryContext. It's always NORMAL

2015-10-12 Thread Rajat Khandelwal
] [INFO] Total time: 25:23.999s [INFO] Finished at: Thu Oct 08 12:59:09 UTC 2015 [INFO] Final Memory: 194M/2044M [INFO] Thanks, Rajat Khandelwal

Re: Review Request 38521: LENS-607: Fix Test failures in java8

2015-10-12 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/#review102233 --- Ship it! Ship It! - Rajat Khandelwal On Oct. 12, 2015, 1:53

Re: Review Request 39233: LENS-816: ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries and getQueryCount

2015-10-12 Thread Rajat Khandelwal
/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java PRE-CREATION Diff: https://reviews.apache.org/r/39233/diff/ Testing --- Thanks, Rajat Khandelwal

Review Request 39233: LENS-816: ThreadSafeEstimatedQueryCollection is ignoring driver argument in getQueries and getQueryCount

2015-10-12 Thread Rajat Khandelwal
/ThreadSafeEstimatedQueryCollection.java 5d243798ebfe221a83afdbfc2ac42b3064244476 lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java PRE-CREATION Diff: https://reviews.apache.org/r/39233/diff/ Testing --- Thanks, Rajat

Re: Review Request 38920: LENS-797: Improve CLI documentation to mention the helpful role of pressing tab while writing commands

2015-10-07 Thread Rajat Khandelwal
be93b8cfe982fcf60b13dbd3abaa15879537c3fd Diff: https://reviews.apache.org/r/38920/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 39127: LENS-807: Priority is not getting set in QueryContext. It's always NORMAL

2015-10-13 Thread Rajat Khandelwal
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39127/#review102408 --- On Oct. 12, 2015, 1:52 p.m., Rajat Khandelwal wrote: > > -

Re: Review Request 38521: LENS-607: Fix Test failures in java8

2015-10-13 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38521/#review102442 --- Ship it! Ship It! - Rajat Khandelwal On Oct. 13, 2015, 6:16

Re: Review Request 39161: LENS-292 : Query result retention policy

2015-10-09 Thread Rajat Khandelwal
ervice enabled or not. - Rajat Khandelwal On Oct. 9, 2015, 1:01 p.m., Deepak Barr wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-17 Thread Rajat Khandelwal
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39895/#review106881 ------- On Nov. 17, 2015, 8 p.m., Rajat Khandelwal wrote: > >

Re: [VOTE] Release of Apache Lens 2.3.0-beta

2015-08-28 Thread Rajat Khandelwal
Hi All Vote for Lens Release 2.3.0-beta has passed with 7 +1's (all binding), no 0 or -1's. +1 votes: Rajat Khandelwal Amareshwari Sriramadasu Raju Bairishetti Yash Sharma Arshad Matin Raghavendra Singh Jean-Baptiste Onofré 0 votes * No votes -1 Votes * No votes Vote thread: http://mail

[ANNOUNCE] Aapche Lens 2.3.0-beta release

2015-08-29 Thread Rajat Khandelwal
Hi all The Apache Lens team is proud to announce the release of Apache Lens 2.3.0-beta. This is the first release of Apache Lens as TLP. Apache Lens provides an Unified Analytics interface. Lens aims to cut the Data Analytics silos by providing a single view of data across multiple tiered data

Re: Review Request 37346: LENS-693: Query Result Mail is not working when finishedQueries is set to zero

2015-08-27 Thread Rajat Khandelwal
] Thanks, Rajat Khandelwal

Re: Review Request 37760: LENS-755: rename LogicalTableCrudCommand to ConceptualTableCrudCommand and PhysicalTableCrudCommand to LogicalTableCrudCommand

2015-08-27 Thread Rajat Khandelwal
3c78e436c245bed2644e97bd0b3269e332cc9240 lens-cli/src/main/java/org/apache/lens/cli/commands/PhysicalTableCrudCommand.java a1ccec682330d48f116e06a085d07db179888327 Diff: https://reviews.apache.org/r/37760/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 37434: LENS-710 : Allow column name mapping for few/all columns in underlying storage tables

2015-09-08 Thread Rajat Khandelwal
/jdbc/ColumnarSQLRewriter.java (line 1227) <https://reviews.apache.org/r/37434/#comment154100> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java (line 1240) <https://reviews.apache.org/r/37434/#comment154101> `replaceDBAndTableName

Re: Review Request 37756: LENS-745: Drop partition is assigning latest=null if latest partition is being dropped

2015-08-25 Thread Rajat Khandelwal
] [INFO] Total time: 21:55.372s [INFO] Finished at: Tue Aug 25 12:48:00 UTC 2015 [INFO] Final Memory: 192M/1764M [INFO] Thanks, Rajat Khandelwal

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-10 Thread Rajat Khandelwal
-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java (line 63) <https://reviews.apache.org/r/37934/#comment154819> Instead of `long`, can we re-use `QueryHandle`? lens-server-api/src/main/java/org/apache/lens/s

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-10 Thread Rajat Khandelwal
> On Sept. 10, 2015, 1:19 p.m., Rajat Khandelwal wrote: > > lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java, > > line 30 > > <https://reviews.apache.org/r/37934/diff/6/?file=1066442#file1066442line30> > > > > This

Re: Review Request 37934: LENS-742 Saved query and parameterization

2015-09-10 Thread Rajat Khandelwal
g/r/37934/#comment154861> Make default pagination configurable. - Rajat Khandelwal On Sept. 10, 2015, 12:53 a.m., Amruth Sampath wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Review Request 38212: LENS-392: Look ahead should take how much time to look ahead, instead of just a number

2015-09-09 Thread Rajat Khandelwal
/cube/parse/TestDateUtil.java ab88fbe067fadc839676f0013dc4885e3fbc5546 lens-cube/src/test/java/org/apache/lens/cube/time/TimeDiffTest.java PRE-CREATION Diff: https://reviews.apache.org/r/38212/diff/ Testing --- Thanks, Rajat Khandelwal

Re: Review Request 38212: LENS-392: Look ahead not working when not all process time partitions on lower granularity are present

2015-09-14 Thread Rajat Khandelwal
, Rajat Khandelwal

Re: Review Request 38212: LENS-392: Look ahead not working when not all process time partitions on lower granularity are present

2015-09-14 Thread Rajat Khandelwal
a test case Thanks, Rajat Khandelwal

  1   2   3   4   5   6   7   8   9   10   >