Re: Review Request 38617: LENS-576 : Cannot retrieve query results on lens server restart

2015-09-25 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38617/#review100538 --- Ship it! Ship It! - Amareshwari Sriramadasu On Sept. 24, 2015,

Re: Review Request 38617: LENS-576 : Cannot retrieve query results on lens server restart

2015-09-24 Thread Amareshwari Sriramadasu
> On Sept. 25, 2015, 12:56 a.m., Amareshwari Sriramadasu wrote: > > lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java, > > line 63 > > > > > > I dont see any difference between

Re: Review Request 38617: LENS-576 : Cannot retrieve query results on lens server restart

2015-09-24 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38617/#review100508 ---

Re: Review Request 38617: LENS-576 : Cannot retrieve query results on lens server restart

2015-09-24 Thread Deepak Barr
> On Sept. 25, 2015, 12:56 a.m., Amareshwari Sriramadasu wrote: > > lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java, > > line 63 > > > > > > I dont see any difference between

Re: Review Request 38617: LENS-576 : Cannot retrieve query results on lens server restart

2015-09-24 Thread Deepak Barr
> On Sept. 25, 2015, 12:56 a.m., Amareshwari Sriramadasu wrote: > > lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java, > > line 63 > > > > > > I dont see any difference between

Re: Review Request 38617: LENS-576 : Cannot retrieve query results on lens server restart

2015-09-23 Thread Puneet Gupta
> On Sept. 24, 2015, 2:18 a.m., Puneet Gupta wrote: > > lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java, > > line 210 > > > > > > we can use writeObject() and readObject()

Re: Review Request 38617: LENS-576 : Cannot retrieve query results on lens server restart

2015-09-23 Thread Deepak Barr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38617/ --- (Updated Sept. 23, 2015, 6:12 p.m.) Review request for lens. Changes ---

Re: Review Request 38617: LENS-576 : Cannot retrieve query results on lens server restart

2015-09-23 Thread Amareshwari Sriramadasu
> On Sept. 24, 2015, 2:18 a.m., Puneet Gupta wrote: > > lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java, > > line 210 > > > > > > we can use writeObject() and readObject()

Re: Review Request 38617: LENS-576 : Cannot retrieve query results on lens server restart

2015-09-23 Thread Puneet Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38617/#review100339 ---

Re: Review Request 38617: LENS-576 : Cannot retrieve query results on lens server restart

2015-09-22 Thread Puneet Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38617/#review99980 ---