Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-14 Thread Rajat Khandelwal
> On Oct. 14, 2016, 3:31 p.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > line 916 > > > > > > On what basis server retry policy

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-14 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/#review152645 --- Fix it, then Ship it!

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-13 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Oct. 13, 2016, 11:57 a.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-12 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Oct. 12, 2016, 6:31 p.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-12 Thread Rajat Khandelwal
> On Sept. 30, 2016, 12:16 p.m., Amareshwari Sriramadasu wrote: > > lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java, line 113 > > > > > > can you update state machine on user doc with the change? >

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-12 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Oct. 12, 2016, 5:57 p.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-12 Thread Rajat Khandelwal
> On Oct. 12, 2016, 4:51 p.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/java/org/apache/lens/server/query/retry/QueryRetryTest.java, > > line 55 > > > > > > test disabled? Commented to run the

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-12 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/#review152294 ---

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-10 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Oct. 10, 2016, 12:14 p.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-09 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Oct. 10, 2016, 11:14 a.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-09 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Oct. 9, 2016, 11:42 a.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-07 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Oct. 7, 2016, 11:41 p.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-07 Thread Rajat Khandelwal
> On Sept. 30, 2016, 12:16 p.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java, > > lines 76-77 > > > > > > This is enforcing drivertype

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-07 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Oct. 7, 2016, 4:51 p.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-07 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/#review151768 ---

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-06 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Oct. 6, 2016, 5:59 p.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-05 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Oct. 5, 2016, 1:40 p.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-05 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Oct. 5, 2016, 1:39 p.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-10-04 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Oct. 4, 2016, 1:51 p.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-09-30 Thread Rajat Khandelwal
> On Sept. 30, 2016, 12:16 p.m., Amareshwari Sriramadasu wrote: > > checkstyle/src/main/resources/checkstyle.xml, line 65 > > > > > > hmm, what file is extending this? Need to fix by doing some refactoring > > if

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-09-30 Thread Rajat Khandelwal
> On Sept. 30, 2016, 12:34 p.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/StatusUpdateFailureContext.java, > > line 41 > > > > > > why do we need clear()

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-09-30 Thread Rajat Khandelwal
> On Sept. 22, 2016, 11:53 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/common/SingleRetryHandler.java, > > line 22 > > > > > > Will SingleRetryHandler have delay

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-09-30 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/#review150993 ---

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-09-30 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/#review150991 --- checkstyle/src/main/resources/checkstyle.xml (line 65)

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-09-29 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Sept. 29, 2016, 2:39 p.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-09-28 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Sept. 28, 2016, 7:47 p.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-09-28 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Sept. 28, 2016, 7:55 p.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-09-27 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Sept. 27, 2016, 5:29 p.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-09-26 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/ --- (Updated Sept. 26, 2016, 8:29 p.m.) Review request for lens. Bugs: LENS-743

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-09-22 Thread Rajat Khandelwal
> On Sept. 22, 2016, 11:53 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, > > lines 210-216 > > > > > > All these should be defined as

Re: Review Request 52088: LENS-743: Query failure retries for transient errors

2016-09-22 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52088/#review149955 ---