Re: Review Request 66549: Lens Server: SPNEGO authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66549/#review203419 --- Ship it! Ship It! - Rajitha R On May 18, 2018, 8:58 a.m.,

Re: Review Request 66549: Lens Server: SPNEGO authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66549/ --- (Updated May 18, 2018, 8:58 a.m.) Review request for lens, Ankit Kailaswar,

Re: Review Request 66549: Lens Server: SPNEGO authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66549/ --- (Updated May 18, 2018, 8:08 a.m.) Review request for lens, Ankit Kailaswar,

Re: Review Request 66549: Lens Server: SPNEGO authentication

> On May 7, 2018, 12:10 p.m., Rajitha R wrote: > > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > > Line 164 (original), 169 (patched) > > > > > > Why are we passing a negate value here? If

Re: Review Request 66549: Lens Server: SPNEGO authentication

> On May 9, 2018, 1:58 p.m., Rajitha R wrote: > > lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java > > Lines 95 (patched) > > > > > > Is this config password required? This might require user to

Re: Review Request 66549: Lens Server: SPNEGO authentication

> On April 23, 2018, 6:09 a.m., Rajitha R wrote: > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > > Lines 71 (patched) > > > > > > Should we not have the authentication across all

Re: Review Request 66549: Lens Server: SPNEGO authentication

> On May 9, 2018, 1:58 p.m., Puneet Gupta wrote: > > lens-client/src/main/java/org/apache/lens/client/SpnegoClientFilter.java > > Lines 80 (patched) > > > > > > can we also add details on usage or user and password ?

Re: Review Request 66549: Lens Server: SPNEGO authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66549/ --- (Updated May 14, 2018, 2 p.m.) Review request for lens, Ankit Kailaswar,

Re: Review Request 66549: Lens Server: SPNEGO authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66549/#review202755 ---

Re: Review Request 66549: Lens Server: SPNEGO authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66549/#review202754 ---

Re: Review Request 66549: Lens Server: SPNEGO authentication

> On April 12, 2018, 8:22 a.m., Rajitha R wrote: > > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > > Lines 78 (patched) > > > > > > the service already has conf defined. This shouldn't be

Re: Review Request 66549: Lens Server: SPNEGO authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66549/#review202544 ---

Re: Review Request 66549: Lens Server: SPNEGO authentication

> On April 12, 2018, 8:22 a.m., Rajitha R wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > > Line 1516 (original) > > > > > > revert this This is a duplicate method. > On

Re: Review Request 66549: Lens Server: SPNEGO authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66549/ --- (Updated May 4, 2018, 12:48 p.m.) Review request for lens, Ankit Kailaswar,

Re: Review Request 66549: Lens Server: SPNEGO authentication

> On April 12, 2018, 8:22 a.m., Rajitha R wrote: > > lens-server/src/main/java/org/apache/lens/server/auth/SpnegoAuthenticationFilter.java > > Lines 64 (patched) > > > > > > What exactly is this id? Can this be made

Re: Review Request 66549: Lens Server: SPNEGO authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66549/#review201719 --- Should we not have the authentication across all resources than

Re: Review Request 66549: Lens Server: SPNEGO authentication

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66549/ --- (Updated April 12, 2018, 8:16 a.m.) Review request for lens, Ankit Kailaswar