Re: Review Request 69554: Lens HA changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/ --- (Updated Jan. 28, 2019, 7:01 p.m.) Review request for lens, Amareshwari

Re: Review Request 69554: Lens HA changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/#review212304 --- Ship it! Ship It! - Amareshwari Sriramadasu On Jan. 24,

Re: Review Request 69554: Lens HA changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/ --- (Updated Jan. 24, 2019, 11:32 a.m.) Review request for lens, Amareshwari

Re: Review Request 69554: Lens HA changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/#review212235 ---

Re: Review Request 69554: Lens HA changes

> On Dec. 13, 2018, 4:54 a.m., Rajitha R wrote: > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > > Lines 590 (patched) > > > > > > Instead of making a db call for every session

Re: Review Request 69554: Lens HA changes

> On Jan. 7, 2019, 3:48 a.m., Amareshwari Sriramadasu wrote: > > No unit tests added for the change introduced. Can you add unit tests? added test cases for lensserver dao functions. - Ankit --- This is an automatically generated

Re: Review Request 69554: Lens HA changes

> On Jan. 7, 2019, 3:47 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > > Lines 1176 (patched) > > > > > > no counter for failures?

Re: Review Request 69554: Lens HA changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/ --- (Updated Jan. 22, 2019, 11:08 a.m.) Review request for lens, Amareshwari

Re: Review Request 69554: Lens HA changes

> On Dec. 21, 2018, 6:10 a.m., Rajitha R wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java > > Lines 31 (patched) > > > > > > Can we not retain the same name validateSession?

Re: Review Request 69554: Lens HA changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/#review211719 ---

Re: Review Request 69554: Lens HA changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/ --- (Updated Jan. 8, 2019, 10:52 a.m.) Review request for lens, Amareshwari

Re: Review Request 69554: Lens HA changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/#review211711 --- No unit tests added for the change introduced. Can you add unit

Re: Review Request 69554: Lens HA changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/#review211710 ---

Re: Review Request 69554: Lens HA changes

> On Dec. 13, 2018, 4:54 a.m., Rajitha R wrote: > > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > > Lines 623 (patched) > > > > > > Can this be shifted to final block? Also

Re: Review Request 69554: Lens HA changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/ --- (Updated Dec. 24, 2018, 10:50 a.m.) Review request for lens, Amareshwari

Re: Review Request 69554: Lens HA changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/#review211463 ---

Re: Review Request 69554: Lens HA changes

> On Dec. 13, 2018, 4:54 a.m., Rajitha R wrote: > > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > > Lines 617 (patched) > > > > > > can this be moved to the if condition? this would

Re: Review Request 69554: Lens HA changes

> On Dec. 12, 2018, 3:38 p.m., Rajitha R wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > > Line 54 (original), 55 (patched) > > > > > > AbstractQueryContext already

Re: Review Request 69554: Lens HA changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/ --- (Updated Dec. 18, 2018, 12:20 p.m.) Review request for lens, Amareshwari

Re: Review Request 69554: Lens HA changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/ --- (Updated Dec. 18, 2018, 12:10 p.m.) Review request for lens, Amareshwari

Re: Review Request 69554: Lens HA changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/ --- (Updated Dec. 14, 2018, 12:06 p.m.) Review request for lens, Amareshwari

Re: Review Request 69554: Lens HA changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/ --- (Updated Dec. 14, 2018, 11:42 a.m.) Review request for lens, Amareshwari

Re: Review Request 69554: Lens HA changes

> On Dec. 13, 2018, 4:54 a.m., Rajitha R wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > > Lines 2258 (patched) > > > > > > makes more sense to move this to all

Re: Review Request 69554: Lens HA changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/#review211269 ---

Re: Review Request 69554: Lens HA changes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69554/#review211230 ---