Re: [3.x]: openshift router and its own metrics

2019-08-16 Thread Clayton Coleman
On Aug 16, 2019, at 4:55 AM, Daniel Comnea wrote: On Thu, Aug 15, 2019 at 7:46 PM Clayton Coleman wrote: > > > On Aug 15, 2019, at 12:25 PM, Daniel Comnea wrote: > > Hi Clayton, > > Certainly some of the metrics should be preserved across reloads, e.g. > metrics like

Re: [3.x]: openshift router and its own metrics

2019-08-16 Thread Daniel Comnea
On Thu, Aug 15, 2019 at 7:46 PM Clayton Coleman wrote: > > > On Aug 15, 2019, at 12:25 PM, Daniel Comnea wrote: > > Hi Clayton, > > Certainly some of the metrics should be preserved across reloads, e.g. > metrics like *haproxy_server_http_responses_total *should be preserved > across reload

Re: [3.x]: openshift router and its own metrics

2019-08-15 Thread Clayton Coleman
On Aug 15, 2019, at 12:25 PM, Daniel Comnea wrote: Hi Clayton, Certainly some of the metrics should be preserved across reloads, e.g. metrics like *haproxy_server_http_responses_total *should be preserved across reload (though to an extent, Prometheus can handle resets correctly with its native

Re: [3.x]: openshift router and its own metrics

2019-08-15 Thread Daniel Comnea
Hi Clayton, Certainly some of the metrics should be preserved across reloads, e.g. metrics like *haproxy_server_http_responses_total *should be preserved across reload (though to an extent, Prometheus can handle resets correctly with its native support). However, the metric

Re: [3.x]: openshift router and its own metrics

2019-08-15 Thread Daniel Comnea
On Thu, Aug 15, 2019 at 3:30 PM Dan Mace wrote: > > > On Thu, Aug 15, 2019 at 10:03 AM Daniel Comnea > wrote: > >> Hi, >> >> Would appreciate if anyone can please confirm that my understanding is >> correct w.r.t the way the router haproxy image [1] is built. >> Am i right to assume that the

Re: [3.x]: openshift router and its own metrics

2019-08-15 Thread Clayton Coleman
Metrics memory use in the router should be proportional to number of services, endpoints, and routes. I doubt it's leaking there and if it were it'd be really slow since we don't restart the router monitor process ever. Stats should definitely be preserved across reloads, but will not be

Re: [3.x]: openshift router and its own metrics

2019-08-15 Thread Dan Mace
On Thu, Aug 15, 2019 at 10:03 AM Daniel Comnea wrote: > Hi, > > Would appreciate if anyone can please confirm that my understanding is > correct w.r.t the way the router haproxy image [1] is built. > Am i right to assume that the image [1] is is built as it's seen without > any other layer being