Re: [Snowdrift-dev] [PATCH] Discourse SSO support

2016-12-07 Thread Jason Harrer
For those who may not be watching our Github repo, a patch was submitted yesterday on Github to fix the redirect problem. I downloaded the patch to the Discourse SSO branch I've been working with, and Sidney is now able to login properly the first time she clicks on "Log In" from Discourse: She

Re: [Snowdrift-dev] [PATCH] Discourse SSO support

2016-12-06 Thread fr33domlover
Hello, Jason, thanks for the testing and the report! On Tue, 6 Dec 2016 07:37:04 -0600 Jason Harrer wrote: > [...] > > George is already signed up *and* signed in to Snowdrift.coop and goes to > Discourse for the first time. George will still see a button at the top

Re: [Snowdrift-dev] [PATCH] Discourse SSO support

2016-12-06 Thread Jason Harrer
I tested this locally (I set up a local instance of Discourse to test with), and it works... to a point. It seemed easier yesterday to explain things in User Story format, so I'm going to attempt the same here. George is already signed up *and* signed in to Snowdrift.coop and goes to Discourse

Re: [Snowdrift-dev] [PATCH] Discourse SSO support

2016-12-05 Thread fr33domlover
Hello Bryan, If you look at the code you'll see there are 2 parts. The logic, which is a simple single file, and the handler that uses it. Both are quite trivial, it's hardly worth having them separately. I do think it would be great to have them both as a separate package that offers a Yesod

[Snowdrift-dev] [PATCH] Discourse SSO support

2016-12-05 Thread fr33domlover
From: fr33domlover --- website/Snowdrift.cabal | 8 website/config/routes| 2 + website/config/settings.yml | 3 ++ website/src/Application.hs | 1 + website/src/Discourse.hs | 86

Re: [Snowdrift-dev] [PATCH] Discourse SSO support

2016-12-05 Thread Aaron Wolf
On 12/05/2016 11:34 AM, Bryan Richter wrote: > Thanks for this. I think the best way to make use of this is to package > up the logic specific to handling SSO requests in an independent > library, so we can use it later. > > That's not about you, or about this code. :) It's just that I am going >

Re: [Snowdrift-dev] [PATCH] Discourse SSO support

2016-12-05 Thread Aaron Wolf
On 12/05/2016 11:34 AM, Bryan Richter wrote: > Thanks for this. I think the best way to make use of this is to package > up the logic specific to handling SSO requests in an independent > library, so we can use it later. > > That's not about you, or about this code. :) It's just that I am going >

[Snowdrift-dev] [PATCH] Discourse SSO support

2016-12-04 Thread fr33domlover
From: fr33domlover --- website/Snowdrift.cabal | 7 website/config/routes| 2 ++ website/config/settings.yml | 4 +++ website/src/Application.hs | 1 + website/src/Discourse.hs | 73