Re: [log4j] providing sourcewith Message

2017-12-19 Thread Jeffrey Shaw
org/apache/logging/log4j/scala/LoggerTest.scala#L574 On Sun, Dec 17, 2017 at 8:50 PM, Jeffrey Shaw <shawj...@gmail.com> wrote: > Thanks for the encouragement everyone! I never worked on an Apache project > before and had no idea what to expect from the community. > > I've made som

Re: [log4j] providing sourcewith Message

2017-12-17 Thread Jeffrey Shaw
ar. If you can add some unit tests, then > we'd be happy to merge! > > On 11 December 2017 at 20:41, Jeffrey Shaw <shawj...@gmail.com> wrote: > > > Great news! I'm able to run LoggingApp in the scala api repo without it > > calling StackLocatorUtil.calcLocation, but i

[log4j] providing sourcewith Message

2017-12-08 Thread Jeffrey Shaw
Hello, I've found that I am able to use Scala macros to provide compile-time source information for log messages. However, I don't see a way to inject this into log4j's logging mechanism. I'm wondering if there is something I'm missing, or if LogEvent's getSource method could be duplicated in

Re: [log4j] providing sourcewith Message

2017-12-11 Thread Jeffrey Shaw
at 3:56 PM, Matt Sicker <boa...@gmail.com> wrote: > This sounds like it'd make a great addition to the Scala API! > > On 9 December 2017 at 15:36, Jeffrey Shaw <shawj...@gmail.com> wrote: > > > Ralph, I agree with you entirely. My intent for these new log methods is >

Re: [log4j] providing sourcewith Message

2017-12-09 Thread Jeffrey Shaw
is called from a facade, such as > log4j-slf4j-impl then the number of levels that have to be skipped would be > different. > > I would really prefer if there was some way to capture the line number > information for the various loggers when the annotation processor runs at > compile

Re: [log4j] providing sourcewith Message

2017-12-09 Thread Jeffrey Shaw
e added there. But log4j-api and/or log4j-core probably needs to > adapted as well. > > > > On 2017-12-09 07:30, Jeffrey Shaw wrote: > >> Hello, >> I've found that I am able to use Scala macros to provide compile-time >> source information for log messages. Howev

Re: [log4j] providing sourcewith Message

2017-12-20 Thread Jeffrey Shaw
t; wrote: > > > Could a compile time environment variable like SrcRootDirectory do the > job? > > > > On 20 Dec 2017 7:49 p.m., "Jeffrey Shaw" <shawj...@gmail.com> wrote: > > > > > I got it working using a custom ExtendedLogger instead of mocking.

Re: [log4j] providing sourcewith Message

2018-02-23 Thread Jeffrey Shaw
he.org> wrote: > Yes, StackTraceElement does not allow null methodName. > > But what about using the empty string, or a string like "" if it > is not possible to get? > > > On 2017-12-22 20:26, Jeffrey Shaw wrote: > >> I didn't know about clirr, but I can try runn

Re: [log4j] providing sourcewith Message

2018-02-23 Thread Jeffrey Shaw
done! https://github.com/apache/logging-log4j2/pull/151 On Fri, Feb 23, 2018 at 9:22 PM, Gary Gregory <garydgreg...@gmail.com> wrote: > On Fri, Feb 23, 2018 at 7:02 PM, Jeffrey Shaw <shawj...@gmail.com> wrote: > > > Hi All, > > I spent some more time on this to

Re: [log4j] providing sourcewith Message

2017-12-20 Thread Jeffrey Shaw
ther, though that's > just a guess. > > On 20 December 2017 at 00:00, Jeff Shaw <shawj...@gmail.com> wrote: > > > I should add that manually testing it works. > > > > Sent from my phone > > > > > On Dec 20, 2017, at 12:45 AM, Jeffrey Shaw

Re: [log4j] providing sourcewith Message

2017-12-22 Thread Jeffrey Shaw
ion had to be used instead of StackTraceElement? > > Ralph > > > On Dec 20, 2017, at 9:58 PM, Jeffrey Shaw <shawj...@gmail.com> wrote: > > > > It looks like the location only ever gets the file name, because that's > > what StackTraceElement gives. So that's fine

Re: [log4j] providing sourcewith Message

2018-07-05 Thread Jeffrey Shaw
Looking to get some eyes on https://issues.apache.org/jira/projects/LOG4J2/issues/LOG4J2-2360 On Wed, Jun 27, 2018 at 11:02 PM, Jeffrey Shaw wrote: > I created a JIRA ticket for this. https://issues.apache.org/ > jira/browse/LOG4J2-2360 > > On Thu, Mar 15, 2018 at 11:37 PM, Jeff

Re: [log4j] providing sourcewith Message

2018-03-15 Thread Jeffrey Shaw
Hi, just hoping to get some eyes on this again. On Fri, Feb 23, 2018 at 10:43 PM, Jeffrey Shaw <shawj...@gmail.com> wrote: > closed that one and opened a new one with the commits squashed > https://github.com/apache/logging-log4j2/pull/152 > > On Fri, Feb 23, 2018 at 10:1

Re: [log4j] providing sourcewith Message

2018-06-27 Thread Jeffrey Shaw
//picocli.info > > > >> On Mar 16, 2018, at 5:33, Jeffrey Shaw wrote: > >> > >> Hi, just hoping to get some eyes on this again. > >> > >>> On Fri, Feb 23, 2018 at 10:43 PM, Jeffrey Shaw > wrote: > >>> > >>> closed th

Re: Thoughts on Log4j 3.0

2019-12-16 Thread Jeffrey Shaw
nt to let me compare your branch against master at > the point the branch was created. Any ideas? > > Ralph > > > On Dec 16, 2019, at 8:41 PM, Jeffrey Shaw wrote: > > > > Something I created but didn't push to get included in 2 is the ability > to > > hard cod

Re: Thoughts on Log4j 3.0

2019-12-16 Thread Jeffrey Shaw
Something I created but didn't push to get included in 2 is the ability to hard code source code locations. This is useful in contexts where the compiler can provide them. For instance, Scala's macros can do it. I implemented this intending it to improve performance, since run-time stack tracing