[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-18 Thread xnslong
Github user xnslong commented on the issue: https://github.com/apache/logging-log4j2/pull/92 I runned this test, but it didn't fail on my machine. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-17 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/logging-log4j2/pull/92 With this patch, I now get: [ERROR] Failures: [ERROR] AsyncLoggerThreadContextGarbageFreeTest>AbstractAsyncThreadContextTestBase.testAsyncLogWritesToLog:159->AbstractAsyncTh

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-17 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/logging-log4j2/pull/92 Please accept my apologies, I made a mistake saying the patch was partly applied to log4j-api. It was not. The new test passes. --- If your project is set up for it, you can reply to thi

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-17 Thread xnslong
Github user xnslong commented on the issue: https://github.com/apache/logging-log4j2/pull/92 I followed the tips to run command `mvn -U clean test -pl log4j-core -Dtest=AbstractStringLayoutTest`, and then I checked my local maven repository, but I'm afraid it didn't work. The followin

Re: [GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-17 Thread Gary Gregory
Hi, If you want your log4j-core checkout to use changes you make in log4j-api locally, then you MUST install log4j-api in your local repository (see the mvn commands I provided). BUT... In this case, the log4j-api changes are already in git master. If you want to make sure you have the latest SNA

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-17 Thread xnslong
Github user xnslong commented on the issue: https://github.com/apache/logging-log4j2/pull/92 After this failure, could you please check your local maven repository for the log4j-api-2.9-SNAPSHOT version, decompile the jar and check the StringBuilders class. After I got the failure, I

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-17 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/logging-log4j2/pull/92 I have the whole project sources and all modules (sources) loaded in Eclipse so I run the one test directly from Eclipse. The commands you show will never work (did you try the

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-17 Thread xnslong
Github user xnslong commented on the issue: https://github.com/apache/logging-log4j2/pull/92 I reappeared the failure! when I run the tests with `mvn clean test -pl log4j2-core`, I got the following failure (it is just the failure you provided) ``` [ERROR] Failures: [

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-17 Thread xnslong
Github user xnslong commented on the issue: https://github.com/apache/logging-log4j2/pull/92 I merged the latest master to my branch just now, Would you please run the case again, and show me the result? @garydgregory --- If your project is set up for it, you can reply to this email

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-17 Thread xnslong
Github user xnslong commented on the issue: https://github.com/apache/logging-log4j2/pull/92 Still reports this problem? Hmm... interesting. I also have ran this case in my IDE, nothing went wrong. Would you please show me the git repository version, maybe we have to check if we are r

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-16 Thread xnslong
Github user xnslong commented on the issue: https://github.com/apache/logging-log4j2/pull/92 Well, the case runs well on my computer. But I notice that the `MAX_STRING_BUILDER_SIZE` is not a constant, instead it may be loaded from the sysstem properties. So I changed my test case, to

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-12 Thread garydgregory
Github user garydgregory commented on the issue: https://github.com/apache/logging-log4j2/pull/92 Hi, When I build with 'mvn clean install' from a clean git master, all the tests pass. Note that I am on Windows 10 and that the test HttpAppenderTest fails randomly for me, so I

[GitHub] logging-log4j2 issue #92: Consider the StringBuilder's capacity instead of c...

2017-07-12 Thread xnslong
Github user xnslong commented on the issue: https://github.com/apache/logging-log4j2/pull/92 @garydgregory Yes, I noticed that and fixed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t