Re: [VOTE] Release Log4j 2.11.1-rc1

2018-07-25 Thread Ralph Goers 
My +1

Ralph

> On Jul 22, 2018, at 9:44 PM, Ralph Goers  wrote:
> 
> This is a vote to release Log4j 2.11.1, the next version of the Log4j 2 
> project.
> 
> Please download, test, and cast your votes on the log4j developers list.
> [] +1, release the artifacts
> [] -1, don't release because...
> 
> The vote will remain open for 72 hours (or more if required). All votes are 
> welcome and we encourage everyone to test the release, but only Logging PMC 
> votes are “officially” counted. As always, at least 3 +1 votes and more 
> positive than negative votes are required.
> 
> Changes in this release include:
> 
> Fixed Bugs
> 
>   • LOG4J2-2389: ThrowableProxy was saving and retrieving cache entries 
> using different keys. Thanks to Liu Wen.
>   • LOG4J2-2316: If root LoggerConfig does not have a Level return ERROR.
>   • LOG4J2-2390: Fix broken links in log4j web documentation. Thanks to 
> anton-balaniuc.
>   • LOG4J2-2343: The OSGi Activator specified an incorrect version. 
> Thanks to Raymond Augé.
>   • LOG4J2-2305: Make java.util.ServiceLoader properly work in OSGi by 
> using the Service Loader Mediator Specification. Thanks to Björn Kautler.
>   • LOG4J2-2305: Split the SLF4J binding into 2 implementations - one for 
> SLF4J 1.7.x and one for SLF4J 1.8+.
>   • LOG4J2-2268: Improve plugin error message when elements are missing. 
> Thanks to Tilman Hausherr.
>   • LOG4J2-2283: ParserConfigurationException when using Log4j with 
> oracle.xml.jaxp.JXDocumentBuilderFactory. Thanks to Vishnu Priya Matha.
>   • LOG4J2-2300: PoolingDriverConnectionSource does not take into account 
> properties, user name, and password.
>   • LOG4J2-2307: MutableLogEvent and RingBufferLogEvent message mementos 
> retain the original format string.
>   • LOG4J2-2032: Curly braces in parameters are not treated as 
> placeholders. Thanks to Kostiantyn Shchepanovskyi.
>   • LOG4J2-2317: MutableLogEvent.getNonNullImmutableMessage and 
> Log4jLogEvent.makeMessageImmutable retain format and parameters.
>   • LOG4J2-2318: Messages are no longer mutated when the asynchronous 
> queue is full. A warning is logged to the status logger instead.
>   • LOG4J2-2320: Fix NPE in AbstractLogger when another exception is 
> thrown, masking the root cause.
>   • LOG4J2-2321: AsyncLogger uses the correct level when unspecified. 
> This provides parity between AsyncLogger and Logger.
>   • LOG4J2-2322: Custom ContextSelector implementations which select an 
> AsyncLoggerContext disable LoggerConfig.includeLocation by default for parity 
> with AsyncLoggerContextSelector.
>   • LOG4J2-2269: MutableLogEvent references to other objects are cleared 
> after each use. Fix a memory leak causing references to parameters to be held 
> after synchronous logging with thread locals enabled.
>   • LOG4J2-2301: Mixed async loggers no longer forget parameter values, 
> providing some appenders with an array of nulls.
>   • LOG4J2-2331: RollingFileManager debug logging avoids string 
> concatenation and errant braces in favor of parameterized logging. Thanks to 
> Mike Baranski.
>   • LOG4J2-2333: Handle errors thrown in default disruptor 
> ExceptionHandler implementations to avoid killing background threads.
>   • LOG4J2-2334: Add API 
> org.apache.logging.log4j.core.appender.AsyncAppender.getQueueSize().
>   • LOG4J2-2336: Remove duplicate hyphen from the AsyncLoggerConfig 
> background thread name.
>   • LOG4J2-2347: Update Apache Commons Compress from 1.16.1 to 1.17.
>   • LOG4J2-2352: RingBufferLogEvent memento messages provide the expected 
> format string, and no longer attempt to substitute parameters into curly 
> braces in parameter toString values. Both RingBufferLogEvent and 
> MutableLogEvent memento implementations memoize results to avoid rebuilding 
> formatted string values.
>   • LOG4J2-2355: PropertiesUtil ignores non-string system properties. 
> Fixes a NoClassDefFoundError initializing StatusLogger caused by an NPE while 
> initializing the static PropertiesUtil field. Thanks to Henrik Brautaset 
> Aronsen.
>   • LOG4J2-2362: Fixed a memory leak in which ReusableObjectMessage would 
> hold a reference to the most recently logged object.
>   • LOG4J2-2312: Jackson layouts used with AsyncLoggerContextSelector 
> output the expected format rather than only a JSON string of the message text.
>   • LOG4J2-2364: Fixed a memory leak in which 
> ReusableParameterizedMessage would hold a reference to the most recently 
> logged throwable and provided varargs array.
>   • LOG4J2-2368: Nested logging doesn't clobber AbstractStringLayout 
> cached StringBuidlers
>   • LOG4J2-2373: StringBuilders.escapeJson implementation runs in linear 
> time. Escaping large JSON strings in EncodingPatternConverter and MapMessage 
> will perform significantly better. Thanks to Kevin Meurer.
>   • LOG4J2-2376: StringBuilders.escapeXml

Re: [VOTE] Release Log4j 2.11.1-rc1

2018-07-24 Thread Remko Popma 
+1

On Wed, Jul 25, 2018 at 5:00 AM, Matt Sicker  wrote:

> +1
>
> Builds with Java 8 and 10 toolchain, though I had to add a dummy entry in
> my toolchains.xml for 9 for one of the modules (it should request a version
> range). Signatures good. Site looks fine, though I haven't looked through
> it as much as I have in the past.
>
> More info on build system:
>
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T13:33:14-05:00)
> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
> Java version: 1.8.0_163, vendor: Azul Systems, Inc., runtime:
> /Library/Java/JavaVirtualMachines/zulu-8.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.13.5", arch: "x86_64", family: "mac"
>
> On Tue, 24 Jul 2018 at 11:48, Carter Kozak  wrote:
>
> > +1
> >
> > I've tested the snapshot similarly and ran a suite of benchmarks
> > overnight without signs of performance degradation in my usage.
> >
> > Best,
> > Carter
> >
> > On Tue, Jul 24, 2018 at 11:53 AM, Gary Gregory 
> > wrote:
> > > More reviews please :-)  More reviews please :-)
> > >
> > > I've already votes and FWIW I am testing the SNAPSHOT code in one our
> > > product's CI builds (with contains lots of tests.)
> > >
> > > Gary
> > >
> > > On Sun, Jul 22, 2018 at 10:44 PM Ralph Goers <
> ralph.go...@dslextreme.com
> > >
> > > wrote:
> > >
> > >> This is a vote to release Log4j 2.11.1, the next version of the Log4j
> 2
> > >> project.
> > >>
> > >> Please download, test, and cast your votes on the log4j developers
> list.
> > >> [] +1, release the artifacts
> > >> [] -1, don't release because...
> > >>
> > >> The vote will remain open for 72 hours (or more if required). All
> votes
> > >> are welcome and we encourage everyone to test the release, but only
> > Logging
> > >> PMC votes are “officially” counted. As always, at least 3 +1 votes and
> > more
> > >> positive than negative votes are required.
> > >>
> > >> Changes in this release include:
> > >>
> > >> Fixed Bugs
> > >>
> > >> • LOG4J2-2389: ThrowableProxy was saving and retrieving cache
> > >> entries using different keys. Thanks to Liu Wen.
> > >> • LOG4J2-2316: If root LoggerConfig does not have a Level
> return
> > >> ERROR.
> > >> • LOG4J2-2390: Fix broken links in log4j web documentation.
> > Thanks
> > >> to anton-balaniuc.
> > >> • LOG4J2-2343: The OSGi Activator specified an incorrect
> > version.
> > >> Thanks to Raymond Augé.
> > >> • LOG4J2-2305: Make java.util.ServiceLoader properly work in
> > OSGi
> > >> by using the Service Loader Mediator Specification. Thanks to Björn
> > Kautler.
> > >> • LOG4J2-2305: Split the SLF4J binding into 2 implementations
> -
> > >> one for SLF4J 1.7.x and one for SLF4J 1.8+.
> > >> • LOG4J2-2268: Improve plugin error message when elements are
> > >> missing. Thanks to Tilman Hausherr.
> > >> • LOG4J2-2283: ParserConfigurationException when using Log4j
> > with
> > >> oracle.xml.jaxp.JXDocumentBuilderFactory. Thanks to Vishnu Priya
> Matha.
> > >> • LOG4J2-2300: PoolingDriverConnectionSource does not take
> into
> > >> account properties, user name, and password.
> > >> • LOG4J2-2307: MutableLogEvent and RingBufferLogEvent message
> > >> mementos retain the original format string.
> > >> • LOG4J2-2032: Curly braces in parameters are not treated as
> > >> placeholders. Thanks to Kostiantyn Shchepanovskyi.
> > >> • LOG4J2-2317: MutableLogEvent.getNonNullImmutableMessage and
> > >> Log4jLogEvent.makeMessageImmutable retain format and parameters.
> > >> • LOG4J2-2318: Messages are no longer mutated when the
> > >> asynchronous queue is full. A warning is logged to the status logger
> > >> instead.
> > >> • LOG4J2-2320: Fix NPE in AbstractLogger when another
> exception
> > is
> > >> thrown, masking the root cause.
> > >> • LOG4J2-2321: AsyncLogger uses the correct level when
> > >> unspecified. This provides parity between AsyncLogger and Logger.
> > >> • LOG4J2-2322: Custom ContextSelector implementations which
> > select
> > >> an AsyncLoggerContext disable LoggerConfig.includeLocation by default
> > for
> > >> parity with AsyncLoggerContextSelector.
> > >> • LOG4J2-2269: MutableLogEvent references to other objects are
> > >> cleared after each use. Fix a memory leak causing references to
> > parameters
> > >> to be held after synchronous logging with thread locals enabled.
> > >> • LOG4J2-2301: Mixed async loggers no longer forget parameter
> > >> values, providing some appenders with an array of nulls.
> > >> • LOG4J2-2331: RollingFileManager debug logging avoids string
> > >> concatenation and errant braces in favor of parameterized logging.
> > Thanks
> > >> to Mike Baranski.
> > >> • LOG4J2-2333: Handle errors thrown in default disruptor
> > >> ExceptionHandler implementations to avoid killing background threads.
> > >>

Re: [VOTE] Release Log4j 2.11.1-rc1

2018-07-24 Thread Matt Sicker 
+1

Builds with Java 8 and 10 toolchain, though I had to add a dummy entry in
my toolchains.xml for 9 for one of the modules (it should request a version
range). Signatures good. Site looks fine, though I haven't looked through
it as much as I have in the past.

More info on build system:

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T13:33:14-05:00)
Maven home: /usr/local/Cellar/maven/3.5.4/libexec
Java version: 1.8.0_163, vendor: Azul Systems, Inc., runtime:
/Library/Java/JavaVirtualMachines/zulu-8.jdk/Contents/Home/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "mac os x", version: "10.13.5", arch: "x86_64", family: "mac"

On Tue, 24 Jul 2018 at 11:48, Carter Kozak  wrote:

> +1
>
> I've tested the snapshot similarly and ran a suite of benchmarks
> overnight without signs of performance degradation in my usage.
>
> Best,
> Carter
>
> On Tue, Jul 24, 2018 at 11:53 AM, Gary Gregory 
> wrote:
> > More reviews please :-)  More reviews please :-)
> >
> > I've already votes and FWIW I am testing the SNAPSHOT code in one our
> > product's CI builds (with contains lots of tests.)
> >
> > Gary
> >
> > On Sun, Jul 22, 2018 at 10:44 PM Ralph Goers  >
> > wrote:
> >
> >> This is a vote to release Log4j 2.11.1, the next version of the Log4j 2
> >> project.
> >>
> >> Please download, test, and cast your votes on the log4j developers list.
> >> [] +1, release the artifacts
> >> [] -1, don't release because...
> >>
> >> The vote will remain open for 72 hours (or more if required). All votes
> >> are welcome and we encourage everyone to test the release, but only
> Logging
> >> PMC votes are “officially” counted. As always, at least 3 +1 votes and
> more
> >> positive than negative votes are required.
> >>
> >> Changes in this release include:
> >>
> >> Fixed Bugs
> >>
> >> • LOG4J2-2389: ThrowableProxy was saving and retrieving cache
> >> entries using different keys. Thanks to Liu Wen.
> >> • LOG4J2-2316: If root LoggerConfig does not have a Level return
> >> ERROR.
> >> • LOG4J2-2390: Fix broken links in log4j web documentation.
> Thanks
> >> to anton-balaniuc.
> >> • LOG4J2-2343: The OSGi Activator specified an incorrect
> version.
> >> Thanks to Raymond Augé.
> >> • LOG4J2-2305: Make java.util.ServiceLoader properly work in
> OSGi
> >> by using the Service Loader Mediator Specification. Thanks to Björn
> Kautler.
> >> • LOG4J2-2305: Split the SLF4J binding into 2 implementations -
> >> one for SLF4J 1.7.x and one for SLF4J 1.8+.
> >> • LOG4J2-2268: Improve plugin error message when elements are
> >> missing. Thanks to Tilman Hausherr.
> >> • LOG4J2-2283: ParserConfigurationException when using Log4j
> with
> >> oracle.xml.jaxp.JXDocumentBuilderFactory. Thanks to Vishnu Priya Matha.
> >> • LOG4J2-2300: PoolingDriverConnectionSource does not take into
> >> account properties, user name, and password.
> >> • LOG4J2-2307: MutableLogEvent and RingBufferLogEvent message
> >> mementos retain the original format string.
> >> • LOG4J2-2032: Curly braces in parameters are not treated as
> >> placeholders. Thanks to Kostiantyn Shchepanovskyi.
> >> • LOG4J2-2317: MutableLogEvent.getNonNullImmutableMessage and
> >> Log4jLogEvent.makeMessageImmutable retain format and parameters.
> >> • LOG4J2-2318: Messages are no longer mutated when the
> >> asynchronous queue is full. A warning is logged to the status logger
> >> instead.
> >> • LOG4J2-2320: Fix NPE in AbstractLogger when another exception
> is
> >> thrown, masking the root cause.
> >> • LOG4J2-2321: AsyncLogger uses the correct level when
> >> unspecified. This provides parity between AsyncLogger and Logger.
> >> • LOG4J2-2322: Custom ContextSelector implementations which
> select
> >> an AsyncLoggerContext disable LoggerConfig.includeLocation by default
> for
> >> parity with AsyncLoggerContextSelector.
> >> • LOG4J2-2269: MutableLogEvent references to other objects are
> >> cleared after each use. Fix a memory leak causing references to
> parameters
> >> to be held after synchronous logging with thread locals enabled.
> >> • LOG4J2-2301: Mixed async loggers no longer forget parameter
> >> values, providing some appenders with an array of nulls.
> >> • LOG4J2-2331: RollingFileManager debug logging avoids string
> >> concatenation and errant braces in favor of parameterized logging.
> Thanks
> >> to Mike Baranski.
> >> • LOG4J2-2333: Handle errors thrown in default disruptor
> >> ExceptionHandler implementations to avoid killing background threads.
> >> • LOG4J2-2334: Add API
> >> org.apache.logging.log4j.core.appender.AsyncAppender.getQueueSize().
> >> • LOG4J2-2336: Remove duplicate hyphen from the
> AsyncLoggerConfig
> >> background thread name.
> >> • LOG4J2-2347: Update Apache Commons Compress from 1.16.1 to
> 1.17.
> >> • LOG4J2-2352:

Re: [VOTE] Release Log4j 2.11.1-rc1

2018-07-24 Thread Carter Kozak 
+1

I've tested the snapshot similarly and ran a suite of benchmarks
overnight without signs of performance degradation in my usage.

Best,
Carter

On Tue, Jul 24, 2018 at 11:53 AM, Gary Gregory  wrote:
> More reviews please :-)  More reviews please :-)
>
> I've already votes and FWIW I am testing the SNAPSHOT code in one our
> product's CI builds (with contains lots of tests.)
>
> Gary
>
> On Sun, Jul 22, 2018 at 10:44 PM Ralph Goers 
> wrote:
>
>> This is a vote to release Log4j 2.11.1, the next version of the Log4j 2
>> project.
>>
>> Please download, test, and cast your votes on the log4j developers list.
>> [] +1, release the artifacts
>> [] -1, don't release because...
>>
>> The vote will remain open for 72 hours (or more if required). All votes
>> are welcome and we encourage everyone to test the release, but only Logging
>> PMC votes are “officially” counted. As always, at least 3 +1 votes and more
>> positive than negative votes are required.
>>
>> Changes in this release include:
>>
>> Fixed Bugs
>>
>> • LOG4J2-2389: ThrowableProxy was saving and retrieving cache
>> entries using different keys. Thanks to Liu Wen.
>> • LOG4J2-2316: If root LoggerConfig does not have a Level return
>> ERROR.
>> • LOG4J2-2390: Fix broken links in log4j web documentation. Thanks
>> to anton-balaniuc.
>> • LOG4J2-2343: The OSGi Activator specified an incorrect version.
>> Thanks to Raymond Augé.
>> • LOG4J2-2305: Make java.util.ServiceLoader properly work in OSGi
>> by using the Service Loader Mediator Specification. Thanks to Björn Kautler.
>> • LOG4J2-2305: Split the SLF4J binding into 2 implementations -
>> one for SLF4J 1.7.x and one for SLF4J 1.8+.
>> • LOG4J2-2268: Improve plugin error message when elements are
>> missing. Thanks to Tilman Hausherr.
>> • LOG4J2-2283: ParserConfigurationException when using Log4j with
>> oracle.xml.jaxp.JXDocumentBuilderFactory. Thanks to Vishnu Priya Matha.
>> • LOG4J2-2300: PoolingDriverConnectionSource does not take into
>> account properties, user name, and password.
>> • LOG4J2-2307: MutableLogEvent and RingBufferLogEvent message
>> mementos retain the original format string.
>> • LOG4J2-2032: Curly braces in parameters are not treated as
>> placeholders. Thanks to Kostiantyn Shchepanovskyi.
>> • LOG4J2-2317: MutableLogEvent.getNonNullImmutableMessage and
>> Log4jLogEvent.makeMessageImmutable retain format and parameters.
>> • LOG4J2-2318: Messages are no longer mutated when the
>> asynchronous queue is full. A warning is logged to the status logger
>> instead.
>> • LOG4J2-2320: Fix NPE in AbstractLogger when another exception is
>> thrown, masking the root cause.
>> • LOG4J2-2321: AsyncLogger uses the correct level when
>> unspecified. This provides parity between AsyncLogger and Logger.
>> • LOG4J2-2322: Custom ContextSelector implementations which select
>> an AsyncLoggerContext disable LoggerConfig.includeLocation by default for
>> parity with AsyncLoggerContextSelector.
>> • LOG4J2-2269: MutableLogEvent references to other objects are
>> cleared after each use. Fix a memory leak causing references to parameters
>> to be held after synchronous logging with thread locals enabled.
>> • LOG4J2-2301: Mixed async loggers no longer forget parameter
>> values, providing some appenders with an array of nulls.
>> • LOG4J2-2331: RollingFileManager debug logging avoids string
>> concatenation and errant braces in favor of parameterized logging. Thanks
>> to Mike Baranski.
>> • LOG4J2-2333: Handle errors thrown in default disruptor
>> ExceptionHandler implementations to avoid killing background threads.
>> • LOG4J2-2334: Add API
>> org.apache.logging.log4j.core.appender.AsyncAppender.getQueueSize().
>> • LOG4J2-2336: Remove duplicate hyphen from the AsyncLoggerConfig
>> background thread name.
>> • LOG4J2-2347: Update Apache Commons Compress from 1.16.1 to 1.17.
>> • LOG4J2-2352: RingBufferLogEvent memento messages provide the
>> expected format string, and no longer attempt to substitute parameters into
>> curly braces in parameter toString values. Both RingBufferLogEvent and
>> MutableLogEvent memento implementations memoize results to avoid rebuilding
>> formatted string values.
>> • LOG4J2-2355: PropertiesUtil ignores non-string system
>> properties. Fixes a NoClassDefFoundError initializing StatusLogger caused
>> by an NPE while initializing the static PropertiesUtil field. Thanks to
>> Henrik Brautaset Aronsen.
>> • LOG4J2-2362: Fixed a memory leak in which ReusableObjectMessage
>> would hold a reference to the most recently logged object.
>> • LOG4J2-2312: Jackson layouts used with
>> AsyncLoggerContextSelector output the expected format rather than only a
>> JSON string of the message text.
>> • LOG4J2-2364: Fixed a memory leak in which
>>

Re: [VOTE] Release Log4j 2.11.1-rc1

2018-07-24 Thread Gary Gregory 
More reviews please :-)  More reviews please :-)

I've already votes and FWIW I am testing the SNAPSHOT code in one our
product's CI builds (with contains lots of tests.)

Gary

On Sun, Jul 22, 2018 at 10:44 PM Ralph Goers 
wrote:

> This is a vote to release Log4j 2.11.1, the next version of the Log4j 2
> project.
>
> Please download, test, and cast your votes on the log4j developers list.
> [] +1, release the artifacts
> [] -1, don't release because...
>
> The vote will remain open for 72 hours (or more if required). All votes
> are welcome and we encourage everyone to test the release, but only Logging
> PMC votes are “officially” counted. As always, at least 3 +1 votes and more
> positive than negative votes are required.
>
> Changes in this release include:
>
> Fixed Bugs
>
> • LOG4J2-2389: ThrowableProxy was saving and retrieving cache
> entries using different keys. Thanks to Liu Wen.
> • LOG4J2-2316: If root LoggerConfig does not have a Level return
> ERROR.
> • LOG4J2-2390: Fix broken links in log4j web documentation. Thanks
> to anton-balaniuc.
> • LOG4J2-2343: The OSGi Activator specified an incorrect version.
> Thanks to Raymond Augé.
> • LOG4J2-2305: Make java.util.ServiceLoader properly work in OSGi
> by using the Service Loader Mediator Specification. Thanks to Björn Kautler.
> • LOG4J2-2305: Split the SLF4J binding into 2 implementations -
> one for SLF4J 1.7.x and one for SLF4J 1.8+.
> • LOG4J2-2268: Improve plugin error message when elements are
> missing. Thanks to Tilman Hausherr.
> • LOG4J2-2283: ParserConfigurationException when using Log4j with
> oracle.xml.jaxp.JXDocumentBuilderFactory. Thanks to Vishnu Priya Matha.
> • LOG4J2-2300: PoolingDriverConnectionSource does not take into
> account properties, user name, and password.
> • LOG4J2-2307: MutableLogEvent and RingBufferLogEvent message
> mementos retain the original format string.
> • LOG4J2-2032: Curly braces in parameters are not treated as
> placeholders. Thanks to Kostiantyn Shchepanovskyi.
> • LOG4J2-2317: MutableLogEvent.getNonNullImmutableMessage and
> Log4jLogEvent.makeMessageImmutable retain format and parameters.
> • LOG4J2-2318: Messages are no longer mutated when the
> asynchronous queue is full. A warning is logged to the status logger
> instead.
> • LOG4J2-2320: Fix NPE in AbstractLogger when another exception is
> thrown, masking the root cause.
> • LOG4J2-2321: AsyncLogger uses the correct level when
> unspecified. This provides parity between AsyncLogger and Logger.
> • LOG4J2-2322: Custom ContextSelector implementations which select
> an AsyncLoggerContext disable LoggerConfig.includeLocation by default for
> parity with AsyncLoggerContextSelector.
> • LOG4J2-2269: MutableLogEvent references to other objects are
> cleared after each use. Fix a memory leak causing references to parameters
> to be held after synchronous logging with thread locals enabled.
> • LOG4J2-2301: Mixed async loggers no longer forget parameter
> values, providing some appenders with an array of nulls.
> • LOG4J2-2331: RollingFileManager debug logging avoids string
> concatenation and errant braces in favor of parameterized logging. Thanks
> to Mike Baranski.
> • LOG4J2-2333: Handle errors thrown in default disruptor
> ExceptionHandler implementations to avoid killing background threads.
> • LOG4J2-2334: Add API
> org.apache.logging.log4j.core.appender.AsyncAppender.getQueueSize().
> • LOG4J2-2336: Remove duplicate hyphen from the AsyncLoggerConfig
> background thread name.
> • LOG4J2-2347: Update Apache Commons Compress from 1.16.1 to 1.17.
> • LOG4J2-2352: RingBufferLogEvent memento messages provide the
> expected format string, and no longer attempt to substitute parameters into
> curly braces in parameter toString values. Both RingBufferLogEvent and
> MutableLogEvent memento implementations memoize results to avoid rebuilding
> formatted string values.
> • LOG4J2-2355: PropertiesUtil ignores non-string system
> properties. Fixes a NoClassDefFoundError initializing StatusLogger caused
> by an NPE while initializing the static PropertiesUtil field. Thanks to
> Henrik Brautaset Aronsen.
> • LOG4J2-2362: Fixed a memory leak in which ReusableObjectMessage
> would hold a reference to the most recently logged object.
> • LOG4J2-2312: Jackson layouts used with
> AsyncLoggerContextSelector output the expected format rather than only a
> JSON string of the message text.
> • LOG4J2-2364: Fixed a memory leak in which
> ReusableParameterizedMessage would hold a reference to the most recently
> logged throwable and provided varargs array.
> • LOG4J2-2368: Nested logging doesn't clobber AbstractStringLayout
> cached StringBuidlers
> • LOG4J2-2373: StringBuilders.escapeJson implementation runs in
> linear time.

Re: [VOTE] Release Log4j 2.11.1-rc1

2018-07-23 Thread Gary Gregory 
On Mon, Jul 23, 2018 at 10:59 AM Matt Sicker  wrote:

> Can't we just set up our rat rules globally rather than via a profile? It'd
> be nice if CI could catch missing license headers before working on making
> an RC.
>

+1. I do not see why we need a profile.

Gary

>
> On Mon, 23 Jul 2018 at 11:30, Ralph Goers 
> wrote:
>
> > When you do not use -P rat you are not using our configuration so you are
> > including files we specifically exclude. It is bound to fail if you don’t
> > use the profile.
> >
> > Ralph
> >
> >
> > > On Jul 23, 2018, at 8:15 AM, Gary Gregory 
> > wrote:
> > >
> > > On Mon, Jul 23, 2018 at 9:09 AM Ralph Goers <
> ralph.go...@dslextreme.com>
> > > wrote:
> > >
> > >> Interesting. As part of the release I always run
> > >>
> > >> mvn -P rat -DskipTests clean verify
> > >>
> > >> And it failed to complain about that.
> > >>
> > >
> > > I first ran 'mvn clean install' which I should not have. But since I
> did
> > > that first and THEN ran the RAT check, more files must have been
> slogged
> > > around and hence the failure. What is odd is that I just ran 'mvn
> clean'
> > > and then 'mvn clean apache-rat:check' and it fails as I noted so there
> > > might be something off in the POM config between running 'mvn clean
> > > apache-rat:check' and using the 'rat' profile.
> > >
> > > Gary
> > >
> > >
> > >
> > >>
> > >> As far as the MD5’s I seem to recall there was a recommendation not to
> > use
> > >> them but it wasn’t a mandate. I’m not sure where that email is.
> > >>
> > >> Ralph
> > >>
> > >>
> > >>
> > >>> On Jul 23, 2018, at 8:03 AM, Gary Gregory 
> > >> wrote:
> > >>>
> > >>> +1
> > >>>
> > >>> - From src zip: ASC OK, SHA1 OK.
> > >>>
> > >>> - Maven RAT check FAILs using 'mvn apache-rat:check':
> > >>>
> > >>> Files with unapproved licenses:
> > >>>
> > >>> C:/temp/rc/log4j/apache-log4j-2.11.1-src/log4j-cassandra/.toDelete
> > >>>
> > >>> Not a blocker since this is not a "source" file but should be fixed
> > ASAP
> > >>> IMO to make RC reviews simpler.
> > >>>
> > >>> Subsequent modules pass RAT check using 'mvn apache-rat:check -rf
> > >>> log4j-iostreams'
> > >>>
> > >>> - Clirr check using 'mvn clirr:check -pl log4j-api' FAILS with:
> > >>>
> > >>> [INFO] --- clirr-maven-plugin:2.8:check (default-cli) @ log4j-api ---
> > >>> [INFO] Comparing to version: 2.11.0
> > >>> [ERROR] Unable to find information in class
> > >>> org.apache.logging.log4j.util.StackLocator referring back to nested
> > class
> > >>> org.apache.logging.log4j.util.StackLocator$PrivateSecurityManager
> > >>>
> > >>> Probably OK since this is in the 'util' package. Probably OK here
> > though
> > >> we
> > >>> should try to use the japicmp Maven plugin instead of clirr.
> > >>>
> > >>> - Clirr check OK for 'mvn clirr:check -pl log4j-1.2-api'
> > >>>
> > >>> - Building 'mvn clean install' OK using:
> > >>>
> > >>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> > >>> 2018-06-17T12:33:14-06:00)
> > >>> Maven home: C:\Java\apache-maven-3.5.4\bin\..
> > >>> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime:
> > C:\Program
> > >>> Files\Java\jdk1.8.0_172\jre
> > >>> Default locale: en_US, platform encoding: Cp1252
> > >>> OS name: "windows 10", version: "10.0", arch: "amd64", family:
> > "windows"
> > >>>
> > >>> and tool chain:
> > >>>
> > >>> 
> > >>> 
> > >>> 
> > >>> 
> > >>> jdk
> > >>> 
> > >>> 1.6
> > >>> sun
> > >>> 
> > >>> 
> > >>> C:\Program Files\Java\jdk1.6.0_45
> > >>> 
> > >>> 
> > >>> 
> > >>> jdk
> > >>> 
> > >>> 1.7
> > >>> sun
> > >>> 
> > >>> 
> > >>> C:\Program Files\Java\jdk1.7.0_80
> > >>> 
> > >>> 
> > >>> 
> > >>> jdk
> > >>> 
> > >>> 1.8
> > >>> sun
> > >>> 
> > >>> 
> > >>> C:\Program Files\Java\jdk1.8.0_172
> > >>> 
> > >>> 
> > >>> 
> > >>> jdk
> > >>> 
> > >>> 9
> > >>> sun
> > >>> 
> > >>> 
> > >>> C:\Program Files\Java\jdk-9.0.4
> > >>> 
> > >>> 
> > >>> 
> > >>> jdk
> > >>> 
> > >>> 10
> > >>> sun
> > >>> 
> > >>> 
> > >>> C:\Program Files\Java\jdk-10.0.1
> > >>> 
> > >>> 
> > >>> 
> > >>> jdk
> > >>> 
> > >>> 11
> > >>> sun
> > >>> 
> > >>> 
> > >>> C:\Program Files\Java\jdk-11
> > >>> 
> > >>> 
> > >>> 
> > >>>
> > >>> Gary
> > >>>
> > >>>
> > >>> On Sun, Jul 22, 2018 at 10:44 PM Ralph Goers <
> > ralph.go...@dslextreme.com
> > >>>
> > >>> wrote:
> > >>>
> >  This is a vote to release Log4j 2.11.1, the next version of the
> Log4j
> > 2
> >  project.
> > 
> >  Please download, test, and cast your votes on the log4j developers
> > list.
> >  [] +1, release the artifacts
> >  [] -1, don't release because...
> > 
> >  The vote will remain open for 72 hours (or more if required). All
> > votes
> >  are welcome and we encourage everyone to test the release, but only
> > >> Logging
> >  PMC votes are “officially” counted. As always, at least 3 +1 votes
> and
> > >> more
> >  positive than negative votes are required.
> > 
> >  Changes in this release include:
> > 
> >  Fixed Bugs
> > 
> >

Re: [VOTE] Release Log4j 2.11.1-rc1

2018-07-23 Thread Matt Sicker 
Can't we just set up our rat rules globally rather than via a profile? It'd
be nice if CI could catch missing license headers before working on making
an RC.

On Mon, 23 Jul 2018 at 11:30, Ralph Goers 
wrote:

> When you do not use -P rat you are not using our configuration so you are
> including files we specifically exclude. It is bound to fail if you don’t
> use the profile.
>
> Ralph
>
>
> > On Jul 23, 2018, at 8:15 AM, Gary Gregory 
> wrote:
> >
> > On Mon, Jul 23, 2018 at 9:09 AM Ralph Goers 
> > wrote:
> >
> >> Interesting. As part of the release I always run
> >>
> >> mvn -P rat -DskipTests clean verify
> >>
> >> And it failed to complain about that.
> >>
> >
> > I first ran 'mvn clean install' which I should not have. But since I did
> > that first and THEN ran the RAT check, more files must have been slogged
> > around and hence the failure. What is odd is that I just ran 'mvn clean'
> > and then 'mvn clean apache-rat:check' and it fails as I noted so there
> > might be something off in the POM config between running 'mvn clean
> > apache-rat:check' and using the 'rat' profile.
> >
> > Gary
> >
> >
> >
> >>
> >> As far as the MD5’s I seem to recall there was a recommendation not to
> use
> >> them but it wasn’t a mandate. I’m not sure where that email is.
> >>
> >> Ralph
> >>
> >>
> >>
> >>> On Jul 23, 2018, at 8:03 AM, Gary Gregory 
> >> wrote:
> >>>
> >>> +1
> >>>
> >>> - From src zip: ASC OK, SHA1 OK.
> >>>
> >>> - Maven RAT check FAILs using 'mvn apache-rat:check':
> >>>
> >>> Files with unapproved licenses:
> >>>
> >>> C:/temp/rc/log4j/apache-log4j-2.11.1-src/log4j-cassandra/.toDelete
> >>>
> >>> Not a blocker since this is not a "source" file but should be fixed
> ASAP
> >>> IMO to make RC reviews simpler.
> >>>
> >>> Subsequent modules pass RAT check using 'mvn apache-rat:check -rf
> >>> log4j-iostreams'
> >>>
> >>> - Clirr check using 'mvn clirr:check -pl log4j-api' FAILS with:
> >>>
> >>> [INFO] --- clirr-maven-plugin:2.8:check (default-cli) @ log4j-api ---
> >>> [INFO] Comparing to version: 2.11.0
> >>> [ERROR] Unable to find information in class
> >>> org.apache.logging.log4j.util.StackLocator referring back to nested
> class
> >>> org.apache.logging.log4j.util.StackLocator$PrivateSecurityManager
> >>>
> >>> Probably OK since this is in the 'util' package. Probably OK here
> though
> >> we
> >>> should try to use the japicmp Maven plugin instead of clirr.
> >>>
> >>> - Clirr check OK for 'mvn clirr:check -pl log4j-1.2-api'
> >>>
> >>> - Building 'mvn clean install' OK using:
> >>>
> >>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> >>> 2018-06-17T12:33:14-06:00)
> >>> Maven home: C:\Java\apache-maven-3.5.4\bin\..
> >>> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime:
> C:\Program
> >>> Files\Java\jdk1.8.0_172\jre
> >>> Default locale: en_US, platform encoding: Cp1252
> >>> OS name: "windows 10", version: "10.0", arch: "amd64", family:
> "windows"
> >>>
> >>> and tool chain:
> >>>
> >>> 
> >>> 
> >>> 
> >>> 
> >>> jdk
> >>> 
> >>> 1.6
> >>> sun
> >>> 
> >>> 
> >>> C:\Program Files\Java\jdk1.6.0_45
> >>> 
> >>> 
> >>> 
> >>> jdk
> >>> 
> >>> 1.7
> >>> sun
> >>> 
> >>> 
> >>> C:\Program Files\Java\jdk1.7.0_80
> >>> 
> >>> 
> >>> 
> >>> jdk
> >>> 
> >>> 1.8
> >>> sun
> >>> 
> >>> 
> >>> C:\Program Files\Java\jdk1.8.0_172
> >>> 
> >>> 
> >>> 
> >>> jdk
> >>> 
> >>> 9
> >>> sun
> >>> 
> >>> 
> >>> C:\Program Files\Java\jdk-9.0.4
> >>> 
> >>> 
> >>> 
> >>> jdk
> >>> 
> >>> 10
> >>> sun
> >>> 
> >>> 
> >>> C:\Program Files\Java\jdk-10.0.1
> >>> 
> >>> 
> >>> 
> >>> jdk
> >>> 
> >>> 11
> >>> sun
> >>> 
> >>> 
> >>> C:\Program Files\Java\jdk-11
> >>> 
> >>> 
> >>> 
> >>>
> >>> Gary
> >>>
> >>>
> >>> On Sun, Jul 22, 2018 at 10:44 PM Ralph Goers <
> ralph.go...@dslextreme.com
> >>>
> >>> wrote:
> >>>
>  This is a vote to release Log4j 2.11.1, the next version of the Log4j
> 2
>  project.
> 
>  Please download, test, and cast your votes on the log4j developers
> list.
>  [] +1, release the artifacts
>  [] -1, don't release because...
> 
>  The vote will remain open for 72 hours (or more if required). All
> votes
>  are welcome and we encourage everyone to test the release, but only
> >> Logging
>  PMC votes are “officially” counted. As always, at least 3 +1 votes and
> >> more
>  positive than negative votes are required.
> 
>  Changes in this release include:
> 
>  Fixed Bugs
> 
>    • LOG4J2-2389: ThrowableProxy was saving and retrieving cache
>  entries using different keys. Thanks to Liu Wen.
>    • LOG4J2-2316: If root LoggerConfig does not have a Level return
>  ERROR.
>    • LOG4J2-2390: Fix broken links in log4j web documentation.
> >> Thanks
>  to anton-balaniuc.
>    • LOG4J2-2343: The OSGi Activator specified an incorrect
> version.
>  Thanks to Raymond Augé.
>    • LOG4J2-2305: Make java.util.ServiceLoader properly work in
> OSGi
>

Re: [VOTE] Release Log4j 2.11.1-rc1

2018-07-23 Thread Ralph Goers 
When you do not use -P rat you are not using our configuration so you are 
including files we specifically exclude. It is bound to fail if you don’t use 
the profile.

Ralph


> On Jul 23, 2018, at 8:15 AM, Gary Gregory  wrote:
> 
> On Mon, Jul 23, 2018 at 9:09 AM Ralph Goers 
> wrote:
> 
>> Interesting. As part of the release I always run
>> 
>> mvn -P rat -DskipTests clean verify
>> 
>> And it failed to complain about that.
>> 
> 
> I first ran 'mvn clean install' which I should not have. But since I did
> that first and THEN ran the RAT check, more files must have been slogged
> around and hence the failure. What is odd is that I just ran 'mvn clean'
> and then 'mvn clean apache-rat:check' and it fails as I noted so there
> might be something off in the POM config between running 'mvn clean
> apache-rat:check' and using the 'rat' profile.
> 
> Gary
> 
> 
> 
>> 
>> As far as the MD5’s I seem to recall there was a recommendation not to use
>> them but it wasn’t a mandate. I’m not sure where that email is.
>> 
>> Ralph
>> 
>> 
>> 
>>> On Jul 23, 2018, at 8:03 AM, Gary Gregory 
>> wrote:
>>> 
>>> +1
>>> 
>>> - From src zip: ASC OK, SHA1 OK.
>>> 
>>> - Maven RAT check FAILs using 'mvn apache-rat:check':
>>> 
>>> Files with unapproved licenses:
>>> 
>>> C:/temp/rc/log4j/apache-log4j-2.11.1-src/log4j-cassandra/.toDelete
>>> 
>>> Not a blocker since this is not a "source" file but should be fixed ASAP
>>> IMO to make RC reviews simpler.
>>> 
>>> Subsequent modules pass RAT check using 'mvn apache-rat:check -rf
>>> log4j-iostreams'
>>> 
>>> - Clirr check using 'mvn clirr:check -pl log4j-api' FAILS with:
>>> 
>>> [INFO] --- clirr-maven-plugin:2.8:check (default-cli) @ log4j-api ---
>>> [INFO] Comparing to version: 2.11.0
>>> [ERROR] Unable to find information in class
>>> org.apache.logging.log4j.util.StackLocator referring back to nested class
>>> org.apache.logging.log4j.util.StackLocator$PrivateSecurityManager
>>> 
>>> Probably OK since this is in the 'util' package. Probably OK here though
>> we
>>> should try to use the japicmp Maven plugin instead of clirr.
>>> 
>>> - Clirr check OK for 'mvn clirr:check -pl log4j-1.2-api'
>>> 
>>> - Building 'mvn clean install' OK using:
>>> 
>>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
>>> 2018-06-17T12:33:14-06:00)
>>> Maven home: C:\Java\apache-maven-3.5.4\bin\..
>>> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: C:\Program
>>> Files\Java\jdk1.8.0_172\jre
>>> Default locale: en_US, platform encoding: Cp1252
>>> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>>> 
>>> and tool chain:
>>> 
>>> 
>>> 
>>> 
>>> 
>>> jdk
>>> 
>>> 1.6
>>> sun
>>> 
>>> 
>>> C:\Program Files\Java\jdk1.6.0_45
>>> 
>>> 
>>> 
>>> jdk
>>> 
>>> 1.7
>>> sun
>>> 
>>> 
>>> C:\Program Files\Java\jdk1.7.0_80
>>> 
>>> 
>>> 
>>> jdk
>>> 
>>> 1.8
>>> sun
>>> 
>>> 
>>> C:\Program Files\Java\jdk1.8.0_172
>>> 
>>> 
>>> 
>>> jdk
>>> 
>>> 9
>>> sun
>>> 
>>> 
>>> C:\Program Files\Java\jdk-9.0.4
>>> 
>>> 
>>> 
>>> jdk
>>> 
>>> 10
>>> sun
>>> 
>>> 
>>> C:\Program Files\Java\jdk-10.0.1
>>> 
>>> 
>>> 
>>> jdk
>>> 
>>> 11
>>> sun
>>> 
>>> 
>>> C:\Program Files\Java\jdk-11
>>> 
>>> 
>>> 
>>> 
>>> Gary
>>> 
>>> 
>>> On Sun, Jul 22, 2018 at 10:44 PM Ralph Goers >> 
>>> wrote:
>>> 
 This is a vote to release Log4j 2.11.1, the next version of the Log4j 2
 project.
 
 Please download, test, and cast your votes on the log4j developers list.
 [] +1, release the artifacts
 [] -1, don't release because...
 
 The vote will remain open for 72 hours (or more if required). All votes
 are welcome and we encourage everyone to test the release, but only
>> Logging
 PMC votes are “officially” counted. As always, at least 3 +1 votes and
>> more
 positive than negative votes are required.
 
 Changes in this release include:
 
 Fixed Bugs
 
   • LOG4J2-2389: ThrowableProxy was saving and retrieving cache
 entries using different keys. Thanks to Liu Wen.
   • LOG4J2-2316: If root LoggerConfig does not have a Level return
 ERROR.
   • LOG4J2-2390: Fix broken links in log4j web documentation.
>> Thanks
 to anton-balaniuc.
   • LOG4J2-2343: The OSGi Activator specified an incorrect version.
 Thanks to Raymond Augé.
   • LOG4J2-2305: Make java.util.ServiceLoader properly work in OSGi
 by using the Service Loader Mediator Specification. Thanks to Björn
>> Kautler.
   • LOG4J2-2305: Split the SLF4J binding into 2 implementations -
 one for SLF4J 1.7.x and one for SLF4J 1.8+.
   • LOG4J2-2268: Improve plugin error message when elements are
 missing. Thanks to Tilman Hausherr.
   • LOG4J2-2283: ParserConfigurationException when using Log4j with
 oracle.xml.jaxp.JXDocumentBuilderFactory. Thanks to Vishnu Priya Matha.
   • LOG4J2-2300: PoolingDriverConnectionSource does not take into
 account properties, user name, and

Re: [VOTE] Release Log4j 2.11.1-rc1

2018-07-23 Thread Gary Gregory 
On Mon, Jul 23, 2018 at 9:09 AM Ralph Goers 
wrote:

> Interesting. As part of the release I always run
>
> mvn -P rat -DskipTests clean verify
>
> And it failed to complain about that.
>
> As far as the MD5’s I seem to recall there was a recommendation not to use
> them but it wasn’t a mandate. I’m not sure where that email is.
>

Here is the relevant page:
https://www.apache.org/dev/release-publishing.html

"Please don't publish .md5 files, because MD5 is too broken
. "

Gary


> Ralph
>
>
>
> > On Jul 23, 2018, at 8:03 AM, Gary Gregory 
> wrote:
> >
> > +1
> >
> > - From src zip: ASC OK, SHA1 OK.
> >
> > - Maven RAT check FAILs using 'mvn apache-rat:check':
> >
> > Files with unapproved licenses:
> >
> >  C:/temp/rc/log4j/apache-log4j-2.11.1-src/log4j-cassandra/.toDelete
> >
> > Not a blocker since this is not a "source" file but should be fixed ASAP
> > IMO to make RC reviews simpler.
> >
> > Subsequent modules pass RAT check using 'mvn apache-rat:check -rf
> > log4j-iostreams'
> >
> > - Clirr check using 'mvn clirr:check -pl log4j-api' FAILS with:
> >
> > [INFO] --- clirr-maven-plugin:2.8:check (default-cli) @ log4j-api ---
> > [INFO] Comparing to version: 2.11.0
> > [ERROR] Unable to find information in class
> > org.apache.logging.log4j.util.StackLocator referring back to nested class
> > org.apache.logging.log4j.util.StackLocator$PrivateSecurityManager
> >
> > Probably OK since this is in the 'util' package. Probably OK here though
> we
> > should try to use the japicmp Maven plugin instead of clirr.
> >
> > - Clirr check OK for 'mvn clirr:check -pl log4j-1.2-api'
> >
> > - Building 'mvn clean install' OK using:
> >
> > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> > 2018-06-17T12:33:14-06:00)
> > Maven home: C:\Java\apache-maven-3.5.4\bin\..
> > Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: C:\Program
> > Files\Java\jdk1.8.0_172\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> >
> > and tool chain:
> >
> > 
> > 
> > 
> > 
> > jdk
> > 
> > 1.6
> > sun
> > 
> > 
> > C:\Program Files\Java\jdk1.6.0_45
> > 
> > 
> > 
> > jdk
> > 
> > 1.7
> > sun
> > 
> > 
> > C:\Program Files\Java\jdk1.7.0_80
> > 
> > 
> > 
> > jdk
> > 
> > 1.8
> > sun
> > 
> > 
> > C:\Program Files\Java\jdk1.8.0_172
> > 
> > 
> > 
> > jdk
> > 
> > 9
> > sun
> > 
> > 
> > C:\Program Files\Java\jdk-9.0.4
> > 
> > 
> > 
> > jdk
> > 
> > 10
> > sun
> > 
> > 
> > C:\Program Files\Java\jdk-10.0.1
> > 
> > 
> > 
> > jdk
> > 
> > 11
> > sun
> > 
> > 
> > C:\Program Files\Java\jdk-11
> > 
> > 
> > 
> >
> > Gary
> >
> >
> > On Sun, Jul 22, 2018 at 10:44 PM Ralph Goers  >
> > wrote:
> >
> >> This is a vote to release Log4j 2.11.1, the next version of the Log4j 2
> >> project.
> >>
> >> Please download, test, and cast your votes on the log4j developers list.
> >> [] +1, release the artifacts
> >> [] -1, don't release because...
> >>
> >> The vote will remain open for 72 hours (or more if required). All votes
> >> are welcome and we encourage everyone to test the release, but only
> Logging
> >> PMC votes are “officially” counted. As always, at least 3 +1 votes and
> more
> >> positive than negative votes are required.
> >>
> >> Changes in this release include:
> >>
> >> Fixed Bugs
> >>
> >>• LOG4J2-2389: ThrowableProxy was saving and retrieving cache
> >> entries using different keys. Thanks to Liu Wen.
> >>• LOG4J2-2316: If root LoggerConfig does not have a Level return
> >> ERROR.
> >>• LOG4J2-2390: Fix broken links in log4j web documentation.
> Thanks
> >> to anton-balaniuc.
> >>• LOG4J2-2343: The OSGi Activator specified an incorrect version.
> >> Thanks to Raymond Augé.
> >>• LOG4J2-2305: Make java.util.ServiceLoader properly work in OSGi
> >> by using the Service Loader Mediator Specification. Thanks to Björn
> Kautler.
> >>• LOG4J2-2305: Split the SLF4J binding into 2 implementations -
> >> one for SLF4J 1.7.x and one for SLF4J 1.8+.
> >>• LOG4J2-2268: Improve plugin error message when elements are
> >> missing. Thanks to Tilman Hausherr.
> >>• LOG4J2-2283: ParserConfigurationException when using Log4j with
> >> oracle.xml.jaxp.JXDocumentBuilderFactory. Thanks to Vishnu Priya Matha.
> >>• LOG4J2-2300: PoolingDriverConnectionSource does not take into
> >> account properties, user name, and password.
> >>• LOG4J2-2307: MutableLogEvent and RingBufferLogEvent message
> >> mementos retain the original format string.
> >>• LOG4J2-2032: Curly braces in parameters are not treated as
> >> placeholders. Thanks to Kostiantyn Shchepanovskyi.
> >>• LOG4J2-2317: MutableLogEvent.getNonNullImmutableMessage and
> >> Log4jLogEvent.makeMessageImmutable retain format and parameters.
> >>• LOG4J2-2318: Messages are no longer mutated when the
> >> asynchronous queue is full. A

Re: [VOTE] Release Log4j 2.11.1-rc1

2018-07-23 Thread Gary Gregory 
On Mon, Jul 23, 2018 at 9:09 AM Ralph Goers 
wrote:

> Interesting. As part of the release I always run
>
> mvn -P rat -DskipTests clean verify
>
> And it failed to complain about that.
>

I first ran 'mvn clean install' which I should not have. But since I did
that first and THEN ran the RAT check, more files must have been slogged
around and hence the failure. What is odd is that I just ran 'mvn clean'
and then 'mvn clean apache-rat:check' and it fails as I noted so there
might be something off in the POM config between running 'mvn clean
apache-rat:check' and using the 'rat' profile.

Gary



>
> As far as the MD5’s I seem to recall there was a recommendation not to use
> them but it wasn’t a mandate. I’m not sure where that email is.
>
> Ralph
>
>
>
> > On Jul 23, 2018, at 8:03 AM, Gary Gregory 
> wrote:
> >
> > +1
> >
> > - From src zip: ASC OK, SHA1 OK.
> >
> > - Maven RAT check FAILs using 'mvn apache-rat:check':
> >
> > Files with unapproved licenses:
> >
> >  C:/temp/rc/log4j/apache-log4j-2.11.1-src/log4j-cassandra/.toDelete
> >
> > Not a blocker since this is not a "source" file but should be fixed ASAP
> > IMO to make RC reviews simpler.
> >
> > Subsequent modules pass RAT check using 'mvn apache-rat:check -rf
> > log4j-iostreams'
> >
> > - Clirr check using 'mvn clirr:check -pl log4j-api' FAILS with:
> >
> > [INFO] --- clirr-maven-plugin:2.8:check (default-cli) @ log4j-api ---
> > [INFO] Comparing to version: 2.11.0
> > [ERROR] Unable to find information in class
> > org.apache.logging.log4j.util.StackLocator referring back to nested class
> > org.apache.logging.log4j.util.StackLocator$PrivateSecurityManager
> >
> > Probably OK since this is in the 'util' package. Probably OK here though
> we
> > should try to use the japicmp Maven plugin instead of clirr.
> >
> > - Clirr check OK for 'mvn clirr:check -pl log4j-1.2-api'
> >
> > - Building 'mvn clean install' OK using:
> >
> > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> > 2018-06-17T12:33:14-06:00)
> > Maven home: C:\Java\apache-maven-3.5.4\bin\..
> > Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: C:\Program
> > Files\Java\jdk1.8.0_172\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> >
> > and tool chain:
> >
> > 
> > 
> > 
> > 
> > jdk
> > 
> > 1.6
> > sun
> > 
> > 
> > C:\Program Files\Java\jdk1.6.0_45
> > 
> > 
> > 
> > jdk
> > 
> > 1.7
> > sun
> > 
> > 
> > C:\Program Files\Java\jdk1.7.0_80
> > 
> > 
> > 
> > jdk
> > 
> > 1.8
> > sun
> > 
> > 
> > C:\Program Files\Java\jdk1.8.0_172
> > 
> > 
> > 
> > jdk
> > 
> > 9
> > sun
> > 
> > 
> > C:\Program Files\Java\jdk-9.0.4
> > 
> > 
> > 
> > jdk
> > 
> > 10
> > sun
> > 
> > 
> > C:\Program Files\Java\jdk-10.0.1
> > 
> > 
> > 
> > jdk
> > 
> > 11
> > sun
> > 
> > 
> > C:\Program Files\Java\jdk-11
> > 
> > 
> > 
> >
> > Gary
> >
> >
> > On Sun, Jul 22, 2018 at 10:44 PM Ralph Goers  >
> > wrote:
> >
> >> This is a vote to release Log4j 2.11.1, the next version of the Log4j 2
> >> project.
> >>
> >> Please download, test, and cast your votes on the log4j developers list.
> >> [] +1, release the artifacts
> >> [] -1, don't release because...
> >>
> >> The vote will remain open for 72 hours (or more if required). All votes
> >> are welcome and we encourage everyone to test the release, but only
> Logging
> >> PMC votes are “officially” counted. As always, at least 3 +1 votes and
> more
> >> positive than negative votes are required.
> >>
> >> Changes in this release include:
> >>
> >> Fixed Bugs
> >>
> >>• LOG4J2-2389: ThrowableProxy was saving and retrieving cache
> >> entries using different keys. Thanks to Liu Wen.
> >>• LOG4J2-2316: If root LoggerConfig does not have a Level return
> >> ERROR.
> >>• LOG4J2-2390: Fix broken links in log4j web documentation.
> Thanks
> >> to anton-balaniuc.
> >>• LOG4J2-2343: The OSGi Activator specified an incorrect version.
> >> Thanks to Raymond Augé.
> >>• LOG4J2-2305: Make java.util.ServiceLoader properly work in OSGi
> >> by using the Service Loader Mediator Specification. Thanks to Björn
> Kautler.
> >>• LOG4J2-2305: Split the SLF4J binding into 2 implementations -
> >> one for SLF4J 1.7.x and one for SLF4J 1.8+.
> >>• LOG4J2-2268: Improve plugin error message when elements are
> >> missing. Thanks to Tilman Hausherr.
> >>• LOG4J2-2283: ParserConfigurationException when using Log4j with
> >> oracle.xml.jaxp.JXDocumentBuilderFactory. Thanks to Vishnu Priya Matha.
> >>• LOG4J2-2300: PoolingDriverConnectionSource does not take into
> >> account properties, user name, and password.
> >>• LOG4J2-2307: MutableLogEvent and RingBufferLogEvent message
> >> mementos retain the original format string.
> >>• LOG4J2-2032: Curly braces in parameters are not treated as
> >> placeholders. Thanks to Kostiantyn Shchepanovskyi.
> >>• LOG4J2-2317:

Re: [VOTE] Release Log4j 2.11.1-rc1

2018-07-23 Thread Ralph Goers 
Interesting. As part of the release I always run 

mvn -P rat -DskipTests clean verify

And it failed to complain about that.

As far as the MD5’s I seem to recall there was a recommendation not to use them 
but it wasn’t a mandate. I’m not sure where that email is.

Ralph



> On Jul 23, 2018, at 8:03 AM, Gary Gregory  wrote:
> 
> +1
> 
> - From src zip: ASC OK, SHA1 OK.
> 
> - Maven RAT check FAILs using 'mvn apache-rat:check':
> 
> Files with unapproved licenses:
> 
>  C:/temp/rc/log4j/apache-log4j-2.11.1-src/log4j-cassandra/.toDelete
> 
> Not a blocker since this is not a "source" file but should be fixed ASAP
> IMO to make RC reviews simpler.
> 
> Subsequent modules pass RAT check using 'mvn apache-rat:check -rf
> log4j-iostreams'
> 
> - Clirr check using 'mvn clirr:check -pl log4j-api' FAILS with:
> 
> [INFO] --- clirr-maven-plugin:2.8:check (default-cli) @ log4j-api ---
> [INFO] Comparing to version: 2.11.0
> [ERROR] Unable to find information in class
> org.apache.logging.log4j.util.StackLocator referring back to nested class
> org.apache.logging.log4j.util.StackLocator$PrivateSecurityManager
> 
> Probably OK since this is in the 'util' package. Probably OK here though we
> should try to use the japicmp Maven plugin instead of clirr.
> 
> - Clirr check OK for 'mvn clirr:check -pl log4j-1.2-api'
> 
> - Building 'mvn clean install' OK using:
> 
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T12:33:14-06:00)
> Maven home: C:\Java\apache-maven-3.5.4\bin\..
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_172\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> 
> and tool chain:
> 
> 
> 
> 
> 
> jdk
> 
> 1.6
> sun
> 
> 
> C:\Program Files\Java\jdk1.6.0_45
> 
> 
> 
> jdk
> 
> 1.7
> sun
> 
> 
> C:\Program Files\Java\jdk1.7.0_80
> 
> 
> 
> jdk
> 
> 1.8
> sun
> 
> 
> C:\Program Files\Java\jdk1.8.0_172
> 
> 
> 
> jdk
> 
> 9
> sun
> 
> 
> C:\Program Files\Java\jdk-9.0.4
> 
> 
> 
> jdk
> 
> 10
> sun
> 
> 
> C:\Program Files\Java\jdk-10.0.1
> 
> 
> 
> jdk
> 
> 11
> sun
> 
> 
> C:\Program Files\Java\jdk-11
> 
> 
> 
> 
> Gary
> 
> 
> On Sun, Jul 22, 2018 at 10:44 PM Ralph Goers 
> wrote:
> 
>> This is a vote to release Log4j 2.11.1, the next version of the Log4j 2
>> project.
>> 
>> Please download, test, and cast your votes on the log4j developers list.
>> [] +1, release the artifacts
>> [] -1, don't release because...
>> 
>> The vote will remain open for 72 hours (or more if required). All votes
>> are welcome and we encourage everyone to test the release, but only Logging
>> PMC votes are “officially” counted. As always, at least 3 +1 votes and more
>> positive than negative votes are required.
>> 
>> Changes in this release include:
>> 
>> Fixed Bugs
>> 
>>• LOG4J2-2389: ThrowableProxy was saving and retrieving cache
>> entries using different keys. Thanks to Liu Wen.
>>• LOG4J2-2316: If root LoggerConfig does not have a Level return
>> ERROR.
>>• LOG4J2-2390: Fix broken links in log4j web documentation. Thanks
>> to anton-balaniuc.
>>• LOG4J2-2343: The OSGi Activator specified an incorrect version.
>> Thanks to Raymond Augé.
>>• LOG4J2-2305: Make java.util.ServiceLoader properly work in OSGi
>> by using the Service Loader Mediator Specification. Thanks to Björn Kautler.
>>• LOG4J2-2305: Split the SLF4J binding into 2 implementations -
>> one for SLF4J 1.7.x and one for SLF4J 1.8+.
>>• LOG4J2-2268: Improve plugin error message when elements are
>> missing. Thanks to Tilman Hausherr.
>>• LOG4J2-2283: ParserConfigurationException when using Log4j with
>> oracle.xml.jaxp.JXDocumentBuilderFactory. Thanks to Vishnu Priya Matha.
>>• LOG4J2-2300: PoolingDriverConnectionSource does not take into
>> account properties, user name, and password.
>>• LOG4J2-2307: MutableLogEvent and RingBufferLogEvent message
>> mementos retain the original format string.
>>• LOG4J2-2032: Curly braces in parameters are not treated as
>> placeholders. Thanks to Kostiantyn Shchepanovskyi.
>>• LOG4J2-2317: MutableLogEvent.getNonNullImmutableMessage and
>> Log4jLogEvent.makeMessageImmutable retain format and parameters.
>>• LOG4J2-2318: Messages are no longer mutated when the
>> asynchronous queue is full. A warning is logged to the status logger
>> instead.
>>• LOG4J2-2320: Fix NPE in AbstractLogger when another exception is
>> thrown, masking the root cause.
>>• LOG4J2-2321: AsyncLogger uses the correct level when
>> unspecified. This provides parity between AsyncLogger and Logger.
>>• LOG4J2-2322: Custom ContextSelector implementations which select
>> an AsyncLoggerContext disable LoggerConfig.includeLocation by default for
>> parity with AsyncLoggerContextSelector.
>>• LOG4J2-2269: MutableLogEvent references to other objects are
>> cleared after

Re: [VOTE] Release Log4j 2.11.1-rc1

2018-07-23 Thread Gary Gregory 
 +1

- From src zip: ASC OK, SHA1 OK.

- Maven RAT check FAILs using 'mvn apache-rat:check':

Files with unapproved licenses:

  C:/temp/rc/log4j/apache-log4j-2.11.1-src/log4j-cassandra/.toDelete

Not a blocker since this is not a "source" file but should be fixed ASAP
IMO to make RC reviews simpler.

Subsequent modules pass RAT check using 'mvn apache-rat:check -rf
log4j-iostreams'

- Clirr check using 'mvn clirr:check -pl log4j-api' FAILS with:

[INFO] --- clirr-maven-plugin:2.8:check (default-cli) @ log4j-api ---
[INFO] Comparing to version: 2.11.0
[ERROR] Unable to find information in class
org.apache.logging.log4j.util.StackLocator referring back to nested class
org.apache.logging.log4j.util.StackLocator$PrivateSecurityManager

Probably OK since this is in the 'util' package. Probably OK here though we
should try to use the japicmp Maven plugin instead of clirr.

- Clirr check OK for 'mvn clirr:check -pl log4j-1.2-api'

- Building 'mvn clean install' OK using:

Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T12:33:14-06:00)
Maven home: C:\Java\apache-maven-3.5.4\bin\..
Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_172\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

and tool chain:





jdk

1.6
sun


C:\Program Files\Java\jdk1.6.0_45



jdk

1.7
sun


C:\Program Files\Java\jdk1.7.0_80



jdk

1.8
sun


C:\Program Files\Java\jdk1.8.0_172



jdk

9
sun


C:\Program Files\Java\jdk-9.0.4



jdk

10
sun


C:\Program Files\Java\jdk-10.0.1



jdk

11
sun


C:\Program Files\Java\jdk-11




Gary


On Sun, Jul 22, 2018 at 10:44 PM Ralph Goers 
wrote:

> This is a vote to release Log4j 2.11.1, the next version of the Log4j 2
> project.
>
> Please download, test, and cast your votes on the log4j developers list.
> [] +1, release the artifacts
> [] -1, don't release because...
>
> The vote will remain open for 72 hours (or more if required). All votes
> are welcome and we encourage everyone to test the release, but only Logging
> PMC votes are “officially” counted. As always, at least 3 +1 votes and more
> positive than negative votes are required.
>
> Changes in this release include:
>
> Fixed Bugs
>
> • LOG4J2-2389: ThrowableProxy was saving and retrieving cache
> entries using different keys. Thanks to Liu Wen.
> • LOG4J2-2316: If root LoggerConfig does not have a Level return
> ERROR.
> • LOG4J2-2390: Fix broken links in log4j web documentation. Thanks
> to anton-balaniuc.
> • LOG4J2-2343: The OSGi Activator specified an incorrect version.
> Thanks to Raymond Augé.
> • LOG4J2-2305: Make java.util.ServiceLoader properly work in OSGi
> by using the Service Loader Mediator Specification. Thanks to Björn Kautler.
> • LOG4J2-2305: Split the SLF4J binding into 2 implementations -
> one for SLF4J 1.7.x and one for SLF4J 1.8+.
> • LOG4J2-2268: Improve plugin error message when elements are
> missing. Thanks to Tilman Hausherr.
> • LOG4J2-2283: ParserConfigurationException when using Log4j with
> oracle.xml.jaxp.JXDocumentBuilderFactory. Thanks to Vishnu Priya Matha.
> • LOG4J2-2300: PoolingDriverConnectionSource does not take into
> account properties, user name, and password.
> • LOG4J2-2307: MutableLogEvent and RingBufferLogEvent message
> mementos retain the original format string.
> • LOG4J2-2032: Curly braces in parameters are not treated as
> placeholders. Thanks to Kostiantyn Shchepanovskyi.
> • LOG4J2-2317: MutableLogEvent.getNonNullImmutableMessage and
> Log4jLogEvent.makeMessageImmutable retain format and parameters.
> • LOG4J2-2318: Messages are no longer mutated when the
> asynchronous queue is full. A warning is logged to the status logger
> instead.
> • LOG4J2-2320: Fix NPE in AbstractLogger when another exception is
> thrown, masking the root cause.
> • LOG4J2-2321: AsyncLogger uses the correct level when
> unspecified. This provides parity between AsyncLogger and Logger.
> • LOG4J2-2322: Custom ContextSelector implementations which select
> an AsyncLoggerContext disable LoggerConfig.includeLocation by default for
> parity with AsyncLoggerContextSelector.
> • LOG4J2-2269: MutableLogEvent references to other objects are
> cleared after each use. Fix a memory leak causing references to parameters
> to be held after synchronous logging with thread locals enabled.
> • LOG4J2-2301: Mixed async loggers no longer forget parameter
> values, providing some appenders with an array of nulls.
> • LOG4J2-2331: RollingFileManager debug logging avoids string
> concatenation and errant braces in favor of parameterized logging. Thanks
> to Mike Baranski.
> • LOG4J2-2333: Handle errors thrown in default disruptor
> ExceptionHandler implementations to avoid killing background threads.
> • LOG4J2-2334: Add

Re: [VOTE] Release Log4j 2.11.1-rc1

2018-07-23 Thread Gary Gregory 
Review still in progress, please ignore below.

On Mon, Jul 23, 2018 at 8:54 AM Gary Gregory  wrote:

> +1
>
> From src zip: ASC OK, SHA1 OK.
>
> Maven RAT check OK using 'mvn apache-rat:check'.
>
> Clirr check using 'mvn clirr:check -pl log4j-api,log4j-1.2-api'
>
> Building 'mvn clean install' OK using:
>
>
>
> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T12:33:14-06:00)
> Maven home: C:\Java\apache-maven-3.5.4\bin\..
> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_172\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>
> and tool chain:
>
> 
> 
> 
> 
> jdk
> 
> 1.6
> sun
> 
> 
> C:\Program Files\Java\jdk1.6.0_45
> 
> 
> 
> jdk
> 
> 1.7
> sun
> 
> 
> C:\Program Files\Java\jdk1.7.0_80
> 
> 
> 
> jdk
> 
> 1.8
> sun
> 
> 
> C:\Program Files\Java\jdk1.8.0_172
> 
> 
> 
> jdk
> 
> 9
> sun
> 
> 
> C:\Program Files\Java\jdk-9.0.4
> 
> 
> 
> jdk
> 
> 10
> sun
> 
> 
> C:\Program Files\Java\jdk-10.0.1
> 
> 
> 
> jdk
> 
> 11
> sun
> 
> 
> C:\Program Files\Java\jdk-11
> 
> 
> 
>
> Gary
>
> On Sun, Jul 22, 2018 at 10:44 PM Ralph Goers 
> wrote:
>
>> This is a vote to release Log4j 2.11.1, the next version of the Log4j 2
>> project.
>>
>> Please download, test, and cast your votes on the log4j developers list.
>> [] +1, release the artifacts
>> [] -1, don't release because...
>>
>> The vote will remain open for 72 hours (or more if required). All votes
>> are welcome and we encourage everyone to test the release, but only Logging
>> PMC votes are “officially” counted. As always, at least 3 +1 votes and more
>> positive than negative votes are required.
>>
>> Changes in this release include:
>>
>> Fixed Bugs
>>
>> • LOG4J2-2389: ThrowableProxy was saving and retrieving cache
>> entries using different keys. Thanks to Liu Wen.
>> • LOG4J2-2316: If root LoggerConfig does not have a Level return
>> ERROR.
>> • LOG4J2-2390: Fix broken links in log4j web documentation.
>> Thanks to anton-balaniuc.
>> • LOG4J2-2343: The OSGi Activator specified an incorrect version.
>> Thanks to Raymond Augé.
>> • LOG4J2-2305: Make java.util.ServiceLoader properly work in OSGi
>> by using the Service Loader Mediator Specification. Thanks to Björn Kautler.
>> • LOG4J2-2305: Split the SLF4J binding into 2 implementations -
>> one for SLF4J 1.7.x and one for SLF4J 1.8+.
>> • LOG4J2-2268: Improve plugin error message when elements are
>> missing. Thanks to Tilman Hausherr.
>> • LOG4J2-2283: ParserConfigurationException when using Log4j with
>> oracle.xml.jaxp.JXDocumentBuilderFactory. Thanks to Vishnu Priya Matha.
>> • LOG4J2-2300: PoolingDriverConnectionSource does not take into
>> account properties, user name, and password.
>> • LOG4J2-2307: MutableLogEvent and RingBufferLogEvent message
>> mementos retain the original format string.
>> • LOG4J2-2032: Curly braces in parameters are not treated as
>> placeholders. Thanks to Kostiantyn Shchepanovskyi.
>> • LOG4J2-2317: MutableLogEvent.getNonNullImmutableMessage and
>> Log4jLogEvent.makeMessageImmutable retain format and parameters.
>> • LOG4J2-2318: Messages are no longer mutated when the
>> asynchronous queue is full. A warning is logged to the status logger
>> instead.
>> • LOG4J2-2320: Fix NPE in AbstractLogger when another exception
>> is thrown, masking the root cause.
>> • LOG4J2-2321: AsyncLogger uses the correct level when
>> unspecified. This provides parity between AsyncLogger and Logger.
>> • LOG4J2-2322: Custom ContextSelector implementations which
>> select an AsyncLoggerContext disable LoggerConfig.includeLocation by
>> default for parity with AsyncLoggerContextSelector.
>> • LOG4J2-2269: MutableLogEvent references to other objects are
>> cleared after each use. Fix a memory leak causing references to parameters
>> to be held after synchronous logging with thread locals enabled.
>> • LOG4J2-2301: Mixed async loggers no longer forget parameter
>> values, providing some appenders with an array of nulls.
>> • LOG4J2-2331: RollingFileManager debug logging avoids string
>> concatenation and errant braces in favor of parameterized logging. Thanks
>> to Mike Baranski.
>> • LOG4J2-2333: Handle errors thrown in default disruptor
>> ExceptionHandler implementations to avoid killing background threads.
>> • LOG4J2-2334: Add API
>> org.apache.logging.log4j.core.appender.AsyncAppender.getQueueSize().
>> • LOG4J2-2336: Remove duplicate hyphen from the AsyncLoggerConfig
>> background thread name.
>> • LOG4J2-2347: Update Apache Commons Compress from 1.16.1 to 1.17.
>> • LOG4J2-2352: RingBufferLogEvent memento messages provide the
>> expected format string, and no longer attempt to substitute parameters into
>> curly braces in parameter toString values.

Re: [VOTE] Release Log4j 2.11.1-rc1

2018-07-23 Thread Gary Gregory 
+1

>From src zip: ASC OK, SHA1 OK.

Maven RAT check OK using 'mvn apache-rat:check'.

Clirr check using 'mvn clirr:check -pl log4j-api,log4j-1.2-api'

Building 'mvn clean install' OK using:



Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
2018-06-17T12:33:14-06:00)
Maven home: C:\Java\apache-maven-3.5.4\bin\..
Java version: 1.8.0_172, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_172\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

and tool chain:





jdk

1.6
sun


C:\Program Files\Java\jdk1.6.0_45



jdk

1.7
sun


C:\Program Files\Java\jdk1.7.0_80



jdk

1.8
sun


C:\Program Files\Java\jdk1.8.0_172



jdk

9
sun


C:\Program Files\Java\jdk-9.0.4



jdk

10
sun


C:\Program Files\Java\jdk-10.0.1



jdk

11
sun


C:\Program Files\Java\jdk-11




Gary

On Sun, Jul 22, 2018 at 10:44 PM Ralph Goers 
wrote:

> This is a vote to release Log4j 2.11.1, the next version of the Log4j 2
> project.
>
> Please download, test, and cast your votes on the log4j developers list.
> [] +1, release the artifacts
> [] -1, don't release because...
>
> The vote will remain open for 72 hours (or more if required). All votes
> are welcome and we encourage everyone to test the release, but only Logging
> PMC votes are “officially” counted. As always, at least 3 +1 votes and more
> positive than negative votes are required.
>
> Changes in this release include:
>
> Fixed Bugs
>
> • LOG4J2-2389: ThrowableProxy was saving and retrieving cache
> entries using different keys. Thanks to Liu Wen.
> • LOG4J2-2316: If root LoggerConfig does not have a Level return
> ERROR.
> • LOG4J2-2390: Fix broken links in log4j web documentation. Thanks
> to anton-balaniuc.
> • LOG4J2-2343: The OSGi Activator specified an incorrect version.
> Thanks to Raymond Augé.
> • LOG4J2-2305: Make java.util.ServiceLoader properly work in OSGi
> by using the Service Loader Mediator Specification. Thanks to Björn Kautler.
> • LOG4J2-2305: Split the SLF4J binding into 2 implementations -
> one for SLF4J 1.7.x and one for SLF4J 1.8+.
> • LOG4J2-2268: Improve plugin error message when elements are
> missing. Thanks to Tilman Hausherr.
> • LOG4J2-2283: ParserConfigurationException when using Log4j with
> oracle.xml.jaxp.JXDocumentBuilderFactory. Thanks to Vishnu Priya Matha.
> • LOG4J2-2300: PoolingDriverConnectionSource does not take into
> account properties, user name, and password.
> • LOG4J2-2307: MutableLogEvent and RingBufferLogEvent message
> mementos retain the original format string.
> • LOG4J2-2032: Curly braces in parameters are not treated as
> placeholders. Thanks to Kostiantyn Shchepanovskyi.
> • LOG4J2-2317: MutableLogEvent.getNonNullImmutableMessage and
> Log4jLogEvent.makeMessageImmutable retain format and parameters.
> • LOG4J2-2318: Messages are no longer mutated when the
> asynchronous queue is full. A warning is logged to the status logger
> instead.
> • LOG4J2-2320: Fix NPE in AbstractLogger when another exception is
> thrown, masking the root cause.
> • LOG4J2-2321: AsyncLogger uses the correct level when
> unspecified. This provides parity between AsyncLogger and Logger.
> • LOG4J2-2322: Custom ContextSelector implementations which select
> an AsyncLoggerContext disable LoggerConfig.includeLocation by default for
> parity with AsyncLoggerContextSelector.
> • LOG4J2-2269: MutableLogEvent references to other objects are
> cleared after each use. Fix a memory leak causing references to parameters
> to be held after synchronous logging with thread locals enabled.
> • LOG4J2-2301: Mixed async loggers no longer forget parameter
> values, providing some appenders with an array of nulls.
> • LOG4J2-2331: RollingFileManager debug logging avoids string
> concatenation and errant braces in favor of parameterized logging. Thanks
> to Mike Baranski.
> • LOG4J2-2333: Handle errors thrown in default disruptor
> ExceptionHandler implementations to avoid killing background threads.
> • LOG4J2-2334: Add API
> org.apache.logging.log4j.core.appender.AsyncAppender.getQueueSize().
> • LOG4J2-2336: Remove duplicate hyphen from the AsyncLoggerConfig
> background thread name.
> • LOG4J2-2347: Update Apache Commons Compress from 1.16.1 to 1.17.
> • LOG4J2-2352: RingBufferLogEvent memento messages provide the
> expected format string, and no longer attempt to substitute parameters into
> curly braces in parameter toString values. Both RingBufferLogEvent and
> MutableLogEvent memento implementations memoize results to avoid rebuilding
> formatted string values.
> • LOG4J2-2355: PropertiesUtil ignores non-string system
> properties. Fixes a NoClassDefFoundError initializing StatusLogger caused
> by an NPE while initializing the static PropertiesUtil field.

Re: [VOTE] Release Log4j 2.11.1-rc1

2018-07-23 Thread Gary Gregory 
Per Apache policy, we should NOT distribute MD5 hash files. This is not a
blocker as long as these files do not make it past this RC out to the dirt
release server.

Gary

On Sun, Jul 22, 2018 at 10:44 PM Ralph Goers 
wrote:

> This is a vote to release Log4j 2.11.1, the next version of the Log4j 2
> project.
>
> Please download, test, and cast your votes on the log4j developers list.
> [] +1, release the artifacts
> [] -1, don't release because...
>
> The vote will remain open for 72 hours (or more if required). All votes
> are welcome and we encourage everyone to test the release, but only Logging
> PMC votes are “officially” counted. As always, at least 3 +1 votes and more
> positive than negative votes are required.
>
> Changes in this release include:
>
> Fixed Bugs
>
> • LOG4J2-2389: ThrowableProxy was saving and retrieving cache
> entries using different keys. Thanks to Liu Wen.
> • LOG4J2-2316: If root LoggerConfig does not have a Level return
> ERROR.
> • LOG4J2-2390: Fix broken links in log4j web documentation. Thanks
> to anton-balaniuc.
> • LOG4J2-2343: The OSGi Activator specified an incorrect version.
> Thanks to Raymond Augé.
> • LOG4J2-2305: Make java.util.ServiceLoader properly work in OSGi
> by using the Service Loader Mediator Specification. Thanks to Björn Kautler.
> • LOG4J2-2305: Split the SLF4J binding into 2 implementations -
> one for SLF4J 1.7.x and one for SLF4J 1.8+.
> • LOG4J2-2268: Improve plugin error message when elements are
> missing. Thanks to Tilman Hausherr.
> • LOG4J2-2283: ParserConfigurationException when using Log4j with
> oracle.xml.jaxp.JXDocumentBuilderFactory. Thanks to Vishnu Priya Matha.
> • LOG4J2-2300: PoolingDriverConnectionSource does not take into
> account properties, user name, and password.
> • LOG4J2-2307: MutableLogEvent and RingBufferLogEvent message
> mementos retain the original format string.
> • LOG4J2-2032: Curly braces in parameters are not treated as
> placeholders. Thanks to Kostiantyn Shchepanovskyi.
> • LOG4J2-2317: MutableLogEvent.getNonNullImmutableMessage and
> Log4jLogEvent.makeMessageImmutable retain format and parameters.
> • LOG4J2-2318: Messages are no longer mutated when the
> asynchronous queue is full. A warning is logged to the status logger
> instead.
> • LOG4J2-2320: Fix NPE in AbstractLogger when another exception is
> thrown, masking the root cause.
> • LOG4J2-2321: AsyncLogger uses the correct level when
> unspecified. This provides parity between AsyncLogger and Logger.
> • LOG4J2-2322: Custom ContextSelector implementations which select
> an AsyncLoggerContext disable LoggerConfig.includeLocation by default for
> parity with AsyncLoggerContextSelector.
> • LOG4J2-2269: MutableLogEvent references to other objects are
> cleared after each use. Fix a memory leak causing references to parameters
> to be held after synchronous logging with thread locals enabled.
> • LOG4J2-2301: Mixed async loggers no longer forget parameter
> values, providing some appenders with an array of nulls.
> • LOG4J2-2331: RollingFileManager debug logging avoids string
> concatenation and errant braces in favor of parameterized logging. Thanks
> to Mike Baranski.
> • LOG4J2-2333: Handle errors thrown in default disruptor
> ExceptionHandler implementations to avoid killing background threads.
> • LOG4J2-2334: Add API
> org.apache.logging.log4j.core.appender.AsyncAppender.getQueueSize().
> • LOG4J2-2336: Remove duplicate hyphen from the AsyncLoggerConfig
> background thread name.
> • LOG4J2-2347: Update Apache Commons Compress from 1.16.1 to 1.17.
> • LOG4J2-2352: RingBufferLogEvent memento messages provide the
> expected format string, and no longer attempt to substitute parameters into
> curly braces in parameter toString values. Both RingBufferLogEvent and
> MutableLogEvent memento implementations memoize results to avoid rebuilding
> formatted string values.
> • LOG4J2-2355: PropertiesUtil ignores non-string system
> properties. Fixes a NoClassDefFoundError initializing StatusLogger caused
> by an NPE while initializing the static PropertiesUtil field. Thanks to
> Henrik Brautaset Aronsen.
> • LOG4J2-2362: Fixed a memory leak in which ReusableObjectMessage
> would hold a reference to the most recently logged object.
> • LOG4J2-2312: Jackson layouts used with
> AsyncLoggerContextSelector output the expected format rather than only a
> JSON string of the message text.
> • LOG4J2-2364: Fixed a memory leak in which
> ReusableParameterizedMessage would hold a reference to the most recently
> logged throwable and provided varargs array.
> • LOG4J2-2368: Nested logging doesn't clobber AbstractStringLayout
> cached StringBuidlers
> • LOG4J2-2373: StringBuilders.escapeJson implementation runs in
> linear time. Escaping