Github user jtibshirani commented on the issue:
https://github.com/apache/lucene-solr/pull/375
@jimczi I tried a few different approaches (including updating
`RegexCompletionQuery#rewrite`), and this one turned out to be cleanest + most
consistent. I'm happy to give more details
GitHub user jtibshirani opened a pull request:
https://github.com/apache/lucene-solr/pull/375
LUCENE-8287: Ensure that empty regex completion queries always returns no
results.
This ensures parity with the standard `RegexpQuery`, which returns no
results for an
empty regex
Github user jtibshirani closed the pull request at:
https://github.com/apache/lucene-solr/pull/375
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
Github user jtibshirani commented on the issue:
https://github.com/apache/lucene-solr/pull/375
Thank you @rmuir for the pointer, and I'm sorry for the slow reply! I just
opened https://github.com/apache/lucene-solr/pull/383 to switch to
`Operations.isEmpty` -- @jimczi feel free
GitHub user jtibshirani opened a pull request:
https://github.com/apache/lucene-solr/pull/383
In ContextQuery, use a more comprehensive check for an empty prefix
automaton.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user jtibshirani commented on the issue:
https://github.com/apache/lucene-solr/pull/375
I'm sorry for the confusion -- I didn't mean complete parity with
`RegexpQuery`, as they are different queries with different behaviors, but
rather consistency how they treat an empty regex
