Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/500
It's only supported with Java 8, because that's our intended release
version.
---
-
To unsubscribe, e-mail: de
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/500
Hi,
Currently a Lucene release should be done with Java 8. Therefore all checks
like precommit have to be done with Java 8, otherwise we canât be sure that
it really works with
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/480
Thanks for removing the dependency hell!
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/510
Perfect. So it's even more performant with Java 9+.
Thanks, Christian
---
-
To unsubscribe, e-mail: dev-uns
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/328
If you can't make Solr work with the current public CustomAnalyzer API,
please keep it as is and use your own TokenizerChain in Solr. Please don't make
CustomAnalyzer unmodifia
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/328
Custom Analyzer was just added to have an easy-to-use Builder-Like API for
Analyzers. It was not meant to replace SOlr's (although it would be nice, but
it's impossible as I figu
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/392#discussion_r193109013
--- Diff: lucene/tools/forbiddenApis/base.txt ---
@@ -40,3 +40,21 @@ java.util.Collections#shuffle(java.util.List) @ Use
shuffle(List, Random
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/432#discussion_r208515533
--- Diff:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java ---
@@ -0,0 +1,488 @@
+package org.apache.lucene.store
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/432#discussion_r208518497
--- Diff:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDataOutput.java ---
@@ -0,0 +1,488 @@
+package org.apache.lucene.store
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/432#discussion_r208520676
--- Diff:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDirectory.java ---
@@ -0,0 +1,237 @@
+package org.apache.lucene.store
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/432#discussion_r209170130
--- Diff:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDirectory.java ---
@@ -0,0 +1,237 @@
+package org.apache.lucene.store
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/432#discussion_r209170816
--- Diff:
lucene/core/src/java/org/apache/lucene/store/ByteBuffersDirectory.java ---
@@ -0,0 +1,237 @@
+package org.apache.lucene.store
Github user uschindler commented on the pull request:
https://github.com/apache/lucene-solr/pull/53#issuecomment-43470477
If incrementToken() is final its enough to hold contract, so an additional
class would not be needed.
---
If your project is set up for it, you can reply to this
Github user uschindler commented on the pull request:
https://github.com/apache/lucene-solr/pull/96#issuecomment-56595072
Hi, see comments on https://issues.apache.org/jira/browse/LUCENE-5968 !
---
If your project is set up for it, you can reply to this email and have your
reply
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/287#discussion_r174147473
--- Diff: dev-tools/eclipse/dot.classpath.xsl ---
@@ -54,7 +55,23 @@
-
+
--- End
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/287#discussion_r174281383
--- Diff: dev-tools/eclipse/dot.classpath.xsl ---
@@ -54,7 +55,23 @@
-
+
--- End
Github user uschindler commented on the pull request:
https://github.com/apache/lucene-solr/pull/206#issuecomment-150497999
Hi,
a useful alternative to using commons-beanutils is using the JDK internal
bean classes. See
https://github.com/apache/lucene-solr/blob/trunk/solr/core
Github user uschindler commented on the pull request:
https://github.com/apache/lucene-solr/pull/206#issuecomment-153793014
Hey, yes exactly like that :-) I will review that later. Give me a day or
two, I am looking in merging it.
---
If your project is set up for it, you can reply
Github user uschindler commented on the pull request:
https://github.com/apache/lucene-solr/pull/206#issuecomment-153850780
Hi, this was merged into SVN. Can you close the pull request, the automatic
close did not work...
---
If your project is set up for it, you can reply to this
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/206#discussion_r42311681
--- Diff:
solr/contrib/extraction/src/java/org/apache/solr/handler/extraction/ExtractingRequestHandler.java
---
@@ -79,6 +81,20 @@ public void
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/206#discussion_r42311693
--- Diff:
solr/contrib/extraction/src/java/org/apache/solr/handler/extraction/ExtractingRequestHandler.java
---
@@ -79,6 +81,20 @@ public void
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/206#discussion_r42311704
--- Diff:
solr/contrib/extraction/src/java/org/apache/solr/handler/extraction/ParseContextConfig.java
---
@@ -0,0 +1,113 @@
+package
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/206#discussion_r42311723
--- Diff: solr/contrib/extraction/src/test-files/log4j.properties ---
@@ -0,0 +1,31 @@
+# Logging level
--- End diff --
Please
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/206#discussion_r42311743
--- Diff:
solr/contrib/extraction/src/test/org/apache/solr/handler/extraction/ParseContextConfigTest.java
---
@@ -0,0 +1,54 @@
+package
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/206#discussion_r42311748
--- Diff:
solr/contrib/extraction/src/java/org/apache/solr/handler/extraction/ParseContextConfig.java
---
@@ -0,0 +1,113 @@
+package
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/31#discussion_r60794497
--- Diff: solr/NOTICE.txt ---
@@ -396,6 +394,33 @@ https://github.com/rjohnsondev/java-libpst
JMatIO is a JAVA library to read/write/manipulate
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/31#discussion_r60798688
--- Diff: solr/NOTICE.txt ---
@@ -396,6 +394,33 @@ https://github.com/rjohnsondev/java-libpst
JMatIO is a JAVA library to read/write/manipulate
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/74#discussion_r76740913
--- Diff:
solr/core/src/java/org/apache/solr/core/backup/repository/LocalFileSystemRepository.java
---
@@ -58,21 +59,28 @@ public void init(NamedList
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/74#discussion_r77301896
--- Diff:
solr/core/src/test/org/apache/solr/cloud/TestLocalFSCloudBackupRestore.java ---
@@ -24,12 +24,20 @@
* such file-system would be
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/44
Hallo,
please also update all SHA1 hashes of files. Plesae run "ant precommit"
from root folder of Lu/Solr. This will report all missing things.
---
If your project is set up f
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/44
> I think this should work... ant precommit worked in Linux with these
modifications. I kept getting hangs with ant jar-checksums in Windows.
If you checkout with git on windows us
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/44
I merged everything successfully, but I get one test failure in
solr/contrib/extraction:
[junit4] FAILURE 0.05s J0 | ExtractingRequestHandlerTest.testXPath <<<
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/44
for me it still happens. I just merged the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/44
OK, I will merge again later. So I will revert my checkout once you have
fixed that. Otherwise all looks fine.
BTW: Can you remove the assumeFalse on Java 9, because PDFBox is fixed
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/44
Grep for that one and remove them. Tests should pass then with latest Java
9:
`assumeFalse("This test fails with Java 9
(https://issues.apache.org/jira/browse/PDFBOX
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/44
> will take a look. The test passed if you assumed that the html had two
bodies, but that's crazy...
I hope this test does not download the internet? It should all run local!
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/44
Were you able to fix the test or should I look into it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/44
LOL. So is this a bug in Solr or in TIKA? Because it did not happen
previously.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/44
What file formats are this? Documents? Otherwise please leave them out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/44
Did you check with Java 9 or should I do it? I am not sure about the last
assume removed, because there is another SOLR issue in the assume message' not
just the PDFBOX one.
---
If
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/44
I also only have Windows :)
I would leave out image format, but MS Access looks fine. Could we leave
out updating bouncycastl then?
---
If your project is set up for it, you can
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/44
Let's pick option 2 for now. Maybe update the rest of Solr after some
review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/44#discussion_r67575579
--- Diff:
solr/contrib/morphlines-cell/src/test/org/apache/solr/morphlines/cell/SolrCellMorphlineTest.java
---
@@ -42,8 +42,6 @@
@BeforeClass
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/44
OK, the tests pass for me successfully. Should I remove the
jackcess-encrypt package from your PR after merging (you said you will be away
this weekend)?
---
If your project is set up for
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/44
Hi I have applied some other fixes and will push soon. Currently ASF have
some problems with pushing:
git.exe push --progress "origin" master:master
Counting ob
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/44
Ah OK, so no problem on my side. I'll wait a bit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/197
Should we not have a non-empty message when logging the
InterruptedException?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user uschindler commented on the pull request:
https://github.com/apache/lucene-solr/commit/3c0d111d07184e96a73ca6dc05c6227d839724e2#commitcomment-25480968
Could you please ask your message on the Lucene development mailing list?
See here how to subscribe: https
Github user uschindler commented on the issue:
https://github.com/apache/lucene-solr/pull/245
Can we do this in a way to place all files inside the `/eclipse-build`
folder and not add additional gitignores. I would also not copy the solr
webapp, as this makes the whole setup more
49 matches
Mail list logo
