[GitHub] [lucene-solr] msokolov commented on issue #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio…

2019-09-11 Thread GitBox
msokolov commented on issue #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio… URL: https://github.com/apache/lucene-solr/pull/862#issuecomment-530494478 > Should it be marked experimental then ? The fact that we ship a single dictionary within the jar also

[GitHub] [lucene-solr] msokolov commented on issue #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio…

2019-09-11 Thread GitBox
msokolov commented on issue #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio… URL: https://github.com/apache/lucene-solr/pull/862#issuecomment-530482206 But to answer your question a little more fully: the way this works is, you use DictionaryBuilder, in the

[GitHub] [lucene-solr] msokolov commented on issue #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio…

2019-09-11 Thread GitBox
msokolov commented on issue #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio… URL: https://github.com/apache/lucene-solr/pull/862#issuecomment-530481447 Jim, I'm sorry - there was no comment for several days, so I assumed it was OK to push. Let's discuss, and if

[GitHub] [lucene-solr] msokolov commented on issue #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio…

2019-09-11 Thread GitBox
msokolov commented on issue #862: LUCENE-8971: Enable constructing JapaneseTokenizer with custom dictio… URL: https://github.com/apache/lucene-solr/pull/862#issuecomment-530426989 Also back-ported to 8x branch - this was a clean cherry-pick, so I didn't post a PR.